Closed Bug 313450 Opened 19 years ago Closed 18 years ago

Bug title line uses serif font

Categories

(Bugzilla :: User Interface, defect)

2.20
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: dev+mozilla, Assigned: Wurblzap)

References

()

Details

(Whiteboard: [fixed by blocker])

Attachments

(2 files, 1 obsolete file)

I've set my default font to sans serif in my Firefox preferences. AFAICS, all elements on a BZ bug report page now display in a sans-serif font - except for the bug title line (see screenshot). This is due to these lines

    #header h1
    {
        font-family: serif;

in this file:

https://bugzilla.mozilla.org/skins/standard/global.css
Attached patch Proposed patch. (obsolete) — Splinter Review
Oh, and I propose removing the left padding as 0.2em looks like an accident (neither no padding nor a value that's distinctly visible).
This also affects things line the dups page, preferences, and all the page.cgi stuff, but they all seem to be in #header h1 so one fix should get them all. Though, actually, some of them have bits in <h2> as well as <h1>, so it'd be good if the same serif font setting could be remove from "#header h2" too.
Is it only a serif/sans-serif issue or is the font suddenly smaller than it used to be? I don't recall it being so small.

Prog.
See bug 313461 and bug 313509 for font-size issues.
Assignee: myk → bugzilla-mozilla
Attachment #200487 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #205638 - Flags: review?
Blocks: bmo-skin-cleanup
No longer blocks: bmo-regress-20051022
Isn't this perhaps a good time to move the font-family declaration out of everywhere into body{}?
Comment on attachment 205638 [details] [diff] [review]
Patch v2, fixes h2,h3 as well

If somebody wants to set their font-family to serif then there's three places where it's hardcoded as sans-serif (banner version, footer and sidebar.xul).

There's also font-family: arial in template/en/default/admin/products/edit-common.html.tmpl , maybe on purpose?

I think we should do  what Marc suggested and move font-family to body{}. Other possiblity is to remove it completely and set it only where we need a special font. For example, in patch diff where monospaced font is requested.
Attachment #205638 - Flags: review? → review-
I'll fix this in bug 321556.
Depends on: 321556
Whiteboard: [blocker fill fix]
Assignee: bugzilla-mozilla → wurblzap
Status: ASSIGNED → NEW
Fixed by bug 321556.
Status: NEW → RESOLVED
Closed: 18 years ago
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [blocker fill fix] → [fixed by blocker]
Target Milestone: --- → Bugzilla 3.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: