313504 - Mid-air collision doesn't show all changes that were made

Status: RESOLVED WORKSFORME

(bugzilla.mozilla.org :: General, defect)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE:

1)  Load bug 311399 in two different windows.
2)  In the first window, click "Edit" link on attachment 199532 [details] [diff] [review] ("A different
    strategy")
3)  In the first window, add a comment using the " Comment (on the bug):" field
    on the attachment edit screen.
4)  In the second window add "bzbarsky" to cc (type that string in the cc
    addition field, and hit enter).

ACTUAL RESULTS:

  Mid-air collision detected!

  Someone else has made changes to this bug at the same time you were trying to.
  The changes made were:
  Your comment was:
  You have the following choices: 

EXPECTED RESULTS:

This depends on what we're trying to do.  If we're trying to show the mid-air collision screen, we should make it clear why and show the new comment that was added.  If we're not showing the comment because it in fact will not be overwritten, then I'd think we don't want to show the mid-air collision screen at all.  I would prefer that, myself.  ;)  As things stand, it's not obvious why this screen is being shown here.

Comment 1

[Max Kanat-Alexander]

I believe that this would probably be somewhat of a dup of the "attachments have no mid-air" bug, but I'm not certain.

Comment 2

[Boris Zbarsky [:bzbarsky]]

No, it's not a dup of the attachments thing.  All the changes being made were made to the bug itself, not to an attachment.  I'll bet that you can reproduce this by just adding a comment on the bug directly, but I didn't have a bugzilla.mozilla.org bug on hand that I wanted to spam.

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
> I didn't have a bugzilla.mozilla.org bug on hand that I wanted to spam.

  You could use http://landfill.bugzilla.org/bugzilla-2.20-branch/ if you want to see if it's upstream or bmo-specific (since that's upstream).

Comment 4

[Boris Zbarsky [:bzbarsky]]

OK, that shows the comment that I'm colliding with.  So sounds like this is a downstream issue?

Comment 5

[Max Kanat-Alexander]

(In reply to comment #4)
> OK, that shows the comment that I'm colliding with.  So sounds like this is a
> downstream issue?

  Yeah, most likely, if you can't reproduce it on landfill, it's bmo-specific, or something else is up.

Comment 6

[Dave Miller [:justdave]]

ok, this sounds weird...

Comment 7

[Dave Miller [:justdave]]

I can't reproduce.  I get my comment on the midair page when I add the CC.

Comment 8

[Dave Miller [:justdave]]

Attachment: dummy attachment so I have something to edit

Comment 9

[Dave Miller [:justdave]]

Comment on attachment 201727 [details]
dummy attachment so I have something to edit

test comment from edit attachment screen

Comment 10

[Dave Miller [:justdave]]

yeah, even with your exact instructions, I still get my comment on the midair screen.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Weird....  maybe it was a one-time hiccup...