313521 - Registry keys under HKEY_CURRENT_USER incorrect after application update

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Darin Fisher]

Registry keys under HKEY_CURRENT_USER incorrect after application update

nsPostUpdateWin.js only updates the keys under HKEY_LOCAL_MACHINE.  it needs to also update the same keys under HKEY_CURRENT_USER.

this should be an easy bug to fix since we can just run the same registry key update process twice.

Comment 1

[Darin Fisher]

Attachment: v1 patch - untested

This is probably what is needed, but I haven't had a chance to test this yet.

Comment 2

[Asa Dotzler [:asa]]

Darin, what are the negative effects of this bug?

Comment 3

[Darin Fisher]

Asa: The registry is simply not up to date.  so, if the user started with FF 1.4, and upgraded to 1.5 using SU, the registry would still say that the user is using 1.4.  Since these keys exist for the purpose of allowing other applications to find FF, it may be important that this information is correct.  I don't really know of any cases where things would go wrong, but it is possible I guess.  The fix should be simple, so I think we should try to make it happen.  This bug shouldn't impact our uninstaller.

Comment 4

[Mike Schroepfer]

Ben - Darin is pretty loaded and this is rather bad - any chance you can take it?

Comment 5

[Chase Phillips]

Via triage meeting proxy Dave L asks, "With this patch on multi-user systems, do we also update all user registry entries or only the current user's?"

Comment 6

[Darin Fisher]

> Via triage meeting proxy Dave L asks, "With this patch on multi-user systems,
> do we also update all user registry entries or only the current user's?"

We would only update the current user's.  I'm frankly not sure how the installer even deals with the multi-user case.  I suspect that it only touches the registry keys for the current user as well.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: 1.1 patch

This takes darin's existing patch and fixes a few errors:

1. need to invoke static properties on RegKey object using RegKey.prototype.foo, not RegKey.foo
2. make sure toString returns the string "HKEY_CURRENT_USER" for the HKCU key. 

r=ben for the original patch, requesting review from darin for these modifications.

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Ignore the change to nsUpdateService.js.in, that's part of another bug fix!

Comment 9

[Darin Fisher]

Comment on attachment 200674 [details] [diff] [review]
1.1 patch

great, thanks!

Comment 10

[Darin Fisher]

fixed-on-trunk

Comment 11

[Darin Fisher]

fixed1.8

Comment 12

[tyl2]

This bug has not been fixed for the release candidates. I'm at Fx1.5rc2 but the Add/Remove entry in WinXP still says 1.4.1. I think this bug needs be reopened and fixed before the 1.5 release. The version and target milestone fields should be updated for the bug, too.

Comment 13

[Reed Loden [:reed]]

Reopening as per comment 12's request.

Comment 14

[Reed Loden [:reed]]

bah, oops. Resolving fixed again.

Reporter: Please file a new bug for your Add/Remove Programs problems as this only deals with some registry entries and not the Add/Remove Programs stuff (as far I can tell).

Comment 15

[Reed Loden [:reed]]

(In reply to comment #14)
> Reporter: Please file a new bug for your Add/Remove Programs problems as this
> only deals with some registry entries and not the Add/Remove Programs stuff (as
> far I can tell).

After a further look and gavin's checking, this bug's patch does deal with the Add/Remove Programs stuff, but just a small part of it (just HKEY_CURRENT_USER).


(In reply to comment #12)
> This bug has not been fixed for the release candidates. I'm at Fx1.5rc2 but the
> Add/Remove entry in WinXP still says 1.4.1. I think this bug needs be reopened
> and fixed before the 1.5 release. The version and target milestone fields
> should be updated for the bug, too.

Reporter: How did you get to Firefox 1.5rc2? Did you get it via the update system, download it, or some other way? This will help to narrow down what has happened to you.