Registry keys under HKEY_CURRENT_USER incorrect after application update

RESOLVED FIXED in mozilla1.8rc1

Status

()

--
major
RESOLVED FIXED
13 years ago
10 years ago

People

(Reporter: darin.moz, Assigned: bugs)

Tracking

({fixed1.8})

unspecified
mozilla1.8rc1
x86
Windows XP
fixed1.8
Points:
---
Bug Flags:
blocking1.8rc1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

13 years ago
Registry keys under HKEY_CURRENT_USER incorrect after application update

nsPostUpdateWin.js only updates the keys under HKEY_LOCAL_MACHINE.  it needs to also update the same keys under HKEY_CURRENT_USER.

this should be an easy bug to fix since we can just run the same registry key update process twice.
(Reporter)

Updated

13 years ago
Status: NEW → ASSIGNED
Flags: blocking1.8rc1?
Target Milestone: --- → Firefox1.5rc1
(Reporter)

Comment 1

13 years ago
Created attachment 200555 [details] [diff] [review]
v1 patch - untested

This is probably what is needed, but I haven't had a chance to test this yet.

Comment 2

13 years ago
Darin, what are the negative effects of this bug?
(Reporter)

Comment 3

13 years ago
Asa: The registry is simply not up to date.  so, if the user started with FF 1.4, and upgraded to 1.5 using SU, the registry would still say that the user is using 1.4.  Since these keys exist for the purpose of allowing other applications to find FF, it may be important that this information is correct.  I don't really know of any cases where things would go wrong, but it is possible I guess.  The fix should be simple, so I think we should try to make it happen.  This bug shouldn't impact our uninstaller.

Updated

13 years ago
Flags: blocking1.8rc1? → blocking1.8rc1+

Comment 4

13 years ago
Ben - Darin is pretty loaded and this is rather bad - any chance you can take it?
Assignee: darin → beng
Status: ASSIGNED → NEW

Comment 5

13 years ago
Via triage meeting proxy Dave L asks, "With this patch on multi-user systems, do we also update all user registry entries or only the current user's?"
(Reporter)

Comment 6

13 years ago
> Via triage meeting proxy Dave L asks, "With this patch on multi-user systems,
> do we also update all user registry entries or only the current user's?"

We would only update the current user's.  I'm frankly not sure how the installer even deals with the multi-user case.  I suspect that it only touches the registry keys for the current user as well.
Created attachment 200674 [details] [diff] [review]
1.1 patch

This takes darin's existing patch and fixes a few errors:

1. need to invoke static properties on RegKey object using RegKey.prototype.foo, not RegKey.foo
2. make sure toString returns the string "HKEY_CURRENT_USER" for the HKCU key. 

r=ben for the original patch, requesting review from darin for these modifications.
Attachment #200555 - Attachment is obsolete: true
Attachment #200674 - Flags: superreview+
Attachment #200674 - Flags: review?(darin)
Assignee: beng → bugs
Ignore the change to nsUpdateService.js.in, that's part of another bug fix!
(Reporter)

Comment 9

13 years ago
Comment on attachment 200674 [details] [diff] [review]
1.1 patch

great, thanks!
Attachment #200674 - Flags: review?(darin) → review+
(Reporter)

Updated

13 years ago
Attachment #200674 - Flags: approval1.8rc1?
(Reporter)

Comment 10

13 years ago
fixed-on-trunk
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

13 years ago
Attachment #200674 - Flags: approval1.8rc1? → approval1.8rc1+
(Reporter)

Comment 11

13 years ago
fixed1.8
Keywords: fixed1.8

Comment 12

13 years ago
This bug has not been fixed for the release candidates. I'm at Fx1.5rc2 but the Add/Remove entry in WinXP still says 1.4.1. I think this bug needs be reopened and fixed before the 1.5 release. The version and target milestone fields should be updated for the bug, too.
Flags: blocking1.8.1?
Reopening as per comment 12's request.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
bah, oops. Resolving fixed again.

Reporter: Please file a new bug for your Add/Remove Programs problems as this only deals with some registry entries and not the Add/Remove Programs stuff (as far I can tell).
Status: REOPENED → RESOLVED
Last Resolved: 13 years ago13 years ago
Resolution: --- → FIXED
Flags: blocking1.8.1?
(In reply to comment #14)
> Reporter: Please file a new bug for your Add/Remove Programs problems as this
> only deals with some registry entries and not the Add/Remove Programs stuff (as
> far I can tell).

After a further look and gavin's checking, this bug's patch does deal with the Add/Remove Programs stuff, but just a small part of it (just HKEY_CURRENT_USER).


(In reply to comment #12)
> This bug has not been fixed for the release candidates. I'm at Fx1.5rc2 but the
> Add/Remove entry in WinXP still says 1.4.1. I think this bug needs be reopened
> and fixed before the 1.5 release. The version and target milestone fields
> should be updated for the bug, too.

Reporter: How did you get to Firefox 1.5rc2? Did you get it via the update system, download it, or some other way? This will help to narrow down what has happened to you.
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.