Closed Bug 312001 Opened 19 years ago Closed 19 years ago

Make sure auto-update works properly for Firefox 1.5

Categories

(Toolkit :: Application Update, defect)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla1.8final

People

(Reporter: darin.moz, Assigned: darin.moz)

References

Details

(Keywords: fixed1.8)

This bug is about ensuring that we have a correctly functioning auto update
system for Firefox 1.5.  This includes:

 * Ensuring that the right thing happens when we offer the user a minor update.
 * Ensuring that the right thing happens when we offer the user a major update.
 * Ensuring that the right thing happens when we offer the user both a minor 
   update and a major update.
 * Ensuring that the right thing happens when the user has extensions installed 
   that would be invalidated by an update.
 * Ensuring that silent download happens at a proper rate.
 * Ensuring that in the worst case, the user is at least aware of an available
   security update and can proceed to manually update.

There are probably other things to verify and test.  This bug is about ensuring
that we cover all these bases before shipping 1.5.
Status: NEW → ASSIGNED
Flags: blocking1.8rc1?
Target Milestone: --- → Firefox1.5
Flags: blocking1.8rc1? → blocking1.8rc1+
I've been watching since 1.5 beta 2 was announced and there has been no
indication of any update evailable for beta 1.  How long is auto-update
notification supposed to take, and when did the clock start for beta 2?
(In reply to comment #1)
> I've been watching since 1.5 beta 2 was announced and there has been no
> indication of any update evailable for beta 1.  How long is auto-update
> notification supposed to take, and when did the clock start for beta 2?

I had beta1 and it updated to beta2 a couple of days after automaticlly.
B.J.: Do you have any extensions installed?
Apparently, the default for FF 1.5 beta 1 is to suppress update notification UI
if the user has an extension that would be disabled by the minor update.  I
think that will end up causing a bunch of users to remain at beta 1.

I think we should always prompt the user when we encounter a critical security
update when we hit the condition of not being able to proceed without disabling
extensions.  I hate having to ask the user to choose between browser security
and extensions, but it seems to be our best option given where we are. 
Hopefully, extensions will all adopt "maxVersion=1.5.0.*" or
"maxVersion=1.5.0.999" to avoid this problem on the 1.5 release branch.
Not only do I agree with what Darin just said, I think that in the case of a
critical security update, we shouldn't ask them to choose at all. Let's just
install the critical security update. Why would we do anything different?
Asa: I think leaving the user out of the loop is bad when it causes them to lose
functionality, especially since we give them no way to backout of an update once
we start down the path of downloading and applying it.
Hrm. Am I odd for thinking that core browser security is more important than
third party extensions? If we had a critical vulnerability and the only way to
fix it was to break some extension, I'd hope that we wouldn't stop short of
doing anything we could to make users safe. Heck, I'd probably break a popular
_plugin_ if it was the only way to protect our users. 
Browser security is more important to me, but so is choice ;-)
Hello everyone,

I have a Firefox beta 1 installed on a Windows XP SP2 box at work. It does not
upgrade automatically. I've check : upgrade options are right. 

Only 2 extensions : adblock and Disable targets for downloads.
Language : English (the default one)

At home, on Mac OSX Tiger 10.4.1, no problem, the auto-update has worked well
(language french, many extensions).
Hi 

As others reported, Auto Update doesn't work for me. I've used the browser at
least one hour per day (usually much more). No extensions installed, except
Talkback and Reporter (came with default installer). When using "Check for
updates" it finds Beta 2, but Auto Update hasn't done anything yet. I'm using it
on Windows XP SP2 if this helps. Or is FF using the cache or something
controlled by the "Privacy" settings? I'm using quite restrictive settings here.
I will continue waiting till the end of this week, if it works I will tell. 

Thanks 
(In reply to comment #3)
> B.J.: Do you have any extensions installed?

My installed extensions are below.  InfoLister is newly added to allow this 
list to be generated.

When an extension blocks an update, does it matter if the extension is 
disabled?  Several extentions were disabled when I went to Beta 1, and those 
shouldn't block going to Beta 2.  (And nothing should stop me from getting 
notified about the update.)

I tried updating extensions to see if that would allow the automatic update to 
occur, but now I can't run Firefox at all.  (Instruction at 0x0059a8ef trying 
to read memory location 0.)  I'll reboot and see if that solves the problem, 
otherwise I'll be uninstalling and reinstalling Beta 2 by hand and won't be 
able to test auto-update.

Last updated: Wed, 19 Oct 2005 15:33:55 GMT
User Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) 
Gecko/20050908 

Firefox/1.4
Extensions (enabled: 7, disabled: 5):

    * Aardvark 1.0
    * Adblock 0.5.2.039
    * Google Toolbar for Firefox 1.0.20050803 (disabled)
    * Googlebar Lite 2.2 (disabled)
    * Greasemonkey 0.5.3 (disabled)
    * IE View 1.2.5
    * Image Zoom 0.1.7.1 (disabled)
    * InfoLister 0.9b
    * Linky 2.7.0
    * Reporter 1.8b4
    * Tab Mix 0.2 (disabled)
    * Tabbrowser Extensions 1.14.2005092201

Themes (1):

    * Firefox (default) 2.0

Plugins (9):

    * Adobe Acrobat
    * Java(TM) 2 Platform Standard Edition 5.0 Update 4
    * MetaStream 3 Plugin
    * Microsoft DRM
    * Mozilla Default Plug-in
    * Shockwave Flash
    * Shockwave for Director
    * Windows Media Player Plug-in Dynamic Link Library
    * eRoom
Can you give us the exact preferences that you have checked in regard to
software update? Thanks.

(In reply to comment #10)
> Hi 
> 
> As others reported, Auto Update doesn't work for me. I've used the browser at
> least one hour per day (usually much more). No extensions installed, except
> Talkback and Reporter (came with default installer). When using "Check for
> updates" it finds Beta 2, but Auto Update hasn't done anything yet. I'm using it
> on Windows XP SP2 if this helps. Or is FF using the cache or something
> controlled by the "Privacy" settings? I'm using quite restrictive settings here.
> I will continue waiting till the end of this week, if it works I will tell. 
> 
> Thanks 
(In reply to comment #12)
> Can you give us the exact preferences that you have checked in regard to
> software update? Thanks.
> (In reply to comment #10)

Could you specify what preference values you want to see and explain how to get 
the values?  I don't know about others, but I don't remember explicitly setting 
any preferences relating to update.
(In reply to comment #12)
> Can you give us the exact preferences that you have checked in regard to
> software update? Thanks.

Well, all three "Automatically check for ... " boxes are checked (Firefox,
Extensions, Search Engines). Also, FF is set to automatically download and
install the updates. Finally, the "Warn me if ... " box is checked. If you
wanted something different please let me know. 
Depends on: 313057
Thanks, that is what I need. I will set up a test machine in the QA area with a
profile that has no extensions and see if I can reproduce the problem

(In reply to comment #14)
> (In reply to comment #12)
> > Can you give us the exact preferences that you have checked in regard to
> > software update? Thanks.
> 
> Well, all three "Automatically check for ... " boxes are checked (Firefox,
> Extensions, Search Engines). Also, FF is set to automatically download and
> install the updates. Finally, the "Warn me if ... " box is checked. If you
> wanted something different please let me know. 

(In reply to comment #4)
> Apparently, the default for FF 1.5 beta 1 is to suppress update notification UI
> if the user has an extension that would be disabled by the minor update.  I
> think that will end up causing a bunch of users to remain at beta 1.
> 
> I think we should always prompt the user when we encounter a critical security
> update when we hit the condition of not being able to proceed without disabling
> extensions.  I hate having to ask the user to choose between browser security
> and extensions, but it seems to be our best option given where we are. 
> Hopefully, extensions will all adopt "maxVersion=1.5.0.*" or
> "maxVersion=1.5.0.999" to avoid this problem on the 1.5 release branch.


Would a quick (less than a day?) Beta 3 make sense to see that this works right
for Beta 2 users? Maybe for one day right before the RCfinal?
Darin: Regarding "Ensuring that silent download happens at a proper rate" - do
we know what the final target rate will be? I know you mentioned in the meeting
that it might change.
(In reply to comment #17)
> Darin: Regarding "Ensuring that silent download happens at a proper rate" - do
> we know what the final target rate will be? I know you mentioned in the meeting
> that it might change.

Marcia, I think the decision depends a lot on how the download rate may impact
dialup users.  We also have to factor in how long we want to wait before the
majority of our "active" users receive a complete auto-update.
On an office PC, my Beta 1 installation NEVER told me about Beta 2. I let it
have 5 days to find it before manually checking for and finding the update. Even
if I checked for updates, found the update, and clicked 'Later' the update icon
wouldn't be there.
Depends on: 311613
Depends on: 313521
Depends on: 313522
No longer depends on: 313057
Depends on: 313623
Given that all of the bugs listed as dependencies here have been fixed, I'm going to mark this bug fixed as well.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Keywords: fixed1.8
I don't think this should be marked "Fixed".  I ran Beta 2 all day yesterday at work and no automatic update happened.  There are also many reports of problems in the comments for http://mozillazine.org/talkback.html?article=7631 .

I checked options/advanced/update: 
automatically download is set
warn if disable is set

My configuration from InfoLister:

Last updated: Wed, 02 Nov 2005 15:47:52 GMT 
User Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b5) 
Gecko/20051006 Firefox/1.4.1 

Extensions (enabled: 9, disabled: 3):
Aardvark 1.0 
Adblock 0.5.2.039 
Google Toolbar for Firefox 1.0.20051012 
Googlebar Lite 3.0.1 
Greasemonkey 0.5.3 (disabled)
IE View 1.2.6 
Image Zoom 0.1.7.1 (disabled)
InfoLister 0.9b 
Linky 2.7.0 
Reporter 1.8b5 
Tab Mix Plus 0.2.5.1 
Tabbrowser Extensions 1.14.2005092501 (disabled)

Themes (1):
Firefox (default) 2.0

Plugins (9):
Adobe Acrobat
Java(TM) 2 Platform Standard Edition 5.0 Update 4
MetaStream 3 Plugin
Microsoft DRM
Mozilla Default Plug-in
Shockwave Flash
Shockwave for Director
Windows Media Player Plug-in Dynamic Link Library
eRoom
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.