313522 - Auto-update did not happen for many beta1 users (and won't for beta2)

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Darin Fisher]

Auto-update did not happen for many beta1 users

Some beta1 instances were not auto-updated to beta2.  It seems that this had something to do with extensions that would be invalidated by beta2.  We need
to resolve this problem for FF1.5 final.

Comment 1

[Asa Dotzler [:asa]]

Is this the bug where we didn't offer update UI if we saw that extensions were incompatible? If so, isn't that fixed?

Comment 2

[Darin Fisher]

Yes, that's the bug I'm thinking of.  I don't recall it being fixed... can you point me at the bug?

Comment 3

[Daniel C]

Auto-update notification from b1 to b2 never occurred for me. I had to manually check for updates and then update (fine if you know there's an update, not good otherwise...). I left it for 5 days after it was announced that the update process was switched on before giving up on waiting.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Daniel, automatic update was broken in 1.5b1 but fixed just before 1.5b2 (bug 309784), so your experience is what I would have expected.

Darin, do you have any pointers on how to duplicate this extension problem?

Comment 5

[Asa Dotzler [:asa]]

The bug I remember hearing about (and can't find in bugzilla, so it may not exist) was that when a user had extensions that would be disabled by the update, we didn't show the user any update UI and we didn't perform the update download.

Comment 6

[Darin Fisher]

Asa: right, AFAIK that's this bug and it isn't fixed.

Comment 7

[Asa Dotzler [:asa]]

OK. I'll try to get us a clear set of steps to reproduce. This is definitely something we need to fix. 

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

The code in this function uses the extension manager before the em service is actually retrieved! Reorder this function so that the Listener is not created until after. A big duh. 

This was affecting users with incompatibilities because this function is only called when there are incompatibilities, meaning no update prompt was being shown. When I applied this to my install of 1.5B1, it began showing the update prompt again asking me to upgrade to 1.4.1.

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

The reason this is so unpredictable is:

Assume an extension, e.g. Google Toolbar with maxVersion = 1.4 is installed.

If the update timer fires, Toolbar will be discovered to be incompatible and an version-info update check performed on that extension to see if there's a newer compatible version available. That code is buggy and throws an exception, halting the entire prompting process. 

If the update timer for the Toolbar extension itself fires before the app update timer fires, it will update its maxVersion to 1.4.1 and by the time the app update timer fires all will be right with the world. 

Comment 10

[Darin Fisher]

Comment on attachment 200629 [details] [diff] [review]
patch

r=darin

Comment 11

[Mike Schroepfer]

Thanks for the quick work on this - is this ready to land?  Should we land on branch/trunk at same time?  

Comment 12

[Darin Fisher]

fixed-on-trunk

Comment 13

[Darin Fisher]

fixed1.8

Comment 14

[Daniel Veditz [:dveditz]]

We may want to relnote this. It's fixed *now* but not in the beta versions people have. Might head off some number of duplicate bug filings.

Comment 15

[Jay Patel [:jay]]

Is downloading the latest release and installing it over Beta1 the only real workaround here for Beta1 users?  Just want to be clear on that before we relnote it.