314055 - Incorrect layout on footer bar - words overlap

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Chris Andrichak]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en) AppleWebKit/412.7 (KHTML, like Gecko) Safari/412.5
Build Identifier: Safari Version 2.0.1 (412.5)

With the upgrade to, the footer bar at the bottom of every show bug page overlaps the label at the bottom left and the links to the right of it. Specifically, "My Bugs" gets drawn on top of "Saved Searches:", usually just over the colon. It stays the same whether or not I shrink or enlarge the text.

Reproducible: Always

Comment 1

[Chris Andrichak]

(upgrade to v2.20)

Comment 2

[Frédéric Buclin]

Probably the old CSS for 2.18 is kept in the cache of your browser. Try clearing your cache and reloading the page. This should fix the UI problem.

Comment 3

[Colin Ogilvie [:cso]]

Confirming with:

Mozilla/5.0 (compatible; Konqueror/3.4; Linux 2.6.10-5-386; X11; i686; en_US) KHTML/3.4.2 (like Gecko) (Debian package 4:3.4.2-0ubuntu0hoary2)-0

Also occuring on local test installs and Landfill.

Comment 4

[Colin Ogilvie [:cso]]

Attachment: Patch v1

Increase size of the label div to be 8.2em. This fixes it on my version of Konqueror, where this problem also appears. Not sure about Safari as I don't have a Mac.

Comment 5

[Colin Ogilvie [:cso]]

Attachment: Before and After

Image showing before and after this patch...

After is above
Before is below

Comment 6

[Colin Ogilvie [:cso]]

Attachment: Patch v2

Highlight an issue justdave pointed out in Safari with lots of Saved Searches. This fixes it for Konqueror, but leaves it broken in IE. It seems IE doesn't support "display: table-cell;" - I can't see any adverse effects from my limited testing.

Comment 7

[Chris Andrichak]

Tried out the patch changes on a local copy on safari/Mac OSX - word spacing is correct now as in image.

Comment 8

[Vlad Dascalu]

Comment on attachment 202914 [details] [diff] [review]
Patch v2

The 8.2em part is correct and fixes the footer for me in Internet Explorer.

I full agree with the second part (moving table-cell display in the general CSS declaration). We shouldn't hide CSS2-compliant declarations in quirks made specifically for IE.

The:

-        display: block;

statement is correctly removed by your patch, since it's incorrect; it should be table-cell per standards in the first place.

I've also tested the second part and leaves IE unchanged (with the first part already applied - which fixed the footer). If this fixes Konqueror (and maybe other less-than-popular browsers) - cool!

Comment 9

[Vlad Dascalu]

full -> fully
and leaves -> and it leaves (in the previous comment)

Comment 10

[Vlad Dascalu]

Since it fixes Konqueror, setting OS/Hardware to All/All.

Comment 11

[Marc Schumann [:Wurblzap]]

See also bug 321556. Your comments are welcome :)

Comment 12

[Vlad Dascalu]

Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.17; previous revision: 1.16
done

Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.16.2.1; previous revision: 1.16
done

Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.12.4.2; previous revision: 1.12.4.1
done