314241 - "report broken web site" toolbar button is broken when using "small icons"

Status: RESOLVED FIXED

(Other Applications Graveyard :: Reporter, defect, P1)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051028 Firefox/1.5 ID:2005102804

repro:
1.open FF
2.rightclick -> customize on the menubar and drag the "spider"-icon on a toolbar.(preferably in between some other buttons)
3.click done
4.open a blank tab

result:
the image is half-hidden (half the width of the button is gone)

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Gah, I fixed the large button in bug 294673 but not the small button. This only occurs with the "small icons" disabled, right?

Comment 2

[Peter van der Woude [:Peter6]]

(In reply to comment #1)
> Gah, I fixed the large button in bug 294673 but not the small button. This only
> occurs with the "small icons" disabled, right?
> 
Yes

Comment 3

[Shayne Jewers]

*** Bug 314243 has been marked as a duplicate of this bug. ***

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This should do it, if someone else can confirm that'd be great.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Also, testing all other states (active, hover, disabled) with small/large icons would be good, in case any other style rules are wrong.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

If there's going to be an RC2, I think this should be in it. It's a simple, isolated, style-only fix to a new feature.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

(the comma stuff is just a conformance fix, it has no effect, and I missed some in that patch, so just ignore that)

Comment 8

[Shayne Jewers]

(In reply to comment #5)
> Also, testing all other states (active, hover, disabled) with small/large icons
> would be good, in case any other style rules are wrong.
> 

seems to me, its off-center on large on all states (at least on hover, the button part thingy has a gap in the left, and it's hugging the sight side)

Comment 9

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #8)
> seems to me, its off-center on large on all states (at least on hover, the
> button part thingy has a gap in the left, and it's hugging the sight side)

Yeah, the image itself is right-aligned in it's "frame", so that can't really be fixed without changing the image.

Comment 10

[Peter van der Woude [:Peter6]]

this patch fixes the issue reported

tested
-small/large icon and w/ and w/o text
-hover: state(s)

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 201185 [details] [diff] [review]
patch

oy.  This is a safe ridealong for an RC2, can be tested on trunk ASAP.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

checked in on the trunk

Comment 13

[Asa Dotzler [:asa]]

moving out to the 1.8 rc2 ride-along candidate list. We'll consider taking this if we do an RC2.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

1.8 Branch:
mozilla/extensions/reporter/resources/skin/classic/reporter/browserOverlay.css;
new revision: 1.1.12.2;

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 314750 has been marked as a duplicate of this bug. ***