Closed
Bug 314306
Opened 19 years ago
Closed 19 years ago
[patch] Can't quit MODI / something's eating Esc in the content area
Categories
(Camino Graveyard :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.5
People
(Reporter: alqahira, Assigned: sfraser_bugs)
References
()
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
2.57 KB,
patch
|
mark
:
review+
mark
:
superreview+
|
Details | Diff | Splinter Review |
When using the Mouseover Document Inspector bookmarklet (above; homepage: http://slayeroffice.com/tools/modi/v2.0/modi_help.html), Esc is supposed to cancel the bookmarklet and make it go away (and does, in Fx).
In Camino, Esc does not cancel MODI. I suspect something is eating Esc (the other shortcut keys, like p for Pause, do work); bug 310989 seems to indicate Esc gets grabbed somewhere.
Camino 2005102704 (v1.0a1+)
Comment 2•19 years ago
|
||
Esc stops page load. I think that we should only be trapping Esc for this when the page actually is loading, though.
Assignee | ||
Comment 3•19 years ago
|
||
Taking.
Assignee: mikepinkerton → sfraser_bugs
Severity: minor → normal
Flags: camino1.0? → camino1.0+
Priority: -- → P3
Target Milestone: --- → Camino1.0
Assignee | ||
Comment 4•19 years ago
|
||
The whole -sendEvent thing was a bad idea. The correct way to do this is to implement the NSResponder method -cancel:, which is called when you hit the escape key. That way, we can implement it at the appropriate place in the responder chain.
Attachment #204995 -
Flags: review?(mark)
Comment 5•19 years ago
|
||
*** Bug 319161 has been marked as a duplicate of this bug. ***
Comment 6•19 years ago
|
||
Comment on attachment 204995 [details] [diff] [review]
Patch
Nice. That bookmarklet is really cool.
Why cancel: and not cancelOperation:?
Assignee | ||
Comment 7•19 years ago
|
||
I used cancel because that's what I saw doComamndBySelector: getting called for down in ChildView. If we implement cancelOperation:, I'm not sure that gecko's gonna get first crack at it.
Comment 8•19 years ago
|
||
Comment on attachment 204995 [details] [diff] [review]
Patch
Both cancel: and cancelOperation: seemed to do the trick for me, I was just curious about your choice of one over the other. r=me.
Attachment #204995 -
Flags: review?(mark) → review+
Assignee | ||
Comment 9•19 years ago
|
||
Unfortunately we have to have a solution that doesn't break 10.2 (like keeping the old sendEvent: hack).
Status: NEW → ASSIGNED
Reporter | ||
Comment 10•19 years ago
|
||
Is bug 289432 related to this (i.e., to our trapping of certain keystrokes at impropper occasions?)
Comment 11•19 years ago
|
||
I think that's just because we're not catching it in the sheet, but we're catching it for the "Stop Loading Page" menu item.
Comment 12•19 years ago
|
||
Tangentially related: bug 164863, which describes a situation where cmd gets eaten too. (For example, cmd-return won't open a text-selected link at all, let alone in a new tab or window. Return with the link selected works as expected.)
cl
Reporter | ||
Comment 13•19 years ago
|
||
Simon, should we move this to 1.1/Mozilla 1.8.1 (when we won't have to make it work for 10.2)?
Assignee | ||
Comment 14•19 years ago
|
||
Yeah I guess.
Flags: camino1.0+ → camino1.0-
Target Milestone: Camino1.0 → Camino1.1
Reporter | ||
Updated•19 years ago
|
Blocks: 311840
Summary: Can't quit MODI / something's eating Esc in the content area → [patch] Can't quit MODI / something's eating Esc in the content area
Reporter | ||
Comment 15•19 years ago
|
||
Comment on attachment 204995 [details] [diff] [review]
Patch
This still applies, but it has to guess some offsets now. It'd be nice to get it in soon ;)
Comment 16•19 years ago
|
||
Comment on attachment 204995 [details] [diff] [review]
Patch
10.2-dropping OK for 1.1.
Attachment #204995 -
Flags: superreview+
Comment 17•19 years ago
|
||
Checked in on trunk and 1.8 branch for smfr.
Comment 18•19 years ago
|
||
*** Bug 339811 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•