314494 - Firefox 1.5 and Thunderbird 1.5 NL are ready for review

Status: RESOLVED FIXED

(Mozilla Localizations :: nl / Dutch, defect)

Description

[Tim Maks van den Broek [:mad_maks]]

The NL branch is frozen and ready for review.

Comment 1

[Axel Hecht [:Pike]]

I didn't do a full review, but nl didn't catch the update to eBay.src to update
from eBay.src instead of ebay.src, see attachement 201357 in bug 306576.

Comment 2

[Axel Hecht [:Pike]]

(In reply to comment #1)
> I didn't do a full review, but nl didn't catch the update to eBay.src to update
> from eBay.src instead of ebay.src, see attachement 201357 in bug 306576.
> 

Oops, sorry, note to self, update your tree before making comments.

Comment 3

[Tim Maks van den Broek [:mad_maks]]

Bug 307455: 'Help Contents' menuitem is labeled 'Firefox Help' on OS X; fix the toc this time.

i have fixed this also on the nl branch

Comment 4

[Gert-Paul van der Beek]

The new bookmarkfile, posted at bug 310625, has been checked in into nl, including the comments Pike posted in n.p.m.l10n.

Comment 5

[Gert-Paul van der Beek]

Attachment: spellingerror

Due to the last nl checkings of yesterday, a spelling error sneeking into the tree. This patch solves the issue.

This is a low risk patch and the spellingerror can be easily noticed.

Comment 6

[Gert-Paul van der Beek]

Comment on attachment 202353 [details] [diff] [review]
spellingerror

Checked in

Comment 7

[Axel Hecht [:Pike]]

Attachment: move the src over, binaries don't make it in th patch

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 202658 [details] [diff] [review]
move the src over, binaries don't make it in th patch

Index: list.txt
===================================================================
RCS file: /l10n/l10n/nl/browser/searchplugins/list.txt,v
retrieving revision 1.1.2.5
diff -u -r1.1.2.5 list.txt
--- list.txt    27 Oct 2005 15:15:03 -0000      1.1.2.5
+++ list.txt    11 Nov 2005 12:52:23 -0000
@@ -1,6 +1,6 @@
 google-nl
 bolcom-nl
 eBay-nl
-vandale
+vandale-nl
 wikipedia-nl
-yahoo-nl
\ No newline at end of file
+yahoo-nl

done locally, sorry.

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 202658 [details] [diff] [review]
move the src over, binaries don't make it in th patch

checked in on the branch, please fix it on the trunk, too.

Comment 10

[Tim Maks van den Broek [:mad_maks]]

I have updated the nl start-snippets.

Comment 11

[Gert-Paul van der Beek]

Attachment: Fix for accesskey, mac osx fixes and help.

With the upgrade to FF 1.RC2, I noticed we used the wrong accesskey for some updatemenuitems in menu Help. This patch fixes that, together with fixes for windowswidth at mac.
Also a fix for mimeheader.properties. We did you a space for one label, and en-US for none of the labels. Since other labels also used - for spaces, I seems to be better to use a - for this too. Don't know how critical this it, but without space it seems safer.

Comment 12

[Gert-Paul van der Beek]

Comment on attachment 203121 [details] [diff] [review]
Fix for accesskey, mac osx fixes and help.

Checked in