Closed Bug 315001 Opened 15 years ago Closed 15 years ago

F8 works when it should not: account page displayed

Categories

(SeaMonkey :: MailNews: Message Display, defect)

defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED
seamonkey2.0a1

People

(Reporter: sgautherie, Assigned: neil)

References

Details

(Keywords: fixed-seamonkey1.0, fixed-seamonkey1.1a, regression, Whiteboard: [Regressed before 20041228])

Attachments

(1 file, 1 obsolete file)

From bug 314301 comment 7, after further testing:

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.12) Gecko/20050915] (release) (W98SE)

Works as expected: F8 "disabled" is that specific case.

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b4) Gecko/20050910 SeaMonkey/1.0a] (release) (W98SE)
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20051103 SeaMonkey/1.1a] (nightly) (W98SE)

Trunk _and SM v1.0 branch_ affected.
Whiteboard: [Regressed before 20050910] [SG: Would want to block SMv1.0_final]
1) Select any top level item in the list, one that displays
{{
SeaMonkey Mail - <your_account_name>
Email
...
Accounts
...
Advanced Features
...
}}
2) Press F8 (may be twice at first)
2r) The message pane appears, and the right page can then be scrolled inside
the thread pane :-(
Whiteboard: [Regressed before 20050910] [SG: Would want to block SMv1.0_final] → [Regressed before 20050910] [SeGA: Would want to block SMv1.0_final]
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a6) Gecko/20041228] (nightly) (W98SE)

I tried but gave up finding older Windows builds on <http://archive.mozilla.org/pub/mozilla/nightly/>.
Whiteboard: [Regressed before 20050910] [SeGA: Would want to block SMv1.0_final] → [Regressed before 20041228] [SeGA: Would want to block SMv1.0_final]
Attached patch Proposed patch (obsolete) — Splinter Review
Assignee: mail → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #202048 - Flags: review?(mnyromyr)
Attached patch Fixed patchSplinter Review
Oops, .disabled doesn't work on nodes without XBL :-[
Attachment #202048 - Attachment is obsolete: true
Attachment #202072 - Flags: review?(mnyromyr)
Attachment #202048 - Flags: review?(mnyromyr)
Comment on attachment 202072 [details] [diff] [review]
Fixed patch

>Index: mailWindow.js
>===================================================================
>+        document.getElementById("menu_showMessagePane").setAttribute("disabled", "true");
...
>+        document.getElementById("menu_showMessagePane").removeAtribute("disabled");

http://lxr.mozilla.org/mozilla/source/mailnews/base/resources/content/mailWindowOverlay.js#167 already does this every time the menu pops up, no need to do it here also.

r=me with that.
Attachment #202072 - Flags: review?(mnyromyr) → review+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
(In reply to comment #5)
> http://lxr.mozilla.org/mozilla/source/mailnews/base/resources/content/mailWindowOverlay.js#167
> already does this every time the menu pops up, no need to do it here also.

(Mnyromyr, I'm not sure what was meant, but the patch was checked in as is...)

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20051124 SeaMonkey/1.5a] (nightly) (W98SE)

V.Fixed.

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20051120 SeaMonkey/1.0b] (release) (W98SE)

Neil, could you submit this patch for SMv1.0b ?
Status: RESOLVED → VERIFIED
OS: Windows 98 → All
Hardware: PC → All
Target Milestone: --- → seamonkey1.5alpha
(In reply to comment #8)
> No, only the lines needed got in, see

My mistake. ("key_toggleMessagePane" was checked in, "menu_showMessagePane" was skipped.)
(In reply to comment #7)
> Neil, could you submit this patch for SMv1.0b ?

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20051216 SeaMonkey/1.0b] (nightly) (W98SE)

(Branch fix still wanted.)
Comment on attachment 202072 [details] [diff] [review]
Fixed patch

My list of sm1.0 requests was out of date, I'd better check for other patches I overlooked so that they can at least make final.
Attachment #202072 - Flags: approval-seamonkey1.0?
Comment on attachment 202072 [details] [diff] [review]
Fixed patch

a=me, just need a second one now, unless you count as one.
Attachment #202072 - Flags: approval-seamonkey1.1+
Attachment #202072 - Flags: approval-seamonkey1.0?
Attachment #202072 - Flags: approval-seamonkey1.0+
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.0.1) Gecko/20060130 SeaMonkey/1.0] (release) (W98SE)

V.Fixed, on SMv1.0 branch too.

Checkins were:
Gv1.9a / SMv1.5a: 1.102
Gv1.8 / SMv1.1a: 1.100.2.2
Gv1.8.0 / SMv1.0: 1.100.2.1.4.1
Whiteboard: [Regressed before 20041228] [SeGA: Would want to block SMv1.0_final] → [Regressed before 20041228]
Target Milestone: seamonkey1.5alpha → seamonkey1.1alpha
Serge, would you please leave the "Target Milstone" fields alone? Those are for the assignee's planning only!
Target Milestone: seamonkey1.1alpha → seamonkey1.5alpha
Blocks: 330198
You need to log in before you can comment on or make changes to this bug.