315001 - F8 works when it should not: account page displayed

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Serge Gautherie (:sgautherie)]

From bug 314301 comment 7, after further testing:

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.12) Gecko/20050915] (release) (W98SE)

Works as expected: F8 "disabled" is that specific case.

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b4) Gecko/20050910 SeaMonkey/1.0a] (release) (W98SE)
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20051103 SeaMonkey/1.1a] (nightly) (W98SE)

Trunk _and SM v1.0 branch_ affected.

Comment 1

[Serge Gautherie (:sgautherie)]

1) Select any top level item in the list, one that displays
{{
SeaMonkey Mail - <your_account_name>
Email
...
Accounts
...
Advanced Features
...
}}
2) Press F8 (may be twice at first)
2r) The message pane appears, and the right page can then be scrolled inside
the thread pane :-(

Comment 2

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a6) Gecko/20041228] (nightly) (W98SE)

I tried but gave up finding older Windows builds on <http://archive.mozilla.org/pub/mozilla/nightly/>.

Comment 3

[[e-mail]]

Attachment: Proposed patch

Comment 4

[[e-mail]]

Attachment: Fixed patch

Oops, .disabled doesn't work on nodes without XBL :-[

Comment 5

[Karsten Düsterloh]

Comment on attachment 202072 [details] [diff] [review]
Fixed patch

>Index: mailWindow.js
>===================================================================
>+        document.getElementById("menu_showMessagePane").setAttribute("disabled", "true");
...
>+        document.getElementById("menu_showMessagePane").removeAtribute("disabled");

http://lxr.mozilla.org/mozilla/source/mailnews/base/resources/content/mailWindowOverlay.js#167 already does this every time the menu pops up, no need to do it here also.

r=me with that.

Comment 6

[[e-mail]]

Fix checked in.

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)
> http://lxr.mozilla.org/mozilla/source/mailnews/base/resources/content/mailWindowOverlay.js#167
> already does this every time the menu pops up, no need to do it here also.

(Mnyromyr, I'm not sure what was meant, but the patch was checked in as is...)

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20051124 SeaMonkey/1.5a] (nightly) (W98SE)

V.Fixed.

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20051120 SeaMonkey/1.0b] (release) (W98SE)

Neil, could you submit this patch for SMv1.0b ?

Comment 8

[Karsten Düsterloh]

> (Mnyromyr, I'm not sure what was meant, but the patch was checked in as is...)

No, only the lines needed got in, see <http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=mailWindow.js&branch=&root=/cvsroot&subdir=mozilla/mailnews/base/resources/content&command=DIFF_FRAMESET&rev1=1.101&rev2=1.102>

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #8)
> No, only the lines needed got in, see

My mistake. ("key_toggleMessagePane" was checked in, "menu_showMessagePane" was skipped.)

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to comment #7)
> Neil, could you submit this patch for SMv1.0b ?

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20051216 SeaMonkey/1.0b] (nightly) (W98SE)

(Branch fix still wanted.)

Comment 11

[[e-mail]]

Comment on attachment 202072 [details] [diff] [review]
Fixed patch

My list of sm1.0 requests was out of date, I'd better check for other patches I overlooked so that they can at least make final.

Comment 12

[Ian Neal]

Comment on attachment 202072 [details] [diff] [review]
Fixed patch

a=me, just need a second one now, unless you count as one.

Comment 13

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.0.1) Gecko/20060130 SeaMonkey/1.0] (release) (W98SE)

V.Fixed, on SMv1.0 branch too.

Checkins were:
Gv1.9a / SMv1.5a: 1.102
Gv1.8 / SMv1.1a: 1.100.2.2
Gv1.8.0 / SMv1.0: 1.100.2.1.4.1

Comment 14

[Robert Kaiser]

Serge, would you please leave the "Target Milstone" fields alone? Those are for the assignee's planning only!