315167 - Purple Tab Arrow Flashes if Cursor is put on it and may reload tab instead of being moved

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Brett W.]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051104 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051104 Firefox/1.6a1

If I go to move a tab and place my cursor over the little purple arrow which now appears to show where the tab will be moved, the purple arrow flashes until the cursor is moved away from the arrow. Not sure if this is a bug or just a little strange looking.

Reproducible: Always

Steps to Reproduce:
1.Click to drag tab to new location
2.place cursor over purple arrow in between tabs
3.It continuously flashes

Actual Results:  
Purple arrow flashed continuously until cursor moved

Expected Results:  
Solid purple arrow?

Comment 1

[Brett W.]

*** Bug 315168 has been marked as a duplicate of this bug. ***

Comment 2

[zug_treno]

Reproducible with Firefox 1.5b2 and 1.5rc1, sometimes the purple arrow disappears after flashing a few times.

Comment 3

[MechCommanderRei]

There's more; If you try dropping the tab while the arrow is flashing, the tab sometimes reloads instead of being moved.  The problem is more noticeable if a theme's "tab drop position" image is large, like in Charamel.  Someone might want to update the bug summary...

Comment 4

[Håkan Waara]

See also bug 333791, which is about the arrow flashing when you're dragging over the favicon.

These two bugs seem very related; our tab drag&drop behavior needs some work it seems.

Comment 5

[Wayne Woods]

Interesting... On Mac OS X, if I try to hover the mouse cursor over the indicator arrow while dragging, then it just vanishes. It doesn't continually flash like you report for Windows. I can really only hover over the tip of the arrow (the bit that extends into the tab bar) anyway... the tail of the arrow is in the bookmarks toolbar and the indicator always disappears if I move the mouse into that region.

In bug 333791, the arrow doesn't really flash, either. At least not continuously. It'll flicker once in Win XP, or disappear entirely in OS X.

Comment 6

[jag (Peter Annema)]

See bug 319244 for the SeaMonkey patches that address this.

Comment 7

[Mike Connor [:mconnor]]

load-balancing tabbrowser stuff to sspitzer

Comment 8

[Mike Connor [:mconnor]]

gah.  s/.org/.com/!

Comment 9

[jag (Peter Annema)]

The simple fix for this particular bug will be (or should be) to add mousethrough like I did recently for suite (see attachment 219589 [details] [diff] [review]).

Comment 10

[(not reading, please use [e-mail] instead)]

jag: thanks for the info about mousethrough.

Comment 11

[(not reading, please use [e-mail] instead)]

I've got a patch (using mousethrough="always", thanks again jag) that works on the trunk, but it doesn't work on the 1.8 branch (for firefox 2.0)

from https://bugzilla.mozilla.org/show_bug.cgi?id=319244#c48

>>Now that it's fixed on Trunk, what's the plan to fix it on the branch(es) ?
>The trunk fix relies on other trunk fixes. There's no equivalent branch fix.

This was for bug #319244 ("Tab drop indicator icon flickers" for the suite), but the same appears to be true for firefox.

I'll attach my trunk patch anyways.

Comment 12

[(not reading, please use [e-mail] instead)]

Attachment: trunk patch for this issue, no solution for the 1.8 branch yet.

Comment 13

[(not reading, please use [e-mail] instead)]

I asked jag why this fix would be trunk only, for both FF and the suite, and he told me:  

"I think it was Neil who said that, and he implied it was a change roc made to the way mousethrough was handled. Bug 317375 perhaps?"

Comment 14

[[e-mail]]

(In reply to comment #13)
>Bug 317375 perhaps?
Yes.

Comment 15

[(not reading, please use [e-mail] instead)]

Comment on attachment 223508 [details] [diff] [review]
trunk patch for this issue, no solution for the 1.8 branch yet.

seeking review for this small patch (based on jag's work) for the trunk.

Comment 16

[(not reading, please use [e-mail] instead)]

fix landed on the trunk, r=mconnor

Comment 17

[Mike Connor [:mconnor]]

pushing out non-critical-path bugs to b2

Comment 18

[Mike Connor [:mconnor]]

Not going to block on this since there isn't a solution in sight at present.

Comment 19

[(not reading, please use [e-mail] instead)]

sorry for the bug spam, re-assigning bugs back to default owner if I'm not working actively on them.

Comment 20

[Jared Wein [:jaws] (please needinfo? me)]

This bug no longer applies since the new tab dragging landed in bug 783282.

Comment 21

[Dão Gottwald [:dao]]

(In reply to Jared Wein [:jaws] from comment #20)
> This bug no longer applies since the new tab dragging landed in bug 783282.

We still display the arrow for dropping links.

However, this bug should have been resolved when the fix landed on trunk.