315434 - Security error with remote <xul:tabbox>: can't switch tabs if chrome has focus

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P2)

Description

[Blake Kaplan (:mrbkap) (inactive)]

STEPS TO REPRODUCE:
0. Make sure the browser's tab bar is visible.
1. Load the testcase in the URL.
2. Focus a tab in the content.
3. Click on the active browser tab (the one with the testcase loaded), this should give you a focus rectangle around it.
4. Click on a non-selected tab in the content area.

ACTUAL RESULTS: The new tab is not selected; a security error appears in the JS console.
EXPECTED RESULTS: The new tab is selected.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Use try/catch

In the case that focusedElement would throw, our tab would not be selected.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Sadly, this missed Firefox 1.5. Hoping this can hit 1.8.1, though.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

*** Bug 317356 has been marked as a duplicate of this bug. ***

Comment 5

[:Gavin Sharp [email: [e-mail]]]

*** Bug 317434 has been marked as a duplicate of this bug. ***

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Making note of the error so that this bug is easier to find:
Error: uncaught exception: [Exception... "Security error"  code: "1000" nsresult: "0x805303e8 (NS_ERROR_DOM_SECURITY_ERR)"  location: "chrome://global/content/bindings/tabbox.xml Line: 344"]

Comment 7

[:Gavin Sharp [email: [e-mail]]]

*** Bug 320427 has been marked as a duplicate of this bug. ***

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

*** Bug 319309 has been marked as a duplicate of this bug. ***

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 202132 [details] [diff] [review]
Use try/catch

This is a low-risk fix (only affects remote XUL) that fixes bugs in remote XUL that is impossible to work around on the content side.

Comment 10

[Daniel Veditz [:dveditz]]

Comment on attachment 202132 [details] [diff] [review]
Use try/catch

a=dveditz for drivers

Comment 11

[Benjamin Smedberg]

Blake, can you get this checked in?

Comment 12

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into the branches.

Comment 13

[Marcia Knous [:marcia]]

Verified fixed on the branch using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1. Following Blake's excellent STR, I do not see a security error in the JS console and the tab is correctly selected.