315540 - Multiple downloads trigger when update is clicked again and the download is reset

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Muzakkir]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051025 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051025 Firefox/1.5

When there is a theme or extension is being updated if we click on the find updates it adds even these files to download resulting in double triple file downloads and the current download file is reset to start

Reproducible: Always

Steps to Reproduce:
1.Click on the update button to update to the newer version. when it is being downloaded click on the find updates
2.When the updates found window displays the list of downloads click Install now


Actual Results:  
It starts downloading the files that are listed.
The download is reset and duplicate are continued (If there are 2 downloads and we do this for 2 times it is downloading 6 files 4 from the two times we clicked and 2 from the original start)
We tried to close the application with the downloadd pending it says 6 files are downloading. when we did it for 2 only
When i dont want to close the application we need to click on the dont exit button many times

Expected Results:  
It should not reset the download of the theme or extension, even if the user clicks on the install multiple times it should take it as one download only

Check the attached screen shots

Comment 1

[Muzakkir]

Attachment: Screen Shot showing there are multiple downloads

Comment 2

[Muzakkir]

Attachment: Screen Shot showing there are multiple downloads

Comment 3

[Robert Strong (they/them - no direct email)]

Note: we should probably just remove the button immediately to fix this bug

Comment 4

[Robert Strong (they/them - no direct email)]

Fixed on trunk by the checkin of bug 329045. We now change the view on install to an installation view and remove the availableUpdate rdf properties which signify the item has an update to install which should prevent this from happening though I suspect if someone were to try real hard they could do this.

Comment 5

[Robert Strong (they/them - no direct email)]

*** Bug 338894 has been marked as a duplicate of this bug. ***