315726 - [BeOS]Avoid mistargeted (focus) messages

Status: RESOLVED FIXED

(Core Graveyard :: Widget: BeOS, defect)

Description

[Sergei Dolgov]

there is quite frequent case especially in destroy process for focus and draw(but not only),
that message sent from BView reaches widget with missing mView (or maybe even different mView??).

While for drawing it may cause minor issues only, for focus events it is more than important - as most of those messages are related to create/destroy process.

In this case we must rather drop those messages than dispatch it to mozilla.

Also i think there is reasonable to send GOTFOCUS message directly from nsWindow::SetFocus, while LOSTFOCUS may remain in CallMethod, but with added target check.

Comment 1

[Sergei Dolgov]

Attachment: patch

works definitely  better with search box and when creating new tabs.

review request

Comment 2

[tqh]

Comment on attachment 202538 [details] [diff] [review]
patch

r=[e-mail]

Comment 3

[Sergei Dolgov]

Laned in trunk
Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.110; previous revision: 1.109
done 

Closing

Comment 4

[Niels Reedijk]

Attachment: Patch for 1_8 branch

This is the patch for the MOZILLA_1_8_BRANCH.

Sergei, I get the following warning:
/boot/home/firefox-devel/mozilla/widget/src/beos/nsWindow.cpp: In method `void nsViewBeOS::MakeFocus(bool)':
/boot/home/firefox-devel/mozilla/widget/src/beos/nsWindow.cpp:3281: warning: left-hand operand of comma expression has no effect

The line in question is:
			if (nsnull != (info = new MethodInfo(w, w, nsWindow::KILL_FOCUS),1,args))

I'm not sure what you're trying to do, but is it safe to ignore the warning. Also, inside the first #ifdef DEBUG_FOCUS block there is a printf line which ends with */ (without a starting one). 

It builds though.

Comment 5

[Sergei Dolgov]

I think this warning (and bit flawed logic) was fixed later in some bug.
Look at current trunk source code to see how this place in discussion should look alike. I think it is safe to fix it now and here than later.

Comment 6

[Niels Reedijk]

Attachment: Patch for 1_8 branch (2)

This patch includes the fix to bug 326687. Requesting permission to land in the MOZILLA_1_8_BRANCH.

This is a BeOS-only change and will not affect any other platform.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 231935 [details] [diff] [review]
Patch for 1_8 branch (2)

a=drivers

Comment 8

[Sergei Dolgov]

Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.91.4.18; previous revision: 1.91.4.17
done