Closed Bug 315784 Opened 19 years ago Closed 10 years ago

Changing language for in-line spell checker does not remove underlines

Categories

(Thunderbird :: Message Compose Window, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: ahespe, Unassigned)

References

Details

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.12) Gecko/20050919 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.12) Gecko/20050919 Firefox/1.0.7

When composing a new email in language other than the default language, the in-line spell check underlines words which are mis-spelt. After changing the spell check language to match the language that is being typed, the 'mis-spelt' words are now identified as being spelt correctly (right-clicking brings up the standard menu) but the red underline remains.

Reproducible: Always

Steps to Reproduce:
1.Type in a language other than the default spell check language, e.g. type in French when the dictionary is English.
2.Change the language for the spell checker to the intended email language (in the abovementioned case this would be French).
3.The red underline remains in the email composition window even though the words in French are now identified as being spelt correctly.

Actual Results:  
Words are underlined red even though they are identified by the program as being spelt correctly.

Expected Results:  
The red underline should disappear.
works for me in Thunderbird 1.5 RC1
Sorry.

It now works when changing in the toolbar (as the popup on the spell-button), but not when you change the language in the dialog box from the menubar. The language in the popup is changed, but the window isn't refreshed, so the underlines remain until the next time you change the language.
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Bug 316086 has been marked as a duplicate of this bug. ***
@Jo Hermans: Which version do you refer to, I've got 1.5 (20051201) and it still doesn't refresh the window when I change the language from within the compose window. Or didn't I get your last comment?
Greetings
xeen
(In reply to comment #4)
> @Jo Hermans: Which version do you refer to, I've got 1.5 (20051201) and it
> still doesn't refresh the window when I change the language from within the
> compose window. Or didn't I get your last comment?
> Greetings
> xeen
> 

I've tested it today again, in Thunderbird 1.5 RC2 (20051201). It works with the button on the toolbar (which 1.0.7 didn't had), it doesn't work when changing from Options->Check Spelling.
*** Bug 323396 has been marked as a duplicate of this bug. ***
QA Contact: message-compose
Assignee: mscott → nobody
does this still fail when using current version?
Yes it's still there in 6.01 as described in the initial bug report

(Workaround to remove the underlining is to right click in message window, deselect "Check Spelling", and then enable it again.)
I never saw this problem in 24.6.0 or older, but this behavior appeared with the upgrade to Tb 31.0. When I switch the language used for spellchecking, only as few words are no longer underlined, but most of them still are. If I scroll the window to have some text out of view, then the underlining is gone when I scroll back. This means that the underlining isn't removed. But if I switch the language back, then all unknown words become underlined immediately.
Let me first say, that I love Thunderbird and recommend it to all my friends. But what's going on the in area of spell-checking is simply extremely poor. There are more languages than English used in the world, many people are bi-lingual, so it's just so poor that this can be gotten right once and for all.

And even worse, what used to work gets broken in the next release.

As the previous author said: This problem didn't exist in 24.6.0 and has now appeared in 31.
Here is what you need to do to reproduce:
1. Write a message in language 1. Set spelling to language 1.
2. Reuse a message in language 2 (Edit as new). Lots of errors are marked, since the dictionary is set to language 1.
3. Set spelling to language 2.
Spelling mistakes are not removed.

This is the safest way to reproduce it. I've seen other random cases where the error marks are not removed when switching dictionaries, for example:
1. With dictionary in English, start new message in Spanish, errors show.
2. Switch to Spanish, errors go.
3. Switch to English, errors come back.
4. Switch to Spanish, errors don't go away, or sometimes they do.
Since this is an ancient bug, I opened a new one: bug 1073936
This bug should be closed this there is a follow up (bug 1073936).

As comment #10 says, this bug was fixed long time ago, then reintroduced in version 31.x.
It's no longer present in 33 or 34 beta or daily (16th Nov. 2014), see bug 1073936 for details.
@Frédéric Buclin:
I'm marking this resolved, since I'm pretty sure the original problem discussed until 2011 was fixed.
Whatever was introduced in version 31 has been documented in bug 1073936.
When you have the time, could you please try a beta or daily version to confirm that this is a "WORKSFORME".
Thank you.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.