315917 - Configure the three XULRunner tinderboxes with JDK

Status: VERIFIED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Benjamin Smedberg]

Two XULRunner tinderboxen need the JDK installed/configured:

Linux argo
WINNT solaria

After the JDK is installed, it may also be necessary to set JDK_HOME in the global environment.

Mac columbia is probably already fine (it seems that JDK comes with MacOS X).

Comment 1

[jhp (no longer active)]

(In reply to comment #0)
> After the JDK is installed, it may also be necessary to set JDK_HOME in the
> global environment.

The correct environment variable name is JAVA_HOME.

Comment 2

[J. Paul Reed [:preed]]

Argo has the 1.5.0.06 JDK installed:

[cltbld@argo cltbld]$ java -version
java version "1.5.0_06"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
Java HotSpot(TM) Server VM (build 1.5.0_06-b05, mixed mode)
[cltbld@argo cltbld]$ which javac
/usr/java/jdk1.5.0_06/bin/javac
[cltbld@argo cltbld]$ export | grep JAVA
declare -x JAVA_HOME="/usr/java/jdk1.5.0_06"

md5sum for the installation package used is:
3188bedc75d4500f599558427b95156c  jdk-1_5_0_06-linux-i586-rpm.bin

I'm working on Windows, but I might have to take the Solaria tinderboxen down to install it; still investigating.

Coop: if you don't mind, I'm gonna reassign this to me, since I'm working on it.

Comment 3

[J. Paul Reed [:preed]]

Solaria now has the 1.5.0.06 JDK installed too; interestingly enough, there isn't a JAVA_HOME variable defined in the Windows environment, nor in the Cygwin environment, but running "java -version" in the cltbld cygwin window gives the 1.5.0.06 installation.

Installed package was:

d684c84a746da6139170437d4dc638cc  jdk-1_5_0_06-windows-i586-p.exe

Comment 4

[jhp (no longer active)]

(In reply to comment #3)
> interestingly enough, there isn't a JAVA_HOME variable defined

For the purposes of Javaconnect, you can either define the Java location using the JAVA_HOME environment variable, or using the "--with-java-include-path" and "--with-java-bin-path" configure switches.

Comment 5

[Benjamin Smedberg]

Comment #4 is correct, we need either JAVA_HOME or mozconfig flags on argo/solaria.

Comment 6

[Benjamin Smedberg]

FWIW, I'd prefer the environment variable, so that when we land this on the branch we don't have to configure the mozconfig of those builds separately.

Comment 7

[J. Paul Reed [:preed]]

Alright:

Argo had the environment stuff all along (it's in /etc/profile.d/java.*; I just whipped those little env scripts up), but cltbld had to logged out/in to pick up the change. Looks like argo's tinderbox should be happy.

As for Solaria, I added JAVA_HOME to the global environment via the System Control Panel; an export in cygwin shows the environment variable set, although it's in "C:\\Program Files\\etc." style, not "/cygdrive/c/Program Files/etc." style.

Anyone know if this is going to confuse cygwin?

Comment 8

[Benjamin Smedberg]

Nope, bug 272662 fixed the win-versus-cygwin paths issue.

Comment 9

[J. Paul Reed [:preed]]

Both argo and solaria XULrunner tinderboxen are green; resolving fixed.

Comment 10

[jhp (no longer active)]

Trouble!  The tinderboxes have Java SDK 1.5 installed.  It turns out that compiling with JDK 1.5 does not allow the user to run using JVM 1.4.x.  Many people are still using JVM 1.4.2, so we should be compiling with JDK 1.4.2. Preed, can you downgrade the JDK version please?

Comment 11

[J. Paul Reed [:preed]]

I just thought of this: would adding the "-source=1.4" option to the javac calls be a viable short- (or even long-)term workaround for this?

Comment 12

[jhp (no longer active)]

Attachment: source flag patch

According to the docs, it looks like what we want.  This patch sets that flags for javac.  Not sure if this is the best place to put the flag.

Comment 13

[Benjamin Smedberg]

Comment on attachment 206203 [details] [diff] [review]
source flag patch

Use += for JAVAC_FLAGS

Comment 14

[jhp (no longer active)]

Patch checked in.  I'll test nightlies when they are available.

Comment 15

[jhp (no longer active)]

Verified that the builds now work with JVM 1.4.2.

Comment 16

[Benjamin Smedberg]

Fixed on MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH.