315930 - "Publish Entire Calendar" does not export tasks

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051110 Mozilla Sunbird/0.3a1+

"Publish Entire Calendar" does not export tasks, only events.

Steps to Reproduce:
- create new calendar
- create one event
- create one task
- select "Publish Entire Calendar" for calendar and export to a local *.ics file
- open *.ics file in text editor

Actual Results:
- there is only one VEVENT element in *.ics file

Expected Results:
- one VEVENT and one VTODO element should be in *.ics file

Comment 1

[Joey Minta]

Attachment: use correct filter

You don't get any tasks unless you specify a filter for completed or not.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 202663 [details] [diff] [review]
use correct filter

You shouls use ITEM_FILTER_ALL_ITEMS. That will always get all items.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

But from looking better, that will also set ITEM_FILTER_CLASS_OCCURRENCES, so will occurrences, rather then items.
I think we should change the idl though, to add a case for this. That way, you don't have to update all callers when adding a filter.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to comment #3)
> But from looking better, that will also set ITEM_FILTER_CLASS_OCCURRENCES, so
> will occurrences, rather then items.

If I'm reading this correctly, that's not the case:

        ITEM_FILTER_ALL_ITEMS = 0x0000FFFF
ITEM_FILTER_CLASS_OCCURRENCES = 0x00010000

So your original suggestion should be fine, I think.

Comment 5

[Joey Minta]

Attachment: use correct filter v2

uses ITEM_FILTER_ALL_ITEMS.  This doesn't seem like the right bug to start messing with the idl.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 202691 [details] [diff] [review]
use correct filter v2

r=mvl

Comment 7

[Joey Minta]

patch checked in

Comment 8

[Robin Edrenius]

*** Bug 316259 has been marked as a duplicate of this bug. ***