Closed Bug 316133 Opened 19 years ago Closed 18 years ago

Approval: Trademark Review for Norway (nn-NO) Firefox 2.0

Categories

(Mozilla Localizations :: nn-NO / Norwegian Nynorsk, defect)

Product:
Mozilla Localizations
Component:
nn-NO / Norwegian Nynorsk
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Pike, Assigned: ronnyva)

References

Details

Attachments

(3 files, 4 obsolete files)

Problem with removing charset
12.04 KB, image/png
Details
This is screenshot with the charset line included
11.23 KB, image/png
Details
nn-no search engines and bookmarks
35.37 KB, patch
Pike
: approval-l10n+
Details | Diff | Splinter Review 
Hi, this bug both affects and blocks nb and nn.
You're using the same search engine plugins and I'd like you to get those to a 
single set, using names like bok-no.src. In addition, please use the current
amazon-en-GB, and there are wrong encodings in amazon, bok, google, qxl, yahoo.
That should be macroman, not utf-8. (Don't use mac line endings, though)
iconv -f utf-8 -t macroman 
is a start, if it doesn't work, use the charset directive,
http://mycroft.mozdev.org/deepdocs/interprettag.html#charset.

In the bookmarks, please remove the community links in the personal toolbar 
folder, maybe add one (of the two, in case of nn) to the mozilla and firefox
folder, beneath the mozilla.com and mozilla-europe link. Talking about that,
please add a link to http://www.mozilla-europe.org/no/ beneath the mozilla.com
link, too (I guess no is ok for nn, too).
Ronny, please remove the dictionary.com quick search, too.

Thanks, and please attach patches and request approval-l10n on them.
Axel, thanks for locale review. Please review attached patch.

In addition to requested changes, also localized name "Mozilla Store".
Attachment #202752 - Flags: approval-l10n?
Status: NEW → ASSIGNED
Comment on attachment 202752 [details] [diff] [review]
nb-NO bookmarks and search engines changes

Please remove the
    charset="UTF-8"
lines from yahoo-NO.src and  google-NO.src.

And fix the 
\ No newline at end of file
too, please.
The rest looks fine, please attach a new patch with those fixes in.
Attachment #202752 - Flags: approval-l10n? → approval-l10n-
If you start taking out charset lines you'll break sidebar functionality.
Sidebar should be working off
http://mycroft.mozdev.org/deepdocs/searchtag.html#queryEncoding, not
http://mycroft.mozdev.org/deepdocs/interprettag.html#charset.

Plus, this is Firefox, it doesn't have a search result sidebar.
They do different things... you don't need to link to a document I edited last!
While accepting it only has the sidebar with an extension, what harm is the charset tag doing exactly - it does make a difference. I'll make up a test case if you want.
The explanation here:
http://bugzilla.mozdev.org/show_bug.cgi?id=9098

is rather clearer (sorry for multiple msgs, meant to link in last post)
removed 3x charset="UTF-8" lines in interpret sections.
added newlines at end of caplex/bok
Attachment #202752 - Attachment is obsolete: true
Attachment #202895 - Flags: approval-l10n?
Charles, assuming that our docs are just rotten, I went back to 
http://developer.apple.com/technotes/tn/tn1141.html. Glancing over this, I only
see support for ASCII in the src files themselves, and no means to change that.

Is that right? And does it work that way in the Mozilla implementation?
Please see the trouble with removing the charset line in this mini-screenshot.
I'll repeat with the line reinserted to show the difference if you want.

(Also, you're hitting a.m.o. every day with the update line?)

Sorry, if I seem to be a pain in the arse but I've had to fix so many plugins for character set problems on mycroft (and there are many that still have problems)
Oops, posted screenshot before saw post #8
I'm by no means an expert on the orig. spec - despite reading that technote before I never fully understood a few things.
I think you're right in saying that only ascii is supported in src files but this isn't what the charset tag does - it describes how to decode the parsed results for the sidebar. Whether or not the implementation meets the spec I couldn't tell you without looking through the source which I don't really fancy on a Sunday afternoon.

What I can confirm is that removing the line will muck up the sidebar results - see screenshot where the HM's name is clearly garbled.

(And the docs are certainly not accurate on mycroft and copying from many plugins doesn't work because they are also incorrect - I recently found a note on google that said that the ie and ei input tags had been deprecated for years yet many plugins still have them (not sure if it applies to google custom search or not))

Anyway, feel rather out of my depth now, but please leave the charset line in and if you want to discuss further then poss best to send me an email outside of this bug.
For completeness, this is what you get with the charset line in place.
Comment on attachment 202752 [details] [diff] [review]
nb-NO bookmarks and search engines changes

based on the discussion approving this one.
Attachment #202752 - Flags: approval-l10n- → approval-l10n+
Attachment #202895 - Attachment is obsolete: true
Attachment #202895 - Flags: approval-l10n?
Checked into branch at 19:15 cet

Thanks for review, and thanks, mr. Caygill, for pointing out problems with charset.

Checking in browser/profile/bookmarks.html;
/l10n/l10n/nb-NO/browser/profile/bookmarks.html,v  <--  bookmarks.html
new revision: 1.4.2.15; previous revision: 1.4.2.14
done
RCS file: /l10n/l10n/nb-NO/browser/searchplugins/Attic/amazon-en-GB.png,v
done
Checking in browser/searchplugins/amazon-en-GB.png;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/amazon-en-GB.png,v  <--  amazon-en-GB.png
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file: /l10n/l10n/nb-NO/browser/searchplugins/Attic/amazon-en-GB.src,v
done
Checking in browser/searchplugins/amazon-en-GB.src;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/amazon-en-GB.src,v  <--  amazon-en-GB.src
new revision: 1.1.2.1; previous revision: 1.1
done
Removing browser/searchplugins/amazoncouk-nb-NO.png;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/amazoncouk-nb-NO.png,v  <--  amazoncouk-nb-NO.png
new revision: delete; previous revision: 1.1.2.3
done
Removing browser/searchplugins/amazoncouk-nb-NO.src;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/amazoncouk-nb-NO.src,v  <--  amazoncouk-nb-NO.src
new revision: delete; previous revision: 1.1.2.3
done
RCS file: /l10n/l10n/nb-NO/browser/searchplugins/Attic/bok-NO.png,v
done
Checking in browser/searchplugins/bok-NO.png;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/bok-NO.png,v  <--  bok-NO.png
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file: /l10n/l10n/nb-NO/browser/searchplugins/Attic/bok-NO.src,v
done
Checking in browser/searchplugins/bok-NO.src;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/bok-NO.src,v  <--  bok-NO.src
new revision: 1.1.2.1; previous revision: 1.1
done
Removing browser/searchplugins/bok-nb-NO.png;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/bok-nb-NO.png,v  <--  bok-nb-NO.png
new revision: delete; previous revision: 1.1.2.1
done
Removing browser/searchplugins/bok-nb-NO.src;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/bok-nb-NO.src,v  <--  bok-nb-NO.src
new revision: delete; previous revision: 1.1.2.1
done
RCS file: /l10n/l10n/nb-NO/browser/searchplugins/Attic/caplex-NO.gif,v
done
Checking in browser/searchplugins/caplex-NO.gif;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/caplex-NO.gif,v  <--  caplex-NO.gif
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file: /l10n/l10n/nb-NO/browser/searchplugins/Attic/caplex-NO.src,v
done
Checking in browser/searchplugins/caplex-NO.src;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/caplex-NO.src,v  <--  caplex-NO.src
new revision: 1.1.2.1; previous revision: 1.1
done
Removing browser/searchplugins/caplex-nb-NO.gif;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/caplex-nb-NO.gif,v  <--  caplex-nb-NO.gif
new revision: delete; previous revision: 1.1.2.1
done
Removing browser/searchplugins/caplex-nb-NO.src;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/caplex-nb-NO.src,v  <--  caplex-nb-NO.src
new revision: delete; previous revision: 1.1.2.1
done
RCS file: /l10n/l10n/nb-NO/browser/searchplugins/Attic/google-NO.gif,v
done
Checking in browser/searchplugins/google-NO.gif;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/google-NO.gif,v  <--  google-NO.gif
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file: /l10n/l10n/nb-NO/browser/searchplugins/Attic/google-NO.src,v
done
Checking in browser/searchplugins/google-NO.src;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/google-NO.src,v  <--  google-NO.src
new revision: 1.1.2.1; previous revision: 1.1
done
Removing browser/searchplugins/google-nb-NO.gif;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/google-nb-NO.gif,v  <--  google-nb-NO.gif
new revision: delete; previous revision: 1.1.2.1
done
Removing browser/searchplugins/google-nb-NO.src;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/google-nb-NO.src,v  <--  google-nb-NO.src
new revision: delete; previous revision: 1.1.2.3
done
Checking in browser/searchplugins/list.txt;
/l10n/l10n/nb-NO/browser/searchplugins/list.txt,v  <--  list.txt
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
RCS file: /l10n/l10n/nb-NO/browser/searchplugins/Attic/qxl-NO.png,v
done
Checking in browser/searchplugins/qxl-NO.png;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/qxl-NO.png,v  <--  qxl-NO.png
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file: /l10n/l10n/nb-NO/browser/searchplugins/Attic/qxl-NO.src,v
done
Checking in browser/searchplugins/qxl-NO.src;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/qxl-NO.src,v  <--  qxl-NO.src
new revision: 1.1.2.1; previous revision: 1.1
done
Removing browser/searchplugins/qxl-nb-NO.png;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/qxl-nb-NO.png,v  <--  qxl-nb-NO.png
new revision: delete; previous revision: 1.1.2.1
done
Removing browser/searchplugins/qxl-nb-NO.src;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/qxl-nb-NO.src,v  <--  qxl-nb-NO.src
new revision: delete; previous revision: 1.1.2.3
done
RCS file: /l10n/l10n/nb-NO/browser/searchplugins/Attic/telefonkatalogen-NO.png,v
done
Checking in browser/searchplugins/telefonkatalogen-NO.png;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/telefonkatalogen-NO.png,v  <--  telefonkatalogen-NO.png
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file: /l10n/l10n/nb-NO/browser/searchplugins/Attic/telefonkatalogen-NO.src,v
done
Checking in browser/searchplugins/telefonkatalogen-NO.src;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/telefonkatalogen-NO.src,v  <--  telefonkatalogen-NO.src
new revision: 1.1.2.1; previous revision: 1.1
done
Removing browser/searchplugins/telefonkatalogen-nb-NO.png;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/telefonkatalogen-nb-NO.png,v  <--  telefonkatalogen-nb-NO.png
new revision: delete; previous revision: 1.1.2.1
done
Removing browser/searchplugins/telefonkatalogen-nb-NO.src;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/telefonkatalogen-nb-NO.src,v  <--  telefonkatalogen-nb-NO.src
new revision: delete; previous revision: 1.1.2.1
done
RCS file: /l10n/l10n/nb-NO/browser/searchplugins/Attic/yahoo-NO.gif,v
done
Checking in browser/searchplugins/yahoo-NO.gif;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/yahoo-NO.gif,v  <--  yahoo-NO.gif
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file: /l10n/l10n/nb-NO/browser/searchplugins/Attic/yahoo-NO.src,v
done
Checking in browser/searchplugins/yahoo-NO.src;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/yahoo-NO.src,v  <--  yahoo-NO.src
new revision: 1.1.2.1; previous revision: 1.1
done
Removing browser/searchplugins/yahoo-nb-NO.gif;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/yahoo-nb-NO.gif,v  <--  yahoo-nb-NO.gif
new revision: delete; previous revision: 1.1.2.1
done
Removing browser/searchplugins/yahoo-nb-NO.src;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/yahoo-nb-NO.src,v  <--  yahoo-nb-NO.src
new revision: delete; previous revision: 1.1.2.3
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Reopening for nn-NO.
Status: RESOLVED → REOPENED
Component: nb-NO / Norwegian → no-NO / Norwegian
Resolution: FIXED → ---
Assignee: havarmor → ronny
Status: REOPENED → NEW
According to vidar, nn-NO is not targetting 1.5.

Thus I'm removing the dependency on bug 307393, adding bug 318300 to keep track.
Blocks: tm-l10n
No longer blocks: 307393
Summary: Trademark Review for Norway (nb-NO, nn-NO) Firefox 1.5 → Trademark Review for Norway (nn-NO) Firefox 1.5
Seeking trademark approval for search engines and bookmarks for Firefox 2.0 nn-NO.

Search engines will be shared with the nb-NO where possible.
We have the following wishes:
- The Google plug-in will be localized to include HL parameter. This is needed to differentiate between nn-NO and nb-NO translations of Google.
- We'd like to drop the Yahoo plug-in for Nynorsk, as Yahoo is only provided in bokmål (nb-NO). Our search engines will include other engines that have bokmål language, but we feel it's necessary to avoid this where possible, in order to give the user the best possible web experience.

We want the following search engines:
- amazon-en-GB (original from en-GB)
- bok-NO (dictionary search for both NN and NO)
- google-NN
- qxl-NO (auction site)
- telefonkatalogen-NO (telephone directory)
- wikipedia-NN (encyclopedia)

The suffix -NN means nynorsk-specific, suffix -NO means a nb-NO locale.
Attachment #230264 - Flags: approval-l10n?
Attached file Bookmarks for nn-NO, for review (obsolete) — 
Attached bookmarks file for review.

Bookmarks have been tested to work correctly as profile defaults.
Attachment #230265 - Flags: approval-l10n?
Putting this on Mic's radar.

Mic, we shipped nb-NO, but we didn't ship nn-NO for 1.5. The two share the country, so the partners should be similar, at least.
Summary: Trademark Review for Norway (nn-NO) Firefox 1.5 → Approval: Trademark Review for Norway (nn-NO) Firefox 2.0
See bug 346549 for similar modifications to nb-NO search plugins.
Comment on attachment 230265 [details]
Bookmarks for nn-NO, for review

Bookmarks changed significantly since that patch, most of this should just be redirect requests. Where to feed those needs to be determined still.
Attachment #230265 - Flags: approval-l10n? → approval-l10n-
hey
sorry for weighing in so late in the game. 
for yahoo search engine plug in - considering they don't have a local language product it is OK to drop them from the plug in list 
hope that's helpful
thanks
mic

Comment on attachment 230264 [details]
Search engines for nn-NO, for trademark review

I'd rather have a patch that I can review here.
Could have said that a week ago, too. Sorry.
Attachment #230264 - Flags: approval-l10n? → approval-l10n-
Blocks: 348110
Any update on a patch? I'd take one either here or in bug 346549.
nn-NO search engines and bookmarks for review

Sorry about the lateness of this. It is not intentional.

Using google.xml and hoping locale is correctly detected.
Attachment #230264 - Attachment is obsolete: true
Attachment #230265 - Attachment is obsolete: true
Attachment #237771 - Flags: approval-l10n?
Comment on attachment 237771 [details] [diff] [review]
nn-no search engines and bookmarks

Let's get this landed, though you shouldn't commit google.xml, that's picked up from the en-US sources anyway by the build system.
Attachment #237771 - Flags: approval-l10n? → approval-l10n+
sorry for the late approval, this slipped through my hundreds of daily mails.
Checked in 5 min ago. Did not include google.xml in check-in as per comment. Thank you.

Checking in browser/profile/bookmarks.html;
/l10n/l10n/nn-NO/browser/profile/bookmarks.html,v  <--  bookmarks.html
new revision: 1.1.2.7; previous revision: 1.1.2.6
done
RCS file: /l10n/l10n/nn-NO/browser/searchplugins/Attic/amazon-en-GB.xml,v
done
Checking in browser/searchplugins/amazon-en-GB.xml;
/l10n/l10n/nn-NO/browser/searchplugins/Attic/amazon-en-GB.xml,v  <--  amazon-en-GB.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Removing browser/searchplugins/amazondotcom.xml;
/l10n/l10n/nn-NO/browser/searchplugins/Attic/amazondotcom.xml,v  <--  amazondotcom.xml
new revision: delete; previous revision: 1.1.2.2
done
Removing browser/searchplugins/answers.xml;
/l10n/l10n/nn-NO/browser/searchplugins/Attic/answers.xml,v  <--  answers.xml
new revision: delete; previous revision: 1.1.2.3
done
RCS file: /l10n/l10n/nn-NO/browser/searchplugins/Attic/bok-NO.xml,v
done
Checking in browser/searchplugins/bok-NO.xml;
/l10n/l10n/nn-NO/browser/searchplugins/Attic/bok-NO.xml,v  <--  bok-NO.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Removing browser/searchplugins/creativecommons.xml;
/l10n/l10n/nn-NO/browser/searchplugins/Attic/creativecommons.xml,v  <--  creativecommons.xml
new revision: delete; previous revision: 1.1.2.2
done
Removing browser/searchplugins/eBay.xml;
/l10n/l10n/nn-NO/browser/searchplugins/Attic/eBay.xml,v  <--  eBay.xml
new revision: delete; previous revision: 1.1.2.2
done
Removing browser/searchplugins/google-NN.xml;
/l10n/l10n/nn-NO/browser/searchplugins/Attic/google-NN.xml,v  <--  google-NN.xml
new revision: delete; previous revision: 1.1.2.1
done
Checking in browser/searchplugins/list.txt;
/l10n/l10n/nn-NO/browser/searchplugins/list.txt,v  <--  list.txt
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
RCS file: /l10n/l10n/nn-NO/browser/searchplugins/Attic/qxl-NO.xml,v
done
Checking in browser/searchplugins/qxl-NO.xml;
/l10n/l10n/nn-NO/browser/searchplugins/Attic/qxl-NO.xml,v  <--  qxl-NO.xml
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file: /l10n/l10n/nn-NO/browser/searchplugins/Attic/telefonkatalogen-NO.xml,v
done
Checking in browser/searchplugins/telefonkatalogen-NO.xml;
/l10n/l10n/nn-NO/browser/searchplugins/Attic/telefonkatalogen-NO.xml,v  <--  telefonkatalogen-NO.xml
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file: /l10n/l10n/nn-NO/browser/searchplugins/Attic/wikipedia-NN.xml,v
done
Checking in browser/searchplugins/wikipedia-NN.xml;
/l10n/l10n/nn-NO/browser/searchplugins/Attic/wikipedia-NN.xml,v  <--  wikipedia-NN.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Removing browser/searchplugins/yahoo-NO.xml;
/l10n/l10n/nn-NO/browser/searchplugins/Attic/yahoo-NO.xml,v  <--  yahoo-NO.xml
new revision: delete; previous revision: 1.1.2.8
done
Status: NEW → RESOLVED
Closed: 19 years ago → 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: