346549 - Search engines and bookmarks for nb-NO

Status: VERIFIED FIXED

(Mozilla Localizations :: nb-NO / Norwegian Bokmål, defect)

Description

[Håvard Mork]

nb-NO seeks approval for changing search plugins and bookmarks for 2.0:

The following search plugins:
* amazon-en-GB.xml -- as 1.5
* bok-NO.xml -- as 1.5
* google-NO.xml -- want a NO suffix so HL parameter can be included. Needed to differentiate between nynorsk and bokmål locales.
* qxl-NO.xml -- as 1.5
* telefonkatalogen-NO.xml -- as 1.5
* wikipedia-NO.xml -- NEW. Instead of "caplex" in 1.5, which has significantly lower quality.
* yahoo-NO.xml -- as 1.5.

Bookmarks should also have little difference from 1.5. The RSS-feed is identical to 1.5.

Search plugins will be shared with nn-NO where appropriate. See bug 316133 for nn-NO trademark approval (you probably want to look at this simultaneously, as there is little difference in bookmarks/searchplugins).

Comment 1

[Håvard Mork]

Attachment: search engines and bookmarks for nb-NO

Comment 2

[Axel Hecht [:Pike]]

Regarding google, shouldn't

nb-NO/toolkit/chrome/global/intl.properties:intl.accept_languages=nb, no, nn, en-us, en
nn-NO/toolkit/chrome/global/intl.properties:intl.accept_languages=nn, no, nb, en-us, en

take care of that? My testing says so.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 231303 [details]
search engines and bookmarks for nb-NO

... and I'd prefer a patch, here, too.

Comment 4

[Håvard Mork]

Attachment: search engines and bookmarks for nb-no #2

Seeking approval
using google.xml instead of the previous google-NO.xml recommendation.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 237768 [details] [diff] [review]
search engines and bookmarks for nb-no #2

same as in the nn-no patch, please don't check-in the google.xml file, as that's going to be picked up from en-US sources (as long as "google" is in list.txt).

For future reference, Mozillians are much more familiar with reading cvs diff -u, you wanna do that in upcoming patches.

Comment 6

[Mic Berman]

Havard,
do you happen to have email contacts for bok-NO.xml, qxl-NO.xml, and telefonkatalogen-NO.xml? if so can you email them to me.
it would also be great to get any feedback from these folks e.g., happy, strong user experiences, etc.
thanks
mic

Comment 7

[Håvard Mork]

removing google.xml done (do I need attach new patch?)
mic e-mailed on contact information
still waiting for approval, no hurry though. :-)

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 237768 [details] [diff] [review]
search engines and bookmarks for nb-no #2

oops, sorry, forgot that the same comment should have the same flag setting magic.

Comment 9

[Håvard Mork]

checked in on 1.8 branch 5 minutes ago. google.xml removed from branch as per comment. Thanks for the review! :)

Checking in browser/profile/bookmarks.html;
/l10n/l10n/nb-NO/browser/profile/bookmarks.html,v  <--  bookmarks.html
new revision: 1.4.2.20; previous revision: 1.4.2.19
done
Checking in browser/searchplugins/amazon-en-GB.xml;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/amazon-en-GB.xml,v  <--  amazon-en-GB.xml
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Removing browser/searchplugins/amazondotcom.xml;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/amazondotcom.xml,v  <--  amazondotcom.xml
new revision: delete; previous revision: 1.1.2.4
done
Removing browser/searchplugins/answers.xml;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/answers.xml,v  <--  answers.xml
new revision: delete; previous revision: 1.1.2.5
done
Checking in browser/searchplugins/bok-NO.xml;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/bok-NO.xml,v  <--  bok-NO.xml
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Removing browser/searchplugins/creativecommons.xml;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/creativecommons.xml,v  <--  creativecommons.xml
new revision: delete; previous revision: 1.1.2.4
done
Removing browser/searchplugins/eBay.xml;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/eBay.xml,v  <--  eBay.xml
new revision: delete; previous revision: 1.1.2.4
done
Removing browser/searchplugins/google.xml;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/google.xml,v  <--  google.xml
new revision: delete; previous revision: 1.1.2.1
done
Checking in browser/searchplugins/list.txt;
/l10n/l10n/nb-NO/browser/searchplugins/list.txt,v  <--  list.txt
new revision: 1.1.2.8; previous revision: 1.1.2.7
done
Checking in browser/searchplugins/qxl-NO.xml;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/qxl-NO.xml,v  <--  qxl-NO.xml
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Checking in browser/searchplugins/telefonkatalogen-NO.xml;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/telefonkatalogen-NO.xml,v  <--  telefonkatalogen-NO.xml
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Checking in browser/searchplugins/wikipedia-NO.xml;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/wikipedia-NO.xml,v  <--  wikipedia-NO.xml
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Checking in browser/searchplugins/yahoo-NO.xml;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/yahoo-NO.xml,v  <--  yahoo-NO.xml
new revision: 1.1.2.5; previous revision: 1.1.2.4
done
Removing browser/searchplugins/yahoo.xml;
/l10n/l10n/nb-NO/browser/searchplugins/Attic/yahoo.xml,v  <--  yahoo.xml
new revision: delete; previous revision: 1.1.2.1
done