316305 - [BeOS]Reduce communication with app_server at painting.

Status: RESOLVED FIXED

(Core Graveyard :: GFX: BeOS, defect)

Description

[Sergei Dolgov]

Single repaint may involve several calls for same rendering context, but we are poking app_server with SetFont() and SetColor() at each paint "atom" in LockAndUpdateView();
Actually Font and Color must be set for BView via corresponding nsRenderingContextBeOS methods, and set in LockAndUpdateView() only in case when those wasn't set before.

Seems working here, but i need to test more carefully if we need also to call renderingContext->SetFont/Color in nsWindow::OnPaint() for chrome/XUL items.

Unfortunately this approach don't work for ClipRegion/Rect, especially for chrome. Maybe will return to this one later.

Comment 1

[Doug Shelton]

Confirming this patch works well under Zeta 1.1.

Comment 2

[Doug Shelton]

Ignore comment #1, please.  Posted in wrong bug - sorry.

Comment 3

[Sergei Dolgov]

Attachment: patch

review request.

Setting BView font and color in nsRenderingContext SetFont/Color methods, thus avoiding to reset it at each drawing primitive call inside LockAndUpdate().
Also fixing "float to int" warning.

Comment 4

[tqh]

Comment on attachment 205484 [details] [diff] [review]
patch

r=[e-mail]

Comment 5

[Sergei Dolgov]

landed in trunk
Checking in mozilla/gfx/src/beos/nsRenderingContextBeOS.cpp;
/cvsroot/mozilla/gfx/src/beos/nsRenderingContextBeOS.cpp,v  <--  nsRenderingContextBeOS.cpp
new revision: 1.57; previous revision: 1.56
done
Checking in mozilla/gfx/src/beos/nsRenderingContextBeOS.h;
/cvsroot/mozilla/gfx/src/beos/nsRenderingContextBeOS.h,v  <--  nsRenderingContextBeOS.h
new revision: 1.30; previous revision: 1.29
done

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

this broke the build for me (no matching function for call to GetFontHandle); I checked in a fix (changed the cast to (nsFontHandle&))

Comment 7

[Niels Reedijk]

Is going to land in the branch.

Comment 8

[Niels Reedijk]

Comment on attachment 205484 [details] [diff] [review]
patch

Requesting permission to land in the MOZILLA_1_8_BRANCH.

This is a BeOS-only change and does not affect other platforms.

Note: sergei_d: apply after bug 283225.

Comment 9

[Sergei Dolgov]

Checking in mozilla/gfx/src/beos/nsRenderingContextBeOS.cpp;
/cvsroot/mozilla/gfx/src/beos/nsRenderingContextBeOS.cpp,v  <--  nsRenderingContextBeOS.cpp
new revision: 1.51.12.6; previous revision: 1.51.12.5
done
Checking in mozilla/gfx/src/beos/nsRenderingContextBeOS.h;
/cvsroot/mozilla/gfx/src/beos/nsRenderingContextBeOS.h,v  <--  nsRenderingContextBeOS.h
new revision: 1.28.12.2; previous revision: 1.28.12.1
done