316663 - [Win9x] Cannot display Japanese text on update processing dialog

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P1)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Cannot display Japanese text on update processing dialog on Win9x.
# WinNT doen't have this problem.
See this screenshots
On Win98
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2968&action=view
On WinXP
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2969&action=view

This bug is same as bug 266309.
We don't set the font for IDC_INFO.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Attachment: Patch rv1.0

This may fix this bug. But I cannot test it. Can I test it? How to do?

Comment 2

[shutdown]

(In reply to comment #1)
> Created an attachment (id=203221) [edit]
> Patch rv1.0
> This may fix this bug. But I cannot test it. Can I test it? How to do?

| +  HFONT systemFont = CreateFontIndirect(&ncm.lfMessageFont);
| +  SendDlgItemMessage(hDlg, IDC_INFO, WM_SETFONT, (WPARAM)systemFont, 0L);
| +  DeleteObject(systemFont);

You must not delete the font while the control is using it.

http://msdn.microsoft.com/library/en-us/winui/winui/windowsuserinterface/windowing/windows/windowreference/windowmessages/wm_setfont.asp
http://support.microsoft.com/kb/q85518/EN-US/

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Attachment: Patch rv2.0

> You must not delete the font while the control is using it.

Thank you for your advice!

Comment 4

[Scott MacGregor]

Masayuki, we aren't going to block 1.5 on this bug which only effects Win9x users.

But this should be on the 1.8.1 radar and I see it's already nominated, perfect!

Comment 5

[Darin Fisher]

Comment on attachment 203259 [details] [diff] [review]
Patch rv2.0

ok, r+sr=darin

Comment 6

[Darin Fisher]

Attachment: v2.1 patch

here's the patch that i checked in

Comment 7

[Darin Fisher]

fixed-on-trunk

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

thanks, Darin.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Comment on attachment 204502 [details] [diff] [review]
v2.1 patch

I request this to 1.8 branch.

Comment 10

[David G King]

Reopening as causes compile crash on WinXP with MinGW/cygwin

e:/mozilla/source/mozilla/toolkit/mozapps/update/src/updater/progressui_win.cpp:
138: undefined reference to `CreateFontIndirectA@4'
progressui_win.o: In function `Z10DialogProcP6HWND__jjl':
e:/mozilla/source/mozilla/toolkit/mozapps/update/src/updater/progressui_win.cpp:
169: undefined reference to `DeleteObject@4'

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

David:

Please don't open by MinGW problem.
Please file a new bug. Because other people cannot find this bug from the problem.

Comment 12

[David G King]

Bug #318470 created

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

thanks,

Comment 14

[Mike Schroepfer]

Darin - can you comment on regression risk to non-win98 platforms.

Comment 15

[Daniel Veditz [:dveditz]]

not for 1.8.0.1

Comment 16

[Daniel Veditz [:dveditz]]

Comment on attachment 204502 [details] [diff] [review]
v2.1 patch

a-

Comment 17

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Daniel:

Why it's denied? Please clarify the reason.

Comment 18

[Daniel Veditz [:dveditz]]

(In reply to comment #17)
> Why it's denied? Please clarify the reason.

For the security/stability branches it's the opposite: bug nominators must explain why the benefit of the patch outweighs the risk and qa costs associated with any change. Also comment 14 was never answered.

Comment 19

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Daniel:

Darin is not checking the bug mail.(You can confirm by posting the comment.)

Comment 20

[Darin Fisher]

> Darin - can you comment on regression risk to non-win98 platforms.

Sorry, I missed this bugmail go by...

In my opinion the risk is extremely low.  We've been running with this patch for several months now on the trunk without any problems.

If we care at all about the auto-update experience for Japanese users on Win9x, then this patch is a great one to take.

Comment 21

[Daniel Veditz [:dveditz]]

thank you, that's the kind of information we need.

Comment 22

[Daniel Veditz [:dveditz]]

Comment on attachment 204502 [details] [diff] [review]
v2.1 patch

a=dveditz