Closed Bug 318470 Opened 17 years ago Closed 17 years ago

Build failure with MinGW due to Bug #316663

Categories

(Toolkit :: Application Update, defect)

x86
Windows XP
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: d_king, Assigned: masayuki)

References

Details

(Keywords: fixed1.8.0.1, fixed1.8.1, Whiteboard: [need testcase])

Attachments

(1 file, 1 obsolete file)

Patch for Bug #316663 causes build failure on WinXP/cygwin/MingW with following :-

e:/mozilla/source/mozilla/toolkit/mozapps/update/src/updater/progressui_win.cpp:
138: undefined reference to `CreateFontIndirectA@4'
progressui_win.o: In function `Z10DialogProcP6HWND__jjl':
e:/mozilla/source/mozilla/toolkit/mozapps/update/src/updater/progressui_win.cpp:
169: undefined reference to `DeleteObject@4'
Attached patch Patch rv1.0 (obsolete) — Splinter Review
I think that this fixes this bug. But I cannot test it. Please test it.
Attached patch Patch rv1.1Splinter Review
Sorry previous patch might be wrong.
Attachment #204633 - Attachment is obsolete: true
Whiteboard: test wanted
Comment on attachment 204633 [details] [diff] [review]
Patch rv1.0

You are right, this patch didn't work. Now testing rv1.1
Comment on attachment 204636 [details] [diff] [review]
Patch rv1.1

Initial test shows that this patch is good.
Comment on attachment 204636 [details] [diff] [review]
Patch rv1.1

Thank you for your test.
Attachment #204636 - Flags: review?(benjamin)
Assignee: nobody → masayuki
Flags: blocking1.8.1?
Flags: blocking1.8.0.1?
Summary: Build failure due to Bug #316663 → Build failure with MinGW due to Bug #316663
Whiteboard: test wanted
Status: NEW → ASSIGNED
Attachment #204636 - Flags: review?(benjamin) → review+
Attachment #204636 - Flags: superreview?(darin)
Attachment #204636 - Flags: superreview?(darin) → superreview+
checked-in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment on attachment 204636 [details] [diff] [review]
Patch rv1.1

This and bug 316663 are need for l10n build's updater.
Attachment #204636 - Flags: approval1.8.0.1?
We should take this if we take bug 316663:  the change is in ifdefs such that it only affects gcc builds on Windows, which means it doesn't affect any of our official release builds.  There's no reason to break the MinGW build in a dot release given that the fix needed is MinGW-only.
Comment on attachment 204636 [details] [diff] [review]
Patch rv1.1

Please mark fixed1.8.1 and fixed1.8.0.1 when this is checked in.
Attachment #204636 - Flags: approval1.8.1+
Attachment #204636 - Flags: approval1.8.0.1?
Attachment #204636 - Flags: approval1.8.0.1+
Flags: blocking1.8.1?
Flags: blocking1.8.1+
Flags: blocking1.8.0.1?
Flags: blocking1.8.0.1+
Anyone out there that can verify this on the branches? If not, is this fix simple enough to just mark verified based on David's testing?
Whiteboard: [need testcase]
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.