316692 - Add a shortcut for Email Page Location

Status: VERIFIED FIXED

(Camino Graveyard :: Toolbars & Menus, enhancement)

Description

[Jasper]

Email Page Location is one of the only main menu items which doesn't have a shortcut. Safari gained this option in v2 and they use "Command+Shift+I", so I'd suggest we use the same.

Comment 1

[Jasper]

Or we could use Command+Shift+L to keep the reference to location.

Let me know and I will attach a new mainmenu.nib.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Do enough people really use that often enough to warrant a shortcut?

Comment 3

[Jasper]

Based on user feedback and some forum post I have read I'd say there are enough people that use this feature. But I mainly think that since we have a toolbar item and a menu item, and since most other features that have that to I say that is enough to also give it a shortcut.

Comment 4

[Samuel Sidler (old account; do not CC)]

I could agree with this. While it doesn't seem used as much as the rest of our shortcuts (I'm guessing), there's probably a decent subsect of users who live by it. :) That said, I'd suggest L rather than I and say (once again) "I have no clue what Safari was thinking..."

Comment 5

[Jasper]

Attachment: command+shift+L

This is a recent MainMenu.nib file with the command+shift+L shortcut added to the Email Page location menu item. Requesting a review from mike.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mike, is this a go?

Comment 7

[Simon Fraser [no longer active]]

Command-Shift-L is taken by "Search with Google" in the Services menu, which is Safari. So maybe we should use that  :)

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 203361 [details]
command+shift+L

This nib is outdated now that bug 304036 landed.

Comment 9

[Mike Pinkerton (not reading bugmail)]

i tried to land this on friday but my builds weren't updating correctly. i'll try again later this week.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: updated nib

up-to-date nib--at least until page info/bookmark info moves into the View menu ;)

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Do you still intend to land this for 1.0?

Comment 12

[Simon Fraser [no longer active]]

Done.