Closed Bug 316692 Opened 15 years ago Closed 15 years ago

Add a shortcut for Email Page Location

Categories

(Camino Graveyard :: Toolbars & Menus, enhancement)

PowerPC
macOS
enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Camino1.0

People

(Reporter: camino, Assigned: mikepinkerton)

Details

(Keywords: fixed1.8.0.1, fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

Email Page Location is one of the only main menu items which doesn't have a shortcut. Safari gained this option in v2 and they use "Command+Shift+I", so I'd suggest we use the same.
Or we could use Command+Shift+L to keep the reference to location.

Let me know and I will attach a new mainmenu.nib.
Do enough people really use that often enough to warrant a shortcut?
Based on user feedback and some forum post I have read I'd say there are enough people that use this feature. But I mainly think that since we have a toolbar item and a menu item, and since most other features that have that to I say that is enough to also give it a shortcut.
I could agree with this. While it doesn't seem used as much as the rest of our shortcuts (I'm guessing), there's probably a decent subsect of users who live by it. :) That said, I'd suggest L rather than I and say (once again) "I have no clue what Safari was thinking..."
Attached file command+shift+L (obsolete) —
This is a recent MainMenu.nib file with the command+shift+L shortcut added to the Email Page location menu item. Requesting a review from mike.
Attachment #203361 - Flags: review?(mikepinkerton)
Mike, is this a go?
Flags: camino1.0?
Command-Shift-L is taken by "Search with Google" in the Services menu, which is Safari. So maybe we should use that  :)
Comment on attachment 203361 [details]
command+shift+L

This nib is outdated now that bug 304036 landed.
Attachment #203361 - Attachment is obsolete: true
Attachment #203361 - Flags: review?(mikepinkerton)
i tried to land this on friday but my builds weren't updating correctly. i'll try again later this week.
Flags: camino1.0? → camino1.0+
Attached file updated nib
up-to-date nib--at least until page info/bookmark info moves into the View menu ;)
Do you still intend to land this for 1.0?
Done.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.