31699 - Extra trailing CR/LF for textareas

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Eric Pollmann]

A textarea will get an extra %0D%0A on submission, and if you then click on the
"back" button and submit again, there will be *2* extra %0D%0A's!

I think this is probably an error in GetTextControlFrameState, so I'm rewriting
that logic now.

See bug 22983, which is related, but fixed.

Comment 1

[Eric Pollmann]

Akkana, I think you just fixed this bug (dup of bug 20207?)  Can you verify that
your fix also works for this problem?  Thanks!

Comment 2

[Eric Pollmann]

Oops, forgot to reassign, reassigning.

Comment 3

[Akkana Peck]

Sounds like the same issue: I'm marking it as a dup.  Someone who's actually
seeing the problem will have to test it.

*** This bug has been marked as a duplicate of 20207 ***

Comment 4

[rubydoo123]

setting milestone

Comment 5

[Braden]

I'm reopening this one instead of bug 20207, based on Akkana's comments on that
bug. And this one seems to most accurately solve the problem.

I'm seeing this now in 2000052920. I'm using this build to reopen this bug, and
the problem ought to manifest itself in this comment. (I expect this comment to
appear "double spaced"--that is not how I have typed it.)

Comment 6

[Braden]

Hm. Crap. It didn't happen that time. It did for the entry I just made to bug
40299. I wonder what will happen with this comment....

Comment 7

[Braden]

<sigh>

Baffling. I'm tempted to close this one up again, but I'll wait and see if
anyone else has run into this.

Comment 8

[Akkana Peck]

Adding to status whiteboard in case PDT is checking dogfood bugs.  Let me know
if you figure out how to reproduce it ...

Comment 9

[Eric Pollmann]

The mysterious doublespacing behaviour only happens when you have to log in 
before you bug edit goes through, this is because in that login page, the line 
feeds are stored in hidden inputs.  This is bug 22983, which is closely related 
to, but not the same as bug 22707.  I think the textarea problems are already 
solved, but I haven't tested it recently!

Comment 10

[leger]

Putting on [dogfood+] radar.  But need a retest...thinks its a WorkforMe

Comment 11

[ckritzer (gone)]

This is a test of the emergency bug regression system
This is only a test.
Should a real emergency have arisen, you would have been instructed on where to
go to grab the most recent build.

Brought to you by the makers of FLURM.

Comment 12

[ckritzer (gone)]

These are additional comments
with single line breaks
before signing in to
bugzilla.
On Linux.

Comment 13

[ckritzer (gone)]

Okay, ignore last comments - they were with my bugzilla login set by cookie.

These comments are pre-login,

no cookie,

supposed to be

no additional

line

breaks.

Comment 14

[ckritzer (gone)]

Bug still exists.

Comment 15

[Eric Pollmann]

Yes, the bug still exists.  It is bug 22983 and it was never fixed.  Please put 
comments about the extra linefeeds, and dogfood status, whatnot on that bug.

Comment 16

[Akkana Peck]

Reassigning to pollmann, who seems to be on top of this.  Would mark as a dup of
22983, but this one now has a dogfood+ attached to it whereas that one doesn't.

Comment 17

[Eric Pollmann]

I think it would be more accurate to transer the dogfood status to the bug this 
was reopened to report.  This bug (Extra trailing CR/LF) is and has been fixed. 
I'll do the dirty deed.  If this is bad, please undo. :)

Comment 18

[leger]

Since other bug is open, marking this Verified.  Sounds cool.