316995 - When migrating from Internet Explorer http auth passwords are not migrated

Status: RESOLVED FIXED

(Firefox :: Migration, enhancement, P3)

Description

[Gennady Feldman]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051118 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051118 Firefox/1.5

When testing IE migration and starting with clean slate I noticed that not all passwords were migrated. I also checked the "saved passwords" dialog and it had no trace of some of the passwords. The passwords that were not migrated are HTTP protocols basic authentication based passwords that I have saved in IE.

Reproducible: Always

Steps to Reproduce:
1. Visit some HTTP protocol password protected site in Internet Explorer.
2. Save the password and then close and open it again to make sure it's saved.
3. Now do a clean install of Firefox 1.5rc3 and do migration from Internet Explorer.
4. Visit the same site with Firefox. It should have the password prefilled?

Actual Results:  
The password is not migrated and not filled in.

Expected Results:  
The password should show up just like it does in Internet Explorer

Comment 1

[Tracy Walker [:tracy]]

Migration and import of passwords seems boken on Win 2k

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Could you try a build from before 2005-10-25? Bug 316634 is about proxy settings no longer being imported after that build, maybe it's related to this bug. Getting a regression range would be helpful :).

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Possibly a regression from bug 313529.

Comment 4

[Jay Patel [:jay]]

Nominating for next release(es) since this might be a regression from mconner's
latest migration code changes. Assigning to him for more investigation.

Comment 5

[Mike Connor [:mconnor]]

Need some testing on this, I can't reproduce.

Comment 6

[Tracy Walker [:tracy]]

This WFM on Win 2K with Bon Echo nightly from 2006-06-06

Comment 7

[Gennady Feldman]

I am still getting problems. I just tried latest nightly:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1a3) Gecko/20060606 BonEcho/2.0a3

created new profile and selected Import under File menu. After selecting Internet Explorer I let it import things. Then I went into Tools->Options Privacy->Passwords and did "Show Passwords" out of list >30 items only 1 password was shown, all others are blank?

Comment 8

[Gennady Feldman]

Ok. I see a list of 30 imported sites/passwords. However only 2 actual passwords are there when I do "Show passwords" button. Also it only prefills the login for those sites whos password wasn't imported. 

Re-opening per conversation w/ tracy.

Comment 9

[Mike Connor [:mconnor]]

-> mwu

Comment 10

[Michael Wu [:mwu]]

The IE migrator checks PStore for its password and form data. HTTP auth saved login data isn't stored there, AFAICT, so the migrator never did this at any point. That's one bug (not regression). The other problem is that many passwords don't actually get migrated, which I'm still looking into. (regression?)

Comment 11

[Michael Wu [:mwu]]

I don't really see any changes in the IE migrator that would cause a regression in password importing. Removing regression keyword for now.

Comment 12

[Mike Connor [:mconnor]]

mwu, is there anything that indicates why this is happening?

Comment 13

[Michael Wu [:mwu]]

(In reply to comment #12)
> mwu, is there anything that indicates why this is happening?
> 
The original bug - HTTP auth passwords not getting imported - is because we don't implement importing that info. It has never worked because that info is not stored in PStore. I'm not sure where it's stored.

Comment #7 and comment #8 suggests that there are other problems with importing passwords, but there's not much to go on besides "a lot of passwords don't import". FWIW, my test logins+passwords imported correctly. I'll take another look at this.

Comment 14

[Mike Schroepfer]

Taking off the list - I don't think we have time for this in FF2

Comment 15

[Michael Wu [:mwu]]

Attachment: Add support for importing HTTP auth passwords from IE

Ok, so I was wrong about http auth info not being stored in PStore. This patch adds support for importing HTTP auth data from IE. It only does HTTP auth for now since FTP is a bit more complicated. (and I don't think that many people know how to login with FTP in firefox)

Comment 16

[Mike Connor [:mconnor]]

Comment on attachment 229907 [details] [diff] [review]
Add support for importing HTTP auth passwords from IE

Good work, thanks!

Comment 17

[Martijn Wargers (dead)]

Checking in nsIEProfileMigrator.cpp;
/cvsroot/mozilla/browser/components/migration/src/nsIEProfileMigrator.cpp,v  <--
  nsIEProfileMigrator.cpp
new revision: 1.40; previous revision: 1.39
done
Checking in nsIEProfileMigrator.h;
/cvsroot/mozilla/browser/components/migration/src/nsIEProfileMigrator.h,v  <--
nsIEProfileMigrator.h
new revision: 1.6; previous revision: 1.5
done

Checked into trunk.

Comment 18

[Michael Wu [:mwu]]

Comment on attachment 229907 [details] [diff] [review]
Add support for importing HTTP auth passwords from IE

This should be fairly safe, and it improves the migration experience quite a lot for users who save http authentication passwords.

Comment 19

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 229907 [details] [diff] [review]
Add support for importing HTTP auth passwords from IE

a=drivers. Please land on the MOZILLA_1_8_BRANCH.

Comment 20

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/migration/src/nsIEProfileMigrator.cpp 	1.29.4.10
mozilla/browser/components/migration/src/nsIEProfileMigrator.h 	1.4.18.2

Comment 21

[Jungshik Shin]

Comment on attachment 229907 [details] [diff] [review]
Add support for importing HTTP auth passwords from IE


>+        nsAutoString tmp(itemName);
>+        tmp.Truncate(6);
>+        if (tmp.Equals(NS_LITERAL_STRING("DPAPI:"))) // often FTP logins
          if (tmp.EqualsLiteral("DPAPI:"))


>+          if (idx) {
>+            realm.Replace(idx, 1, NS_LITERAL_STRING(" ("));
>+            realm.Append(NS_LITERAL_STRING(")"));

              realm.AppendLiteral(")");

>+          pwmgr->AddUser(NS_ConvertUTF16toUTF8(realm),
>+                         NS_ConvertUTF8toUTF16((char *)data),
>+                         NS_ConvertUTF8toUTF16((char *)password));

Are 'data' and 'password' in UTF-8? I doubt they're.  If they're always in ASCII, NS_ConvertASCIItoUTF16 should be used instead. If they're in the default system codepage and contain characters outside the ASCII, they should be converted using NS_CopyNativeToUnicode.

Comment 22

[Jungshik Shin]

(In reply to comment #21)
I'll fix issues raised in the previous comment in bug 352365 along with other similar problems in IE profile migrator.

Comment 23

[Jungshik Shin]

sorry for bug spam.