For example: 2691 DOM_CLASSINFO_MAP_BEGIN(SVGTSpanElement, nsIDOMSVGTSpanElement) 2692 DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGTextPositioningElement) 2693 DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGTextContentElement) 2694 DOM_CLASSINFO_MAP_END should have either DOM_CLASSINFO_SVG_ELEMENT_MAP_ENTRIES or DOM_CLASSINFO_SVG_GRAPHIC_ELEMENT_MAP_ENTRIES added; as things stand it doesn't expose nsIDOM3Node, for example, so its baseURI property is undefined... Should probably check other SVG nodes for similar issues.
Created attachment 203823 [details] [diff] [review] try to get mozilla to match the SVG 1.1 specification I have been through http://www.w3.org/TR/SVG/ and tried to compare it to what we have in this file and this is what I came up with. I think this also fixes bug #313078.
Attachment #203823 - Flags: review?(tor)
Comment on attachment 203823 [details] [diff] [review] try to get mozilla to match the SVG 1.1 specification > DOM_CLASSINFO_MAP_BEGIN(SVGImageElement, nsIDOMSVGImageElement) > DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGImageElement) > DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGURIReference) >- DOM_CLASSINFO_SVG_GRAPHIC_ELEMENT_MAP_ENTRIES >+ DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGStylable) >+ DOM_CLASSINFO_SVG_ELEMENT_MAP_ENTRIES > DOM_CLASSINFO_MAP_END I don't think this change is correct - svg.idl says that <image> is supposed to be transformable. > DOM_CLASSINFO_MAP_BEGIN(SVGMarkerElement, nsIDOMSVGMarkerElement) > DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGMarkerElement) >+ DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGStylable) > DOM_CLASSINFO_SVG_ELEMENT_MAP_ENTRIES > DOM_CLASSINFO_MAP_END Should also have nsIDOMSVGFitToViewBox.
Attachment #203823 - Flags: review?(tor) → review-
Created attachment 203913 [details] [diff] [review] address review comments
Attachment #203913 - Flags: superreview?(bzbarsky) → superreview+
Robert, do you need that checked in?
Boris, I would like this checked in please. You chould also mark bug #313078 fixed once you do this I think.
Assignee: general → longsonr
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.