Classinfo is incorrect for some SVG nodes

RESOLVED FIXED

Status

()

Product:
Core
Component:
SVG
Status:
RESOLVED FIXED
Reported:
14 years ago
Modified:
12 years ago

People

(Reporter: bzbarsky, Assigned: longsonr)

Tracking

Version:
Trunk
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

address review comments
9.34 KB, patch
tor
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

•
14 years ago 
For example:

2691   DOM_CLASSINFO_MAP_BEGIN(SVGTSpanElement, nsIDOMSVGTSpanElement)
2692     DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGTextPositioningElement)
2693     DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGTextContentElement)
2694   DOM_CLASSINFO_MAP_END

should have either DOM_CLASSINFO_SVG_ELEMENT_MAP_ENTRIES or DOM_CLASSINFO_SVG_GRAPHIC_ELEMENT_MAP_ENTRIES added; as things stand it doesn't expose nsIDOM3Node, for example, so its baseURI property is undefined...

Should probably check other SVG nodes for similar issues.
 (Reporter)

Updated

•
14 years ago
Blocks: 316959
 (Assignee)

Comment 1

•
14 years ago 
I have been through http://www.w3.org/TR/SVG/ and tried to compare it to what we have in this file and this is what I came up with.

I think this also fixes bug #313078.
Attachment #203823 - Flags: review?(tor)

Comment 2

•
14 years ago 
Comment on attachment 203823 [details] [diff] [review]
try to get mozilla to match the SVG 1.1 specification

>   DOM_CLASSINFO_MAP_BEGIN(SVGImageElement, nsIDOMSVGImageElement)
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGImageElement)
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGURIReference)
>-    DOM_CLASSINFO_SVG_GRAPHIC_ELEMENT_MAP_ENTRIES
>+    DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGStylable)
>+    DOM_CLASSINFO_SVG_ELEMENT_MAP_ENTRIES
>   DOM_CLASSINFO_MAP_END

I don't think this change is correct - svg.idl says that <image> is supposed to be transformable.

>   DOM_CLASSINFO_MAP_BEGIN(SVGMarkerElement, nsIDOMSVGMarkerElement)
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGMarkerElement)
>+    DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGStylable)
>     DOM_CLASSINFO_SVG_ELEMENT_MAP_ENTRIES
>   DOM_CLASSINFO_MAP_END

Should also have nsIDOMSVGFitToViewBox.
Attachment #203823 - Flags: review?(tor) → review-
 (Assignee)

Comment 3

•
14 years ago 

        Attachment #203823 -
        Attachment is obsolete: true

        Attachment #203913 -
        Flags: superreview?(bzbarsky)

        Attachment #203913 -
        Flags: review?(tor)

    

      

        



        		
        
        
        

          
        

      

      

        
          

            Updated
          

          •
          
14 years ago
          

        		
      

    

  

        Attachment #203913 -
        Flags: review?(tor) → review+

    

      

        



        		
        
            (Reporter)
        
        

          
        

      

      

        
          

            Updated
          

          •
          
14 years ago
          

        		
      

    

  

        Attachment #203913 -
        Flags: superreview?(bzbarsky) → superreview+

    
    

      

        



        		

        
            (Reporter)
        

        

          
        

      


      

        
          

            Comment 4
          

          •
          
14 years ago
          

        		
      


      

        
        
      

    


    
  
Robert, do you need that checked in?

    
    

      

        



        		

        
            (Assignee)
        

        

          
        

      


      

        
          

            Comment 5
          

          •
          
14 years ago
          

        		
      


      

        
        
      

    


    
  
Boris,

I would like this checked in please. 

You chould also mark bug #313078 fixed once you do this I think.

    

      

        



        		
        
            (Reporter)
        
        

          
        

      

      

        
          

            Updated
          

          •
          
14 years ago
          

        		
      

    

  
Assignee: general → longsonr
Blocks: 313078

    
    

      

        



        		

        
            (Reporter)
        

        

          
        

      


      

        
          

            Comment 6
          

          •
          
14 years ago
          

        		
      


      

        
        
      

    


    
  
Checked in.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

    

      

        



        		
        
        
        

          
        

      

      

        
          

            Updated
          

          •
          
12 years ago
          

        		
      

    

  
Flags: in-testsuite?

          You need to log in
          before you can comment on or make changes to this bug.