317469 - need better UIDs for ICS items

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Right now, various parts of the code are using things like date strings as pseudo UIDs for ICS items.  We need to do something that's more likely to actually be unique.  We could use the recently landed nsIUUIDGenerator from bug 279521.  However, that's not going to exist in (eg) Thunderbird 1.5 branch builds, so we might do better off just following the recommendations in 4.8.4.7 of RFC 245, or perhaps even just following the "how to generate a message-id" document that jwz wrote at some point.

Comment 1

[Mike Shaver (:shaver emeritus)]

Unfortunately, I do not have cycles to work on Calendar stuff these days (just as it's getting to the good part!), so I am a bad owner for these bugs.  To delete the tragically-large chunk of bugspam, search for gregorianabdication.

Comment 2

[Joey Minta]

Attachment: use uuidgenerator, when present

nsIUUIDGenerator exists on the 1.8.1 branch and on trunk, but didn't ship with Lightning 1.5, so we have to if check.  But for 2.0 and beyond, this will give us much better uuids.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 229200 [details] [diff] [review]
use uuidgenerator, when present

This has "helper function" written all over it...

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 229200 [details] [diff] [review]
use uuidgenerator, when present

This has "helper function" written all over it...

Comment 5

[Joey Minta]

(In reply to comment #4)
> (From update of attachment 229200 [details] [diff] [review] [edit])
> This has "helper function" written all over it...
> 
Aren't components in their own scope?  The helper function would still have to be copied.

Comment 6

[Joey Minta]

Attachment: uuid's with a helper

Creates a helper function to check whether we have the uuidgenerator service.  We use that when possible.

Comment 7

[Joey Minta]

Comment on attachment 230439 [details] [diff] [review]
uuid's with a helper

r=dmose

Comment 8

[Joey Minta]

patch checked in.