Closed Bug 317868 Opened 14 years ago Closed 14 years ago

minimonth and timepicker should be scrollable

Categories

(Calendar :: Internal Components, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jminta, Assigned: jminta)

Details

Attachments

(1 file, 2 obsolete files)

I had a friend over using my computer last week.  She'd never used Linux before but intuitively assumed that using the scrollwheel on the mini-calendar display in the system tray would change the displayed month.  We should implement this feature, especially in the minimonth, to cut down on the number of clicks necessary to move the displayed month.
Attached patch implement scrolling (obsolete) — Splinter Review
Implements scrolling in all of our date and time widgets.
Assignee: base → jminta
Status: NEW → ASSIGNED
Attachment #204226 - Flags: first-review?(mvl)
I just tested this patch and have to admit that I really like the scrolling functionality in the minimonth / date picker to change to the next/prev. month.

But in the time picker the scrolling functionality (as implemented by this patch) seems to be for nothing. Yes, I can scroll in the time picker and the new field is highlighted; but I (or the user) still have to click on the hour/minute field to select and save it. 

If the selected time would be updated while scrolling (allowing open time picker - scroll - close time picker action) this would be great.
Comment on attachment 204226 [details] [diff] [review]
implement scrolling

removing review request to take up ssitter's comment
Attachment #204226 - Attachment is obsolete: true
Attachment #204226 - Flags: first-review?(mvl)
Attached patch implement scrolling v2 (obsolete) — Splinter Review
Updated to reflect ssitter's comment.  Scrolling in the timepicker now dynamically updates the textbox.  Scrolling the month does not update the textbox because the selection does not carry over.
Attachment #204280 - Flags: first-review?(mvl)
The previous version didn't fire a 'change' event if the time had been adjusted via a scroll.  This patch fixes that, by routing all changes involving the grid through the 'onpopuphiding' event.
Attachment #204280 - Attachment is obsolete: true
Attachment #204289 - Flags: first-review?(mvl)
Attachment #204280 - Flags: first-review?(mvl)
Comment on attachment 204289 [details] [diff] [review]
implement scrolling v3

r=mvl
Attachment #204289 - Flags: first-review?(mvl) → first-review+
patch checked in
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.