317868 - minimonth and timepicker should be scrollable

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Joey Minta]

I had a friend over using my computer last week.  She'd never used Linux before but intuitively assumed that using the scrollwheel on the mini-calendar display in the system tray would change the displayed month.  We should implement this feature, especially in the minimonth, to cut down on the number of clicks necessary to move the displayed month.

Comment 1

[Joey Minta]

Attachment: implement scrolling

Implements scrolling in all of our date and time widgets.

Comment 2

[Stefan Sitter [:ssitter]]

I just tested this patch and have to admit that I really like the scrolling functionality in the minimonth / date picker to change to the next/prev. month.

But in the time picker the scrolling functionality (as implemented by this patch) seems to be for nothing. Yes, I can scroll in the time picker and the new field is highlighted; but I (or the user) still have to click on the hour/minute field to select and save it. 

If the selected time would be updated while scrolling (allowing open time picker - scroll - close time picker action) this would be great.

Comment 3

[Joey Minta]

Comment on attachment 204226 [details] [diff] [review]
implement scrolling

removing review request to take up ssitter's comment

Comment 4

[Joey Minta]

Attachment: implement scrolling v2

Updated to reflect ssitter's comment.  Scrolling in the timepicker now dynamically updates the textbox.  Scrolling the month does not update the textbox because the selection does not carry over.

Comment 5

[Joey Minta]

Attachment: implement scrolling v3

The previous version didn't fire a 'change' event if the time had been adjusted via a scroll.  This patch fixes that, by routing all changes involving the grid through the 'onpopuphiding' event.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 204289 [details] [diff] [review]
implement scrolling v3

r=mvl

Comment 7

[Joey Minta]

patch checked in