318043 - l10n repackaging of MacOS DMG doesn't repackage the drive icon

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

From bug 283598 comment 56 : when the l10n builds of Firefox are repackaged, the custom drive icon is not repackaged. According to mento all the commands appear to be running properly during the repackaging process, but the "custom-icon" bit isn't set on the repackaged DMG. This may be something peculiar to the repackaging build machine.

See http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/installer/packager.mk#146
and
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/installer/packager.mk#117

This is a minor polish bug that does not block the localized 1.5 release, but we should try and figure out what's going on for the 1.5.0.x releases.

Comment 1

[Chase Phillips]

Mass reassign of open bugs for [e-mail] to [e-mail].

Comment 2

[Hiro]

*** Bug 316171 has been marked as a duplicate of this bug. ***

Comment 3

[J. Paul Reed [:preed]]

Moving to Firefox for the 1.5.0.3 release.

Comment 4

[J. Paul Reed [:preed]]

We should fix this for 1.5.0.3, especially since it should be an easy fix, and suggests bogosity in the l10n build machine.

We should check if this is still the case for the new universal binary builds, which are built on a freshly installed machine.

Rob: can you check up on this?

Comment 5

[Mark Mentovai]

1.5.0.2 hu uni has custom icon bit set and the proper volume icon appears.  http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/1.5.0.2/mac/hu/

Comment 6

[Hiro]

(In reply to comment #5)
> 1.5.0.2 hu uni has custom icon bit set and the proper volume icon appears. 
> http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/1.5.0.2/mac/hu/
> 

The Mac version doesn't have the problem either. 
http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/1.5.0.2/mac/ja-JP-mac/Firefox%201.5.0.2.dmg

Comment 7

[Daniel Veditz [:dveditz]]

Will look at patches, but UI polish won't hold the release.

Comment 8

[Mark Mentovai]

This shouldn't be a problem any longer, now that releases are being produced by tinderboxes in proper repair.  I just checked localized builds of Firefoxes 1.5.0.4 and 2b1 and both show the custom volume icon.