319163 - vertical writing does not work in SVG

Status: RESOLVED FIXED

Description

[Ivan Herman]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

The title and the SVG file tells it all...

Reproducible: Always

Comment 1

[Justin Kerk]

Dupe of bug 145503 I think.

Comment 2

[Robert Longson [:longsonr]]

*** Bug 360689 has been marked as a duplicate of this bug. ***

Comment 3

[Takeshi Kurosawa]

*** Bug 330082 has been marked as a duplicate of this bug. ***

Comment 5

[Jonathan Watt [:jwatt] (needinfo? me)]

This bug blocks us from passing at least the following tests from the W3C SVG 1.1 Full testsuite:

http://www.w3.org/Graphics/SVG/Test/20061213/htmlObjectHarness/full-text-align-05-b.html
http://www.w3.org/Graphics/SVG/Test/20061213/htmlObjectHarness/full-text-align-06-b.html

Comment 6

[Jonathan Watt [:jwatt] (needinfo? me)]

And:

http://www.w3.org/Graphics/SVG/Test/20061213/htmlObjectHarness/full-text-intro-03-b.html

Comment 7

[Gérard Talbot]

Created attachment 8515419 [details]
Minimized test with <g writing-mode="tb" glyph-orientation-vertical="0">

Test emulates 'text-orientation: upright'. 
Opera 12.16 and Chrome 38.0.2125.111 pass this test. 
Firefox 33 fails this test.

Comment 8

[Gérard Talbot]

Created attachment 8515420 [details]
Minimized test with <g writing-mode="tb">

Test emulates 'text-orientation: sideways-right'.
Opera 12.16 and Chrome 38.0.2125.111 pass this test. 
Firefox 33 fails this test.

Comment 9

[Jonathan Kew (:jfkthame)]

Note that we do partially support vertical text in SVG if you use CSS styling with writing-mode:vertical-{lr,rl} in place of the SVG writing-mode attribute.

I say "partially" because in a trivial testcase, I see at least one problem: although the text renders vertically, we treat it as though its bounding rect were still horizontal, and therefore it's impossible to select more than the first character or two of the line (i.e. within the bounds of the imaginary horizontal line).

Comment 10

[Jonathan Kew (:jfkthame)]

And CSS text-orientation:upright seems to fail altogether: the text disappears.

Comment 11

[Cameron McCormack (:heycam)]

Do we want to get vertical text in SVG working before turning the pref on?  Or should we explicitly disable those properties for SVG text until we do support it?

Comment 12

[Robert Longson [:longsonr]]

I don't see the text disappearing with text-orientation:upright (although I'm testing with the patch in bug 1153510 applied). I can't select the last character of the text with text-orientation:upright though.

Comment 13

[Jonathan Kew (:jfkthame)]

(In reply to Cameron McCormack (:heycam) from comment #11)
> Do we want to get vertical text in SVG working before turning the pref on? 
> Or should we explicitly disable those properties for SVG text until we do
> support it?

I'd be willing to turn the pref on without SVG support, but I think we're close enough that the issue needn't arise; with just a couple of small fixes, it'll be usable enough to ship.

One question I have is whether we should try to map the SVG writing-mode and glyph-orientation attributes to the CSS properties that we're implementing, or are we going to tell authors that we only support vertical text via the CSS route?

(In reply to Robert Longson from comment #12)
> I don't see the text disappearing with text-orientation:upright (although
> I'm testing with the patch in bug 1153510 applied). I can't select the last
> character of the text with text-orientation:upright though.

Agreed, with that patch the "disappearing" problem seems to be gone. Additional comments in bug 1153510.

Comment 14

[Cameron McCormack (:heycam)]

(In reply to Jonathan Kew (:jfkthame) from comment #13)
> I'd be willing to turn the pref on without SVG support, but I think we're
> close enough that the issue needn't arise; with just a couple of small
> fixes, it'll be usable enough to ship.

That sounds good then, let's get it working in time for the preffing on.

> One question I have is whether we should try to map the SVG writing-mode and
> glyph-orientation attributes to the CSS properties that we're implementing,
> or are we going to tell authors that we only support vertical text via the
> CSS route?

Support for SVG 1.1's writing-mode/glyph-orientation-{horizontal,vertical} properties are is spotty enough across other implementations that we should just move ahead with supporting CSS' writing-mode/text-orientation properties.  In the SVG 2 spec we'll be removing SVG's definitions and referencing the CSS properties.

Comment 15

[Robert Longson [:longsonr]]

The dependencies are all fixed now. vertical writing-mode is supported. The SVG testsuite tests don't work that well as they use a mapped glyph-orientation which has been dropped from SVG 2 in favour of unmapped text-orientation.