bug_email.pl fails if qa_contact specified in email

RESOLVED WORKSFORME

Status

()

Bugzilla
Creating/Changing Bugs
RESOLVED WORKSFORME
13 years ago
11 years ago

People

(Reporter: Gabriel Hernandez, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1)
Build Identifier: 2.20

While upgrading from version 2.18 to 2.20 we discovered the bug_email.pl script fails if an eamil is submitted that specifies the qa_contact.  We discovered the following line in bug_email.pl is no longer valid:

$Control{'qa_contact'} = DBname_to_id($Control{'qa_contact'});

This line should now read:

$Control{'qa_contact'} = DBNameToIdAndCheck($Control{'qa_contact'});

The DBname_to_id no longer exists in version 2.20.  It has been updated to the module called DBNameToIdAndCheck.

Reproducible: Always

Steps to Reproduce:
1.Send email to Bugzilla instance specifying QA Contact ("@qa_contact=some_name")
2.Nothing happens

Actual Results:  
Nothing happens

Expected Results:  
A Bug is created with a QA Contact specified

None

Comment 1

13 years ago
The qa_contact field should work the same way as the assigned_to field. Using DBNameToIdAndCheck() is a bad idea as it would throw an error instead of writing the error message in an email.
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Comment 2

13 years ago
(In reply to comment #1)
> The qa_contact field should work the same way as the assigned_to field. Using
> DBNameToIdAndCheck() is a bad idea as it would throw an error instead of
> writing the error message in an email.

I'm fine with processing the qa_contact as the subject matter experts deem appropriate.  The pressing issue is that bug_email.pl fails if qa_contact is specified in the email.  The example I provided restores functionality.  If that should NOT be the permanent fix, I'm happy to implement the patch you feel does the job better.

Comment 3

13 years ago
Feel free to submit a patch, I will look at it. Do not forget to request review (review?)
(Reporter)

Comment 4

13 years ago
Sorry, I am not much of a developer.  The example I provided in the original submission was only available to me with the help of a very knowledgeable UNIX admin who works with me.

Updated

13 years ago
Blocks: 322955

Comment 5

11 years ago
Created attachment 288855 [details] [diff] [review]
gabriel's idea as a patch
Attachment #288855 - Flags: review?(LpSolit)

Comment 6

11 years ago
Comment on attachment 288855 [details] [diff] [review]
gabriel's idea as a patch

bug_email.pl no longer exists and has been replaced by email_in.pl on Bugzilla 3.x. Bugzilla 2.20.x and 2.22.x are restricted to security bugs and crashers.
Attachment #288855 - Flags: review?(LpSolit) → review-

Comment 7

11 years ago
AFAICS, this bug is no longer valid in email_in.pl.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.