319627 - Cmd-drag a bookmark folder should append, not replace

Status: RESOLVED FIXED

(Camino Graveyard :: Drag & Drop, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Cmd is our toggle for selecting append rather than replace for "open in tabs" and so forth.

Dragging a folder to the content area/tab widget should replace (to be consistent with the default for "open in tabs" and so forth), but we should allow cmd-drag to toggle this to append here, too.

Comment 1

[Chris Lawson (gone)]

I'll look into this for 1.6. This *probably* won't be too hard.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mass un-setting milestone per 1.6 roadmap.

Filter on RemoveRedonkulousBuglist to remove bugspam.

Developers: if you have a patch in hand for one of these bugs, you may pull the bug back to 1.6 *at that point*.

Comment 3

[Chris Lawson (gone)]

Things to test when reviewing a patch for this bug:

1) Dragging a folder to the foreground tab widget.
2) Dragging a folder to a background tab widget.
3) Dragging a folder to the empty space in the tab bar.
4) Dragging a folder to the content area.

The above tests should all be repeated with the Command key held down.

All of the above tests should then be repeated for tab groups and single bookmarks.

I'll have a patch up shortly.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

And with Shift held down, and Command and Shift held down....

Comment 5

[Chris Lawson (gone)]

Attachment: fix v1.0

This fixes the tab case.

Right now, Gecko doesn't like to handle the dropping of *anything* on the content area where n > 1. You don't get append *or* replace when you drop a folder on the content area -- just a rejected drag.

I dunno if we want to keep this bug open and fix the tab part for now, or if we want to worry about all of it at once later.

Comment 6

[Chris Lawson (gone)]

Comment on attachment 337510 [details] [diff] [review]
fix v1.0

Murph, care to take a look at this? This fixes 1-3 in comment 3; 4 can't be fixed at the moment without some Gecko back-end work (which I'm pretty sure is filed elsewhere).

Comment 7

[Sean Murphy]

Comment on attachment 337510 [details] [diff] [review]
fix v1.0

r=murph

Comment 8

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 337510 [details] [diff] [review]
fix v1.0

sr=pink

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.

I think we need at least a placeholder bug to remind us of the things to check in the event Gecko ever handles drags with multiple URLs.

Comment 10

[Chris Lawson (gone)]

(In reply to comment #9)
> Landed on cvs trunk.
> 
> I think we need at least a placeholder bug to remind us of the things to check
> in the event Gecko ever handles drags with multiple URLs.

Filed as bug 461091.