31981 - Change EnableRefresh(NS_VMREFRESH_IMMEDIATE) to NS_VMREFRESH_NO_SYNC

Status: RESOLVED INCOMPLETE

(Core :: Web Painting, defect, P4)

Description

[Kevin McCluskey (gone)]

All of the following places should probably change from passing 
NS_VMREFRESH_IMMEDIATE to  NS_VMREFRESH_NO_SYNC.  The NS_VMREFRESH_IMMEDIATE 
will cause  immediate  processing of a paint event if the timeout has expired. 
This is probably not what we want happening in these locations because it will 
often cause painting when there isn't any content. If they are changed to 
NS_VMREFRESH_NO_SYNC the painting will occur when the app gets back to the 
message pump.

S:\mozilla\webshell\src\nsWebShell.cpp(3211):          
vm->EnableRefresh(NS_VMREFRESH_IMMEDIATE);

S:\mozilla\layout\base\src\nsDocumentViewer.cpp(506):        
mViewManager->EnableRefresh(NS_VMREFRESH_IMMEDIATE);

S:\mozilla\layout\base\src\nsDocumentViewer.cpp(801):      
mViewManager->EnableRefresh(NS_VMREFRESH_IMMEDIATE);

S:\mozilla\layout\html\document\src\nsHTMLContentSink.cpp(3248):        
vm->EnableRefresh(NS_VMREFRESH_IMMEDIATE);

S:\mozilla\layout\html\document\src\nsImageDocument.cpp(315):        
vm->EnableRefresh(NS_VMREFRESH_IMMEDIATE);

S:\mozilla\layout\xml\document\src\nsXMLContentSink.cpp(1872):        
vm->EnableRefresh(NS_VMREFRESH_IMMEDIATE);

Comment 1

[travis]

Hmmmm, I'm not sure why this was given to me. I don't really own most of these 
callsites.  I can change them, but I don't really know what to watch out for in 
terms of problems etc.

Comment 2

[Kevin McCluskey (gone)]

*** Bug 29310 has been marked as a duplicate of this bug. ***

Comment 3

[Dawn Endico]

Reassigning all travis bugs to Valeski for triage. Don thought these were
all docshell related. Travis is no longer at netscape so these bugs are
unowned.

I'm reassigning 23 bugs to Valeski right now. To search for them,
search for "BUGSFORMERLYKNOWNASTRAVIS" in the description. The url below 
should work.

http://bugzilla.mozilla.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&email1=&emailtype1=substring&emailassigned_to1=1&email2=&emailtype2=substring&emailreporter2=1&bugidtype=include&bug_id=&changedin=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&short_desc=&short_desc_type=substring&long_desc=BUGSFORMERLYKNOWNASTRAVIS&long_desc_type=substring&bug_file_loc=&bug_file_loc_type=substring&status_whiteboard=&status_whiteboard_type=substring&keywords=&keywords_type=anywords&field0-0-0=noop&type0-0-0=noop&value0-0-0=&cmdtype=doit&newqueryname=&order=Reuse+same+sort+as+last+time

Comment 4

[Judson Valeski]

over to adam lock who's recently been playing w/ painting stuff on the periphery.

Comment 5

[Adam Lock]

Search on LXR reveals that NS_VMREFRESH_IMMEDIATE is set in these places

/content/base/src/nsDocumentViewer.cpp, line 1006 -- 
mViewManager->EnableRefresh(NS_VMREFRESH_IMMEDIATE);
/content/base/src/nsDocumentViewer.cpp, line 3642 -- 
mViewManager->EnableRefresh(NS_VMREFRESH_IMMEDIATE);
/content/html/document/src/nsImageDocument.cpp, line 421 -- 
vm->EnableRefresh(NS_VMREFRESH_IMMEDIATE);
/content/xml/document/src/nsXMLContentSink.cpp, line 1782 -- 
vm->EnableRefresh(NS_VMREFRESH_IMMEDIATE);
/content/xul/document/src/nsXULDocument.cpp, line 3885 -- 
vm->EnableRefresh(NS_VMREFRESH_IMMEDIATE);

Comment 6

[Adam Lock]

I am reassigning given the nature of where these calls are occurring.

Most appear related to StartLayout or new window operations where the intent is 
to paint something immediately even when there is no content yet.

Comment 7

[Kevin McCluskey (gone)]

Build moving all existing future-P3 bugs to future-P4.

Comment 8

[Timothy Nikkel (:tnikkel)]

EnableRefresh, NS_VMREFRESH_IMMEDIATE, and NS_VMREFRESH_NO_SYNC are all gone now, hooray! So this bug doesn't even make sense anymore.