Closed Bug 319922 Opened 19 years ago Closed 18 years ago

Context menu for a tab with Bookmarks Manager or History has "Reload Tab" option

Categories

(Camino Graveyard :: Tabbed Browsing, defect)

Product:
Camino Graveyard
Component:
Tabbed Browsing
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Camino1.5

People

(Reporter: froodian, Assigned: froodian)

References

Details

(Keywords: fixed1.8.1, Whiteboard: [Good First Bug])

Attachments

(1 obsolete file) 

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051211 Camino/1.0b1+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051211 Camino/1.0b1+

With the bookmarks manager or history loaded in a tab, the context manu for that tab will have "Reload Tab" enabled, even though the reload button in the toolbar is disabled.  Choosing the option has no ill effects, but it's unecessary.

Reproducible: Always

Steps to Reproduce:
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Camino1.2
Whiteboard: [Good First Bug]
Assignee: mikepinkerton → nobody
Blocks: 328173
OS: Mac OS X 10.2 → Mac OS X 10.3
QA Contact: tabbed.browsing
Blocks: 341853
Assignee: nobody → stridey
Attached patch Patch (obsolete) — — Splinter Review 
This also fixes the (unfiled) issue that Reload All Tabs shouldn't be enabled unless there's more than one tab.

For anybody following allong in bug 181978, yes, the second issue will still be relevant.
Attachment #226848 - Flags: review?(bugzilla)
Comment on attachment 226848 [details] [diff] [review]
Patch

r=me on the code, but I haven't actually tested the patch yet.

cl
Attachment #226848 - Flags: review?(bugzilla) → review+
Attachment #226848 - Flags: review?(mozilla)
The fix for this is in bug 342594 to avoid clobbering myself.  Sorry for the wasted r, cl.
Status: NEW → ASSIGNED
Depends on: 342594
Attachment #226848 - Attachment is obsolete: true
Attachment #226848 - Flags: review?(mozilla) → review?
Attachment #226848 - Flags: review?
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Moving fixed "1.2" bugs to 1.1 where they were really fixed. Filter on CaminoFixed1.1 for bugmail purposes.
Target Milestone: Camino1.2 → Camino1.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: