320117 - Syntax Error in chrome://editor/content/EdInsertTOC.js

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Bob Clary [:bc] (inactive)]

Thunderbird 1.5 rc2

Error: syntax error
Source File: chrome://editor/content/EdInsertTOC.js
Line: 347, Column: 4
Source Code:
    else {

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Looks like it's caused by:
http://lxr.mozilla.org/seamonkey/source/editor/ui/dialogs/content/EdInsertTOC.js#298

Comment 2

[Ray Booysen]

I'll take this and submit a patch tonight.

Comment 3

[Bob Clary [:bc] (inactive)]

Ok. we need this for the 1.8 branch as well.

Comment 4

[Ray Booysen]

Seperate patches for trunk and the 1.8 branch?

Comment 5

[Bob Clary [:bc] (inactive)]

The same patch will probably apply to both. We just need to get approval for branch check in I think.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Caused by the patch from bug 121495 (revision comment refers to the wrong bug #). Rather unfortunate that it's been this way on the trunk since 2004-04-15.

Comment 7

[Ray Booysen]

Attachment: Patch removes an extra }

Patch fixes the extra } in the line.

Comment 8

[Erik Fabert]

Why not use some of the tricks the DOM implementation has learnt over the last few years? Simply setting toc.textContent = "" should do the same as the loop.

Comment 9

[Ray Booysen]

Thanks, but I'll wait until someone reviews the patch before changing it. :)

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 205731 [details] [diff] [review]
Patch removes an extra }

A change like this doesn't require super-review. I can check it in on the trunk later today, if no one else does.

Comment 11

[Ray Booysen]

Great, thanks.  I haven't got checkin privs so if you can, that would be great.

Comment 12

[Mike Schroepfer]

Scott - where do you want this to land?

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Landed on the trunk.
mozilla/editor/ui/dialogs/content/EdInsertTOC.js; new revision: 1.3;

Comment 14

[Bob Clary [:bc] (inactive)]

This should land on the appropriate 1.8 branch so that Thunderbird 1.5 can have it as well.

Comment 15

[Scott MacGregor]

it's too late for thunderbird 1.5, we have bits in hand. Will have to wait for 1.5.0.1 unless we are forced to respin.

Comment 16

[Scott MacGregor]

Comment on attachment 205731 [details] [diff] [review]
Patch removes an extra }

schrep delegates this to me. We'll want this for tbird 1.5.0.1 so approving for that branch.

Comment 17

[:Gavin Sharp [email: [e-mail]]]

Checked in on the MOZILLA_1_8_0_BRANCH.
mozilla/editor/ui/dialogs/content/EdInsertTOC.js; new revision: 1.2.36.1;

Comment 18

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 205731 [details] [diff] [review]
Patch removes an extra }

I guess this should land on the 1.8 branch as well?

Comment 19

[Scott MacGregor]

Comment on attachment 205731 [details] [diff] [review]
Patch removes an extra }

yes it should.

Comment 20

[:Gavin Sharp [email: [e-mail]]]

Landed on the MOZILLA_1_8_BRANCH as well. mozilla/editor/ui/dialogs/content/EdInsertTOC.js; new revision: 1.2.28.1;