Syntax Error in chrome://editor/content/EdInsertTOC.js

RESOLVED FIXED

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: bc, Assigned: Ray Booysen)

Tracking

({fixed1.8.0.2, fixed1.8.1})

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
Thunderbird 1.5 rc2

Error: syntax error
Source File: chrome://editor/content/EdInsertTOC.js
Line: 347, Column: 4
Source Code:
    else {
Looks like it's caused by:
http://lxr.mozilla.org/seamonkey/source/editor/ui/dialogs/content/EdInsertTOC.js#298
(Assignee)

Comment 2

12 years ago
I'll take this and submit a patch tonight.
Status: NEW → ASSIGNED
(Assignee)

Updated

12 years ago
Assignee: mscott → bugzilla.mozilla
Status: ASSIGNED → NEW
(Reporter)

Comment 3

12 years ago
Ok. we need this for the 1.8 branch as well.
(Assignee)

Comment 4

12 years ago
Seperate patches for trunk and the 1.8 branch?
(Reporter)

Comment 5

12 years ago
The same patch will probably apply to both. We just need to get approval for branch check in I think.
Caused by the patch from bug 121495 (revision comment refers to the wrong bug #). Rather unfortunate that it's been this way on the trunk since 2004-04-15.
(Assignee)

Comment 7

12 years ago
Created attachment 205731 [details] [diff] [review]
Patch removes an extra }

Patch fixes the extra } in the line.
Attachment #205731 - Flags: review?(bienvenu)
Attachment #205731 - Flags: approval1.8.0.1?

Comment 8

12 years ago
Why not use some of the tricks the DOM implementation has learnt over the last few years? Simply setting toc.textContent = "" should do the same as the loop.
(Assignee)

Comment 9

12 years ago
Thanks, but I'll wait until someone reviews the patch before changing it. :)

Updated

12 years ago
Attachment #205731 - Flags: review?(bienvenu) → review+
(Assignee)

Updated

12 years ago
Attachment #205731 - Flags: superreview?(mscott)
Comment on attachment 205731 [details] [diff] [review]
Patch removes an extra }

A change like this doesn't require super-review. I can check it in on the trunk later today, if no one else does.
Attachment #205731 - Flags: superreview?(mscott)
(Assignee)

Comment 11

12 years ago
Great, thanks.  I haven't got checkin privs so if you can, that would be great.

Updated

12 years ago
Depends on: 121495
Whiteboard: [checkin needed]

Comment 12

12 years ago
Scott - where do you want this to land?
Landed on the trunk.
mozilla/editor/ui/dialogs/content/EdInsertTOC.js; new revision: 1.3;
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]
(Reporter)

Comment 14

12 years ago
This should land on the appropriate 1.8 branch so that Thunderbird 1.5 can have it as well.

Comment 15

12 years ago
it's too late for thunderbird 1.5, we have bits in hand. Will have to wait for 1.5.0.1 unless we are forced to respin.

Comment 16

12 years ago
Comment on attachment 205731 [details] [diff] [review]
Patch removes an extra }

schrep delegates this to me. We'll want this for tbird 1.5.0.1 so approving for that branch.
Attachment #205731 - Flags: approval1.8.0.1? → approval1.8.0.1+
Checked in on the MOZILLA_1_8_0_BRANCH.
mozilla/editor/ui/dialogs/content/EdInsertTOC.js; new revision: 1.2.36.1;
Keywords: fixed1.8.0.1
Comment on attachment 205731 [details] [diff] [review]
Patch removes an extra }

I guess this should land on the 1.8 branch as well?
Attachment #205731 - Flags: approval1.8.1?

Comment 19

12 years ago
Comment on attachment 205731 [details] [diff] [review]
Patch removes an extra }

yes it should.
Attachment #205731 - Flags: approval1.8.1? → approval1.8.1+
Landed on the MOZILLA_1_8_BRANCH as well. mozilla/editor/ui/dialogs/content/EdInsertTOC.js; new revision: 1.2.28.1;
Keywords: fixed1.8.1
Blocks: 121495
No longer depends on: 121495

Updated

11 years ago
Keywords: fixed1.8.0.1 → fixed1.8.0.2
You need to log in before you can comment on or make changes to this bug.