320189 - "new mail sound dialog" usability issues

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Patrick Zesar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: version 1.5 (20051201) - RC2

The "new mail sound"-dialog needs usability polish:

1) When selecting a custom .wav-file, the "use system new mail sound"-radiobutton is still selected (it shouldn't be possible to enter the filechooser with the first RB selected anyway)
2) When returning from 1), the Preview Sound Button does not work, although a custom file is selected correctly - preview only works, when frist choosing the "custom wav"-RB

Proposed fix:
When the RB for "system new mail sound" is selected, deactivate the "Browse" and "Preview"-Buttons - this seems to be the most obvious fix that goes along with the behaviour of the other dialogs i think

Another possibility would be to automatically select the 2nd radiobutton when successfully returning from the filechooser AND fixing the preview-button to work. But from a usability point of view, i think the first suggestion is better.

Reproducible: Always

Steps to Reproduce:
1. Open the "New Mail Sound"-Dialog

Actual Results:  
Dialog behaves as described above

Expected Results:  
Dialog should behave as described above

Comment 1

[Adam Guthrie]

beltzer, what do you think about implementing Patrick's first proposed fix?

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Indeed. The first proposed fix is the right solution. Produce a patch?

Comment 3

[Žiga Sancin]

Attachment: sound check

In addition to the usability issues, I've also cleaned up the notification.js file a bit (at least I think so :)) and made a small change to the logic in the general tab (the "advanced..." button should be disabled, if the "play sound" checkbox isn't selected). Oh, and I've added wav filtering to the file picker.

Comment 4

[Žiga Sancin]

Attachment: slightly smaller sound check

Comment 5

[Adam Guthrie]

Thanks for taking this, Ziga!

Comment 6

[Scott MacGregor]

Comment on attachment 214503 [details] [diff] [review]
slightly smaller sound check

This looks good to me and worked well. I'll check it in once the branch opens again.

Comment 7

[Žiga Sancin]

Actually, I don't have enough privileges to assign bugs to myself or do anything else in bugzilla (ok, except adding patches, lol). So, thanks Adam! :)
Oh, and thanks Scott for the review&chicken. yummi yummi ;)

Comment 8

[Adam Guthrie]

*** Bug 329417 has been marked as a duplicate of this bug. ***