Gecko has a pref to control what happens when you hit backspace key when a textarea is not focused (go back, page down, nothing). Camino doesn't respect this pref, and it should. This *should* be an easy way to once and for all end the contention between the "go back" faction and the "do nothing" faction ;)
We're going to need to patch one of the prefs files, but I'm not sure how we want to handle it. My initial instinct is to patch http://lxr.mozilla.org/mozilla/source/camino/resources/application/all-camino.js but the other option would be http://lxr.mozilla.org/mozilla/source/xpfe/bootstrap/browser-prefs.js Otherwise, I should be able to get this taken care of shortly. cl
Don't we have to remove the hard-coded behavior, too? I'd reckon we put the default (i.e., backspace goes back) in all-camino.js.
(In reply to comment #2) > Don't we have to remove the hard-coded behavior, too? Yeah. I've got it patched for the 0 and >1 cases, but not for 1 (PgDn/PgUp) yet. The hardcoded behaviour just needed a quick if statement added to check the pref. > I'd reckon we put the default (i.e., backspace goes back) in all-camino.js. Yeah, that's what Mark told me on IRC earlier. cl
Created attachment 208833 [details] [diff] [review] Patches the 0 and >1 cases This doesn't fully support the pref (it doesn't do anything for pref = 1, which should map to PgUp/PgDn) but Simon said to upload and then decide whether or not we care about supporting that action in the first place. If anyone cc'd on this bug knows what NSView I should be passing the scroll event to, please comment here. cl
Is there any value to supporting a Linux setting which has absolutely no precedent on the platform? Every request that's come in has just been for a way to turn it off, which is possible without supporting the '1' setting.
Created attachment 209548 [details] [diff] [review] Includes all-camino.js, no support for PgUp/PgDn Per fairly thorough discussion on IRC, not gonna worry about supporting the Gnome mappings at all. This keeps things a lot simpler and solves the problem for 100% of our complainants (including me). This patch adds in the all-camino.js modification as well. cl
*** Bug 328034 has been marked as a duplicate of this bug. ***
Comment on attachment 209548 [details] [diff] [review] Includes all-camino.js, no support for PgUp/PgDn This patch is malformed. Given that it has a net increase of 6 lines, but thinks it should add 14: @@ -2484,29 +2484,43 @@ I'm guessing you edited it by hand--please don't ever post hand-edited patches without verifying that they still apply. Also, it looks like you made two different patches in two different directories, then stuck them together, which makes it even harder to apply. It's easier on reviewers if you make all patches from either the mozilla directory or the camino directory, but you definitely need to make multi-file patches from at least the nearest common ancestor directory.
Created attachment 213273 [details] [diff] [review] Fixed, ready for checkin Fixed and respun without any hand-editing. cl
Comment on attachment 213273 [details] [diff] [review] Fixed, ready for checkin r=me
Comment on attachment 213273 [details] [diff] [review] Fixed, ready for checkin sr=pink
Fix checked into trunk for cl.
Checked into the 1.8-branch as well.
Not a Gecko thing ;)
Verified since I was pointing this out to someone on feedback anyway; this definitely works now...