Closed Bug 320441 Opened 15 years ago Closed 15 years ago

JavaXPCOM is not 64-bit safe

Categories

(Core Graveyard :: Java to XPCOM Bridge, defect, P1)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8final

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

(Keywords: fixed1.8.0.1, fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

JavaXPCOM currently uses "jint" to proxy void*, when it should be using "jlong". Patch forthcoming. This affects the Java reflection and so we should really get it for XR1.8.
Attached patch use jlong, rev. 1 (obsolete) — Splinter Review
Attachment #205999 - Flags: review?(jhpedemonte)
Priority: -- → P1
Attached patch use jlong, v2Splinter Review
This patch fixes some places you missed.  Does this build for you?
Attachment #205999 - Attachment is obsolete: true
Attachment #206011 - Flags: review?(benjamin)
Attachment #205999 - Flags: review?(jhpedemonte)
Comment on attachment 206011 [details] [diff] [review]
use jlong, v2

Yes.
Attachment #206011 - Flags: review?(benjamin) → review+
Checked in to trunk.  Thanks greatly for your help, bsmedberg.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #206011 - Flags: approval1.8.0.1?
Comment on attachment 206011 [details] [diff] [review]
use jlong, v2

Please consider for 1.8.1 - 1.8.0.1 is for major security and crash issues only.
Attachment #206011 - Flags: approval1.8.1?
Attachment #206011 - Flags: approval1.8.0.1?
Attachment #206011 - Flags: approval1.8.0.1-
Comment on attachment 206011 [details] [diff] [review]
use jlong, v2

Re-requesting approval per drivers email, this is javaxpcom-only.
Attachment #206011 - Flags: approval1.8.0.1- → approval1.8.0.1?
Comment on attachment 206011 [details] [diff] [review]
use jlong, v2

a=drivers
Attachment #206011 - Flags: approval1.8.1?
Attachment #206011 - Flags: approval1.8.1+
Attachment #206011 - Flags: approval1.8.0.1?
Attachment #206011 - Flags: approval1.8.0.1+
Fixed on MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.