bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

JavaXPCOM is not 64-bit safe

RESOLVED FIXED in mozilla1.8final

Status

Core Graveyard
Java to XPCOM Bridge
P1
normal
RESOLVED FIXED
13 years ago
4 years ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

({fixed1.8.0.1, fixed1.8.1})

Trunk
mozilla1.8final
x86
Linux
fixed1.8.0.1, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

8.28 KB, patch
Benjamin Smedberg
: review+
Benjamin Smedberg
: approval1.8.0.1+
Benjamin Smedberg
: approval1.8.1+
Details | Diff | Splinter Review
(Assignee)

Description

13 years ago
JavaXPCOM currently uses "jint" to proxy void*, when it should be using "jlong". Patch forthcoming. This affects the Java reflection and so we should really get it for XR1.8.
(Assignee)

Comment 1

13 years ago
Created attachment 205999 [details] [diff] [review]
use jlong, rev. 1
Attachment #205999 - Flags: review?(jhpedemonte)
(Assignee)

Updated

13 years ago
Priority: -- → P1
Created attachment 206011 [details] [diff] [review]
use jlong, v2

This patch fixes some places you missed.  Does this build for you?
Attachment #205999 - Attachment is obsolete: true
Attachment #206011 - Flags: review?(benjamin)
Attachment #205999 - Flags: review?(jhpedemonte)
(Assignee)

Comment 3

13 years ago
Comment on attachment 206011 [details] [diff] [review]
use jlong, v2

Yes.
Attachment #206011 - Flags: review?(benjamin) → review+
Checked in to trunk.  Thanks greatly for your help, bsmedberg.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(Assignee)

Updated

13 years ago
Attachment #206011 - Flags: approval1.8.0.1?
(Assignee)

Updated

13 years ago
Blocks: 302101

Comment 5

13 years ago
Comment on attachment 206011 [details] [diff] [review]
use jlong, v2

Please consider for 1.8.1 - 1.8.0.1 is for major security and crash issues only.
Attachment #206011 - Flags: approval1.8.1?
Attachment #206011 - Flags: approval1.8.0.1?
Attachment #206011 - Flags: approval1.8.0.1-
(Assignee)

Comment 6

13 years ago
Comment on attachment 206011 [details] [diff] [review]
use jlong, v2

Re-requesting approval per drivers email, this is javaxpcom-only.
Attachment #206011 - Flags: approval1.8.0.1- → approval1.8.0.1?
(Assignee)

Comment 7

13 years ago
Comment on attachment 206011 [details] [diff] [review]
use jlong, v2

a=drivers
Attachment #206011 - Flags: approval1.8.1?
Attachment #206011 - Flags: approval1.8.1+
Attachment #206011 - Flags: approval1.8.0.1?
Attachment #206011 - Flags: approval1.8.0.1+
(Assignee)

Comment 8

13 years ago
Fixed on MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH.
Keywords: fixed1.8.0.1, fixed1.8.1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.