Closed
Bug 320441
Opened 19 years ago
Closed 19 years ago
JavaXPCOM is not 64-bit safe
Categories
(Core Graveyard :: Java to XPCOM Bridge, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8final
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
(Keywords: fixed1.8.0.1, fixed1.8.1)
Attachments
(1 file, 1 obsolete file)
|
8.28 KB,
patch
|
benjamin
:
review+
benjamin
:
approval1.8.0.1+
benjamin
:
approval1.8.1+
|
Details | Diff | Splinter Review |
JavaXPCOM currently uses "jint" to proxy void*, when it should be using "jlong". Patch forthcoming. This affects the Java reflection and so we should really get it for XR1.8.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #205999 -
Flags: review?(jhpedemonte)
|
|
Assignee | |
Updated•19 years ago
|
Priority: -- → P1
|
||
Comment 2•19 years ago
|
||
This patch fixes some places you missed. Does this build for you?
Attachment #205999 -
Attachment is obsolete: true
Attachment #206011 -
Flags: review?(benjamin)
Attachment #205999 -
Flags: review?(jhpedemonte)
|
|
Assignee | |
Comment 3•19 years ago
|
||
Comment on attachment 206011 [details] [diff] [review]
use jlong, v2
Yes.
Attachment #206011 -
Flags: review?(benjamin) → review+
|
|
||
Comment 4•19 years ago
|
||
Checked in to trunk. Thanks greatly for your help, bsmedberg.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•19 years ago
|
Attachment #206011 -
Flags: approval1.8.0.1?
|
|
Assignee | |
Updated•19 years ago
|
Blocks: xulrunner-1.8
|
||
Comment 5•19 years ago
|
||
Comment on attachment 206011 [details] [diff] [review]
use jlong, v2
Please consider for 1.8.1 - 1.8.0.1 is for major security and crash issues only.
Attachment #206011 -
Flags: approval1.8.1?
Attachment #206011 -
Flags: approval1.8.0.1?
Attachment #206011 -
Flags: approval1.8.0.1-
|
|
Assignee | |
Comment 6•19 years ago
|
||
Comment on attachment 206011 [details] [diff] [review]
use jlong, v2
Re-requesting approval per drivers email, this is javaxpcom-only.
Attachment #206011 -
Flags: approval1.8.0.1- → approval1.8.0.1?
|
|
Assignee | |
Comment 7•19 years ago
|
||
Comment on attachment 206011 [details] [diff] [review]
use jlong, v2
a=drivers
Attachment #206011 -
Flags: approval1.8.1?
Attachment #206011 -
Flags: approval1.8.1+
Attachment #206011 -
Flags: approval1.8.0.1?
Attachment #206011 -
Flags: approval1.8.0.1+
|
|
Assignee | |
Comment 8•19 years ago
|
||
Fixed on MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH.
Keywords: fixed1.8.0.1,
fixed1.8.1
|
||
Updated•10 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•