320693 - In <tabbrowser.xml>, "Error: this.mCurrentBrowser has no properties"

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20051217 SeaMonkey/1.0b] (nightly) (W98SE)

Spun off from bug 104360 comment 31:

Close a tab with Site Navigation Bar displayed:
{{
Error: this.mCurrentBrowser has no properties
Source File: chrome://global/content/bindings/tabbrowser.xml
Line: 0
}}

Comment 1

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20051217 SeaMonkey/1.5a] (nightly) (W98SE)

Same bug on SMv1.5a Trunk.

Comment 2

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a2) Gecko/20060517 SeaMonkey/1.1a] (nightly) (W98SE)

Bug still there:
I get it when using SiteNavBar=always and/or "webdeveloper_mozilla.xpi" (v1.0.2)
... (the latter is going to make it quite painful :-/)

The triggering code line is 1071
[[
            oldBrowser.destroy();

            if (oldBrowser == this.mCurrentBrowser)
              this.mCurrentBrowser = null;

            this.mTabContainer.removeChild(oldTab);
            this.mPanelContainer.removeChild(oldBrowser); // 1071
]]
at
<http://lxr.mozilla.org/mozilla1.8/source/xpfe/global/resources/content/bindings/tabbrowser.xml#1058>

But it's not obvious to me how the code and the error relate to each other: helpwanted.

Comment 3

[[e-mail]]

I don't normally install extensions, and I do have the site navigation bar showing always, apparently without any problems. Do you have steps to reproduce? Alternatively, if you have Venkman open with the "Debug|Exclude Browser Files" unchecked and "Debug|Error Trigger|Stop for Errors" option selected it might narrow down the location, but web pages might make it stop too :-(

Comment 4

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a2) Gecko/20060517 SeaMonkey/1.1a] (nightly) (W98SE)

(updated) Steps:
0. Have SiteNavBar set to show "as needed" or "always".
1. Load a tab that does not use it, like <about:>.
2. Load a tab that does use it, like a bugzilla page.
3. Close the latter.
3r: Get the error.

(I'll try Venkman only if you can't reproduce, as my computer is way to slow to use it ... ChatZilla (startup) is quite a pain too :-<)

Comment 5

[[e-mail]]

OK, so this is the problem: We delete the current tab. This triggers a pagehide event. The link toolbar then asks for the current document.

if (oldBrowser == this.mCurrentBrowser)
  this.mCurrentBrowser = null;

this.mTabContainer.removeChild(oldTab);
this.mPanelContainer.removeChild(oldBrowser);

Note that removing this leak fix does not help, because although the element still exists its document does not.

Comment 6

[[e-mail]]

Attachment: Proposed patch

This only works because of tab drag-n-drop.

Comment 7

[jag (Peter Annema)]

Comment on attachment 222502 [details] [diff] [review]
Proposed patch

Perhaps add a comment along the lines of "select our new tab, then remove the old stuff so we're in a usable state for things that look for documents going away".

Comment 8

[[e-mail]]

Fix checked in.

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 222502 [details] [diff] [review]
Proposed patch

(In reply to comment #8)
> Fix checked in.

It's an enhanced patch that landed on Trunk
{
2006-05-19 03:21	neil%parkwaycc.co.uk 	mozilla/xpfe/global/resources/content/bindings/tabbrowser.xml 	1.153
}

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a2) Gecko/20060518 SeaMonkey/1.1a] (nightly) (W98SE)

'approval-branch-1.8.1=?': (SeaMonkey only)
for the enhanced version, which works fine on branch too.

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 222502 [details] [diff] [review]
Proposed patch

Requesting approval‑seamonkey1.1a? intead of approval‑branch‑1.8.1?:
I did not pay attention this flag was available on this (SeaMonkey) bug.

Comment 11

[Felix Miata]

I see this in Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8.1a3) Gecko/20060622 SeaMonkey/1.1a

Comment 12

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 222502 [details] [diff] [review]
Proposed patch

a=me for 1.1a

Comment 13

[[e-mail]]

Fix checked in to the branch for SeaMonkey 1.1a

Comment 14

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a3) Gecko/20060623 SeaMonkey/1.1a] (nightly) (W98SE)

V.Fixed on MOZILLA_1_8_BRANCH, between these builds.

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a3) Gecko/20060624 SeaMonkey/1.1a] (nightly) (W98SE)

Comment 15

[tech]

(In reply to comment #15)
> [Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20051217 SeaMonkey/1.0b]
> (nightly) (W98SE)
> 
> Spun off from bug 104360 comment 31:
> 
> Close a tab with Site Navigation Bar displayed:
> {{
> Error: this.mCurrentBrowser has no properties
> Source File: chrome://global/content/bindings/tabbrowser.xml
> Line: 0
> }}
>
REGRESSION 
The bug is back in the last Seamonkey Release
(Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.8.0.9) Gecko/20061211 SeaMonkey/1.0.7)
Jsconsole is filled with :
>Error : this.mCurrentBrowser has no properties
>File : chrome://global/content/bindings/tabbrowser.xml
>Line : 0

and with :
>Error : uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebNavigation.canGoBack]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://navigator/content/nsBrowserStatusHandler.js :: anonymous :: line 306"  data: no]

Comment 16

[[e-mail]]

(In reply to comment #15)
>The bug is back in the last Seamonkey Release
>(Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.8.0.9) Gecko/20061211
>SeaMonkey/1.0.7)
That's a 1.0.x release.

This bug was fixed in 1.1a and will be available in the upcoming 1.1 release.