Closed Bug 320693 Opened 20 years ago Closed 20 years ago

In <tabbrowser.xml>, "Error: this.mCurrentBrowser has no properties"

Categories

(SeaMonkey :: UI Design, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey1.1alpha

People

(Reporter: sgautherie, Assigned: neil)

References

Details

(Keywords: fixed-seamonkey1.1a, Whiteboard: [verified-seamonkey1.1a])

Attachments

(1 file)

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20051217 SeaMonkey/1.0b] (nightly) (W98SE) Spun off from bug 104360 comment 31: Close a tab with Site Navigation Bar displayed: {{ Error: this.mCurrentBrowser has no properties Source File: chrome://global/content/bindings/tabbrowser.xml Line: 0 }}
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20051217 SeaMonkey/1.5a] (nightly) (W98SE) Same bug on SMv1.5a Trunk.
Version: 1.8 Branch → Trunk
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a2) Gecko/20060517 SeaMonkey/1.1a] (nightly) (W98SE) Bug still there: I get it when using SiteNavBar=always and/or "webdeveloper_mozilla.xpi" (v1.0.2) ... (the latter is going to make it quite painful :-/) The triggering code line is 1071 [[ oldBrowser.destroy(); if (oldBrowser == this.mCurrentBrowser) this.mCurrentBrowser = null; this.mTabContainer.removeChild(oldTab); this.mPanelContainer.removeChild(oldBrowser); // 1071 ]] at <http://lxr.mozilla.org/mozilla1.8/source/xpfe/global/resources/content/bindings/tabbrowser.xml#1058> But it's not obvious to me how the code and the error relate to each other: helpwanted.
Keywords: helpwanted
I don't normally install extensions, and I do have the site navigation bar showing always, apparently without any problems. Do you have steps to reproduce? Alternatively, if you have Venkman open with the "Debug|Exclude Browser Files" unchecked and "Debug|Error Trigger|Stop for Errors" option selected it might narrow down the location, but web pages might make it stop too :-(
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a2) Gecko/20060517 SeaMonkey/1.1a] (nightly) (W98SE) (updated) Steps: 0. Have SiteNavBar set to show "as needed" or "always". 1. Load a tab that does not use it, like <about:>. 2. Load a tab that does use it, like a bugzilla page. 3. Close the latter. 3r: Get the error. (I'll try Venkman only if you can't reproduce, as my computer is way to slow to use it ... ChatZilla (startup) is quite a pain too :-<)
OK, so this is the problem: We delete the current tab. This triggers a pagehide event. The link toolbar then asks for the current document. if (oldBrowser == this.mCurrentBrowser) this.mCurrentBrowser = null; this.mTabContainer.removeChild(oldTab); this.mPanelContainer.removeChild(oldBrowser); Note that removing this leak fix does not help, because although the element still exists its document does not.
Attached patch Proposed patch — — Splinter Review
This only works because of tab drag-n-drop.
Assignee: guifeatures → neil
Status: NEW → ASSIGNED
Attachment #222502 - Flags: superreview?
Attachment #222502 - Flags: review?(cst)
Attachment #222502 - Flags: superreview? → superreview?(jag)
Comment on attachment 222502 [details] [diff] [review] Proposed patch Perhaps add a comment along the lines of "select our new tab, then remove the old stuff so we're in a usable state for things that look for documents going away".
Attachment #222502 - Flags: superreview?(jag) → superreview+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Keywords: helpwanted
Resolution: --- → FIXED
Comment on attachment 222502 [details] [diff] [review] Proposed patch (In reply to comment #8) > Fix checked in. It's an enhanced patch that landed on Trunk { 2006-05-19 03:21 neil%parkwaycc.co.uk mozilla/xpfe/global/resources/content/bindings/tabbrowser.xml 1.153 } [Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a2) Gecko/20060518 SeaMonkey/1.1a] (nightly) (W98SE) 'approval-branch-1.8.1=?': (SeaMonkey only) for the enhanced version, which works fine on branch too.
Attachment #222502 - Flags: approval-branch-1.8.1?(neil)
Comment on attachment 222502 [details] [diff] [review] Proposed patch Requesting approval&#8209;seamonkey1.1a? intead of approval&#8209;branch&#8209;1.8.1?: I did not pay attention this flag was available on this (SeaMonkey) bug.
Attachment #222502 - Flags: approval-branch-1.8.1?(neil) → approval-seamonkey1.1a?
I see this in Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8.1a3) Gecko/20060622 SeaMonkey/1.1a
Comment on attachment 222502 [details] [diff] [review] Proposed patch a=me for 1.1a
Attachment #222502 - Flags: approval-seamonkey1.1a? → approval-seamonkey1.1a+
Fix checked in to the branch for SeaMonkey 1.1a
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a3) Gecko/20060623 SeaMonkey/1.1a] (nightly) (W98SE) V.Fixed on MOZILLA_1_8_BRANCH, between these builds. [Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a3) Gecko/20060624 SeaMonkey/1.1a] (nightly) (W98SE)
OS: Windows 98 → All
Whiteboard: [verified-seamonkey1.1a]
Target Milestone: --- → seamonkey1.1alpha
(In reply to comment #15) > [Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20051217 SeaMonkey/1.0b] > (nightly) (W98SE) > > Spun off from bug 104360 comment 31: > > Close a tab with Site Navigation Bar displayed: > {{ > Error: this.mCurrentBrowser has no properties > Source File: chrome://global/content/bindings/tabbrowser.xml > Line: 0 > }} > REGRESSION The bug is back in the last Seamonkey Release (Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.8.0.9) Gecko/20061211 SeaMonkey/1.0.7) Jsconsole is filled with : >Error : this.mCurrentBrowser has no properties >File : chrome://global/content/bindings/tabbrowser.xml >Line : 0 and with : >Error : uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebNavigation.canGoBack]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://navigator/content/nsBrowserStatusHandler.js :: anonymous :: line 306" data: no]
(In reply to comment #15) >The bug is back in the last Seamonkey Release >(Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.8.0.9) Gecko/20061211 >SeaMonkey/1.0.7) That's a 1.0.x release. This bug was fixed in 1.1a and will be available in the upcoming 1.1 release.
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: