320736 - Bad accesskey (button "Submit Report")

Status: RESOLVED FIXED

(Other Applications Graveyard :: Reporter, defect)

Description

[Pavel Cvrcek [:JasnaPaka]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051218 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051218 Firefox/1.6a1

There is a bad accesskey in Reporter. First window of wizard, button "Submit Report > (N)".

Reproducible: Always

Steps to Reproduce:
1. Choose Help -> Report Broken Web Site.
2. There is a bad accesskey. See attachment.
3.

Comment 1

[Pavel Cvrcek [:JasnaPaka]]

Attachment: Screenshot

Comment 2

[Robert Accettura [:raccettura]]

Possibly fallout from 320736.

Comment 3

[Vidar Haarr (not reading bugmail)]

I guess there needs to be an addition here:
<http://lxr.mozilla.org/seamonkey/source/extensions/reporter/resources/content/reporter/reportWizard.js#124>
Like:
reportWizard.getButton('next').accesskey = strbundle.getString("submitReport.accesskey");

And then add that property ('submitReport.accesskey') to reportWizard.properties.

Comment 4

[Robert Accettura [:raccettura]]

Sorry, should have been bug 221783.

I'd rather not patch until I find where it's regressed.

Comment 5

[Vidar Haarr (not reading bugmail)]

(In reply to comment #4)
> Sorry, should have been bug 221783.
> 
> I'd rather not patch until I find where it's regressed.

Hm?

<wizard> default buttons now have access keys assigned by the widget. You override the default label but not the default access key.

Comment 6

[Robert Accettura [:raccettura]]

Reason I say that is I tried the same thing you just posted about 2 days ago, and didn't work.  Since it's not truly 'broken' this hasn't been high prority just yet (hence no bug even).

Comment 7

[Vidar Haarr (not reading bugmail)]

I don't see why it shouldn't work -- that would be a bug.

Maybe change <http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/wizard.xml#370> to |if (accesskey && !btn.accesskey)| or similar.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #6)
> Reason I say that is I tried the same thing you just posted about 2 days ago,
> and didn't work.

Did you try setting the attribute instead of using the property? IIRC the accesskey property doesn't work that great.

Comment 9

[Robert Accettura [:raccettura]]

*** Bug 318129 has been marked as a duplicate of this bug. ***

Comment 10

[Robert Kaiser]

Not blocking a release on this.
The item is working and accessible, it's just a minor UI glitch. Additionally, it's UI that most of our users probably won't see (though I hope people will start using it more and more).
And, BTW, noone told if it's even happening on branch(es)...

Comment 11

[Pavel Cvrcek [:JasnaPaka]]

(In reply to comment #10)
> And, BTW, noone told if it's even happening on branch(es)...

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060112 SeaMonkey/1.0b

Same problem.

Comment 12

[Robert Accettura [:raccettura]]

Attachment: Patch

This should do it.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 208661 [details] [diff] [review]
Patch

r=me

Comment 14

[Robert Accettura [:raccettura]]

Fixed on trunk

Comment 15

[:Gavin Sharp [email: [e-mail]]]

This patch is needed on the 1.8 branch now that bug 221783 landed there.