Closed
Bug 320736
Opened 19 years ago
Closed 19 years ago
Bad accesskey (button "Submit Report")
Categories
(Other Applications Graveyard :: Reporter, defect)
Other Applications Graveyard
Reporter
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: JasnaPaka, Assigned: raccettura)
References
Details
(Keywords: fixed1.8.1)
Attachments
(2 files)
9.28 KB,
image/png
|
Details | |
1.59 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051218 Firefox/1.6a1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051218 Firefox/1.6a1 There is a bad accesskey in Reporter. First window of wizard, button "Submit Report > (N)". Reproducible: Always Steps to Reproduce: 1. Choose Help -> Report Broken Web Site. 2. There is a bad accesskey. See attachment. 3.
Reporter | ||
Comment 1•19 years ago
|
||
Assignee | ||
Comment 2•19 years ago
|
||
Possibly fallout from 320736.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All
Comment 3•19 years ago
|
||
I guess there needs to be an addition here: <http://lxr.mozilla.org/seamonkey/source/extensions/reporter/resources/content/reporter/reportWizard.js#124> Like: reportWizard.getButton('next').accesskey = strbundle.getString("submitReport.accesskey"); And then add that property ('submitReport.accesskey') to reportWizard.properties.
Assignee | ||
Comment 4•19 years ago
|
||
Sorry, should have been bug 221783. I'd rather not patch until I find where it's regressed.
Comment 5•19 years ago
|
||
(In reply to comment #4) > Sorry, should have been bug 221783. > > I'd rather not patch until I find where it's regressed. Hm? <wizard> default buttons now have access keys assigned by the widget. You override the default label but not the default access key.
Assignee | ||
Comment 6•19 years ago
|
||
Reason I say that is I tried the same thing you just posted about 2 days ago, and didn't work. Since it's not truly 'broken' this hasn't been high prority just yet (hence no bug even).
Version: unspecified → Trunk
Comment 7•19 years ago
|
||
I don't see why it shouldn't work -- that would be a bug. Maybe change <http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/wizard.xml#370> to |if (accesskey && !btn.accesskey)| or similar.
Comment 8•19 years ago
|
||
(In reply to comment #6) > Reason I say that is I tried the same thing you just posted about 2 days ago, > and didn't work. Did you try setting the attribute instead of using the property? IIRC the accesskey property doesn't work that great.
Assignee | ||
Comment 9•19 years ago
|
||
*** Bug 318129 has been marked as a duplicate of this bug. ***
Updated•19 years ago
|
Flags: blocking-seamonkey1.0?
Comment 10•19 years ago
|
||
Not blocking a release on this. The item is working and accessible, it's just a minor UI glitch. Additionally, it's UI that most of our users probably won't see (though I hope people will start using it more and more). And, BTW, noone told if it's even happening on branch(es)...
Flags: blocking-seamonkey1.0? → blocking-seamonkey1.0-
Reporter | ||
Comment 11•19 years ago
|
||
(In reply to comment #10) > And, BTW, noone told if it's even happening on branch(es)... Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060112 SeaMonkey/1.0b Same problem.
Assignee | ||
Comment 12•19 years ago
|
||
This should do it.
Assignee | ||
Updated•19 years ago
|
Attachment #208661 -
Flags: review?(gavin.sharp)
Comment 13•19 years ago
|
||
Comment on attachment 208661 [details] [diff] [review] Patch r=me
Attachment #208661 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 14•19 years ago
|
||
Fixed on trunk
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 15•19 years ago
|
||
This patch is needed on the 1.8 branch now that bug 221783 landed there.
Whiteboard: [checkin needed (1.8 branch)]
Assignee | ||
Updated•18 years ago
|
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
Updated•6 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•