321000 - search bar should replace newlines in pasted text with spaces

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[(not currently active) Ted Mielczarek]

Similar to bug 23485 .  I'll attach a patch tonight.

Comment 1

[(not currently active) Ted Mielczarek]

Patch in a moment

Comment 2

[Steve England [:stevee]]

*** Bug 326822 has been marked as a duplicate of this bug. ***

Comment 3

[(not reading, please use [e-mail] instead)]

in addition to the search bar, what about the URL bar, which (I think) does an "I'm feeling lucky" google search if no matching hostname is found.

or if someone does a keyword search in the URL bar.

Comment 4

[(not currently active) Ted Mielczarek]

Seth: I fixed that in bug 23485 and bug 253481.  This bug should use the same backend work.  Unfortunately the straightforward method didn't seem to work, I think the search box uses a different xbl binding for its textbox.  I need to look into it.

Comment 5

[Ria Klaassen (not reading all bugmail)]

*** Bug 352348 has been marked as a duplicate of this bug. ***

Comment 6

[(not reading, please use [e-mail] instead)]

moving it on to my list, for when I return to the trunk.

I'd really like to fix this, as I run into all the time!

Comment 7

[(not currently active) Ted Mielczarek]

Should be pretty easy (see the patch from bug 23485), but you might need to change it in the searchbox binding.

Comment 8

[(not reading, please use [e-mail] instead)]

sorry for the bug spam, re-assigning bugs back to default owner if I'm not working actively on them.

Comment 9

[(not currently active) Ted Mielczarek]

So going to fix this.

Comment 10

[(not currently active) Ted Mielczarek]

Attachment: fix xul:textbox binding to work properly in inherited bindings, add newlines="replacewithspaces" to searchbar binding's textbox

Ok, got it.  Turns out that doing the newline handling in the xul:textbox constructor didn't work for inherited bindings, since their html:input's .editor wasn't initialized at that point.  Neil mentioned something about maybe xbl binding during frame construction.  Anyway, I pulled that code out into a new method, and called it in a setTimeout from the constructor, and now it works for inherited bindings.  The other line of this patch is actually setting newlines="replacewithspaces" in the xul:textbox inside the searchbar binding.

I'm definitely going to write some unit tests for this before I get it checked in.

Comment 11

[(not currently active) Ted Mielczarek]

Attachment: slight modification

Makes a change gavin requested on irc, sets the newlines= on the searchbar element in browser.xul, and add newlines to the xbl:inherits in the searchbar binding.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 279933 [details] [diff] [review]
slight modification

>Index: toolkit/content/widgets/textbox.xml

>+      <method name="setNewlineHandling">

This isn't meant to be "public", so prefix the name with "_" please. r=me with that.

Comment 13

[(not currently active) Ted Mielczarek]

Attachment: with review comment

Ok, carrying forward review.

Comment 14

[(not currently active) Ted Mielczarek]

Attachment: browser chrome test

Browser chrome test for this + bug 23485.

Comment 15

[(not currently active) Ted Mielczarek]

Comment on attachment 279941 [details] [diff] [review]
with review comment

Checked in.  Gavin, how about a review on that unit test?

Comment 16

[[:Aleksej]]

Works in Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a8pre) Gecko/2007091804 Minefield/3.0a8pre.

Comment 17

[(not currently active) Ted Mielczarek]

Checked in the test.