Closed Bug 321070 Opened 15 years ago Closed 15 years ago

[BEOS] Widget dependency cleanup

Categories

(Core Graveyard :: Widget: BeOS, defect)

Other
BeOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: thesuckiestemail, Assigned: thesuckiestemail)

References

Details

Attachments

(1 file)

To many classes know of each other. So to simplify refactoring and improving code dependencies needs to be cleaned up. nsAppShell doesn't need to know about nsWindow or nsToolkit. nsToolkit doesn't need to know about nsWindow or nsAppShell. nsDragService does not need to know about nsWindow. All the common code is mostly related to nsSwitchToUIThread.h so the uglieness stays there (until it's gone completly).
Assignee: nobody → thesuckiestemail
Status: NEW → ASSIGNED
Comment on attachment 206481 [details] [diff] [review]
The suggested changes

r?
As this is only structual and no functional changes I think this code be fixed in the code directly. So if you approve it can be commited.
Attachment #206481 - Flags: review?(sergei_d)
Summary: [BEOS] WIdget dependency cleanup → [BEOS] Widget dependency cleanup
Looks OK, but there is question - where we need defined WM_CALLMETHOD "CAme" ?
And if we need this or that part of this define, maybe we can get rid of MS Window widget code heritage - that WM_**** ?
It was used somewhere (nsAppShell?). So I moved it so nsAppShell and nsToolkit became independent of each other.
Comment on attachment 206481 [details] [diff] [review]
The suggested changes

r=sergei_d
Attachment #206481 - Flags: review?(sergei_d) → review+
landed in trunk:
Checking in mozilla/widget/src/beos//nsAppShell.cpp;
/cvsroot/mozilla/widget/src/beos/nsAppShell.cpp,v  <--  nsAppShell.cpp
new revision: 1.31; previous revision: 1.30
done
Checking in mozilla/widget/src/beos//nsAppShell.h;
/cvsroot/mozilla/widget/src/beos/nsAppShell.h,v  <--  nsAppShell.h
new revision: 1.12; previous revision: 1.11
done
Checking in mozilla/widget/src/beos//nsDragService.cpp;
/cvsroot/mozilla/widget/src/beos/nsDragService.cpp,v  <--  nsDragService.cpp
new revision: 1.15; previous revision: 1.14
done
Checking in mozilla/widget/src/beos//nsDragService.h;
/cvsroot/mozilla/widget/src/beos/nsDragService.h,v  <--  nsDragService.h
new revision: 1.7; previous revision: 1.6
done
Checking in mozilla/widget/src/beos//nsSwitchToUIThread.h;
/cvsroot/mozilla/widget/src/beos/nsSwitchToUIThread.h,v  <--  nsSwitchToUIThread.h
new revision: 1.5; previous revision: 1.4
done
Checking in mozilla/widget/src/beos//nsToolkit.cpp;
/cvsroot/mozilla/widget/src/beos/nsToolkit.cpp,v  <--  nsToolkit.cpp
new revision: 1.24; previous revision: 1.23
done
Checking in mozilla/widget/src/beos//nsToolkit.h;
/cvsroot/mozilla/widget/src/beos/nsToolkit.h,v  <--  nsToolkit.h
new revision: 1.6; previous revision: 1.5
done
Checking in mozilla/widget/src/beos//nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.117; previous revision: 1.116
done
Checking in mozilla/widget/src/beos//nsWindow.h;
/cvsroot/mozilla/widget/src/beos/nsWindow.h,v  <--  nsWindow.h
new revision: 1.51; previous revision: 1.50
done 
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Blocks: 383065
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.