Need confirm dialog when cancelling an install download

NEW
Assigned to

Status

Core Graveyard
Installer: XPInstall Engine
P5
enhancement
19 years ago
6 months ago

People

(Reporter: Jimmy Lee, Assigned: Syd Logan)

Tracking

({helpwanted})

Trunk
Future
helpwanted

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: se-radar [xpiprd])

Attachments

(1 attachment)

(Reporter)

Description

19 years ago
Build: 2000-03-16-06-M15-nb1b(WIN), 2000-03-15-16-M15-nb1b(MAC), 
2000-03-16-05-M15-nb1b (LINUX)

1. From http://jimbob/trigger2.html, click drop-down menu and choose 
   a_addsubcomp_bigfile and click Trigger Case button
2. Click Cancel button from Download dialog to cancel download

RESULT:
Dialog dismisses and download appears to have ended.

EXPECTED RESULT:
Confirm dialog appears and inquires if user is certain that he/she wants to end 
the download and understands the consequences of the action.  This is 
user-friendly and behaves as insurance in case this button was selected by 
accident.

Comment 1

19 years ago
reassign to dbragg.
Assignee: cathleen → dbragg
Target Milestone: M15

Comment 2

19 years ago
moving to M16
Target Milestone: M15 → M16

Comment 3

18 years ago
Nice feature....  It should be a simple Confirm() call.  Maybe two or three 
lines.
Assignee: dbragg → cathleen

Comment 4

18 years ago
possibly for Beta3
Target Milestone: M16 → M18
Parcelling out Cathleen's bugs
Assignee: cathleen → dbragg

Updated

18 years ago
Status: NEW → ASSIGNED
Whiteboard: [nsbeta3-]
Adding nsbeta3 keyword to bugs which already have nsbeta3 status markings so 
the queries don't get all screwed up.
Keywords: nsbeta3

Comment 7

18 years ago
Isn't this a duplicate of bug 42872 ? There's already a patch proposed there.

Comment 8

18 years ago
*** Bug 42872 has been marked as a duplicate of this bug. ***

Comment 9

18 years ago
Moving patch by Henrik Gemal over from 42872, adding keywords.
Keywords: patch, review

Comment 10

18 years ago
Created attachment 15192 [details] [diff] [review]
[patch] by Henrik Gemal "Hooking up the cancel button in the download dialog"
Whiteboard: [nsbeta3-] → [nsbeta3-] se-radar
Resetting target field for missed milestones
Target Milestone: M18 → ---
Keywords: nsbeta1
Whiteboard: [nsbeta3-] se-radar → [nsbeta3-] se-radar [xpiprd]
Target Milestone: --- → mozilla0.9
Moz 0.9 tasks

Comment 13

18 years ago
P5 tasks
Priority: P3 → P5
(Assignee)

Updated

18 years ago
Keywords: nsbeta1, nsbeta3, patch, review → nsbeta1+

Updated

18 years ago
Target Milestone: mozilla0.9 → mozilla0.8.1

Comment 14

18 years ago
Could you please add a config option in either the preferences or hidden in the
configuation files themselves so people can elect to turn off this "feature"?

Thanks...

Comment 15

18 years ago
Sorry, can't use this patch.  Or, more accurately, this patch is for xpfe
downloads not xpinstall "installation" downloads.  Note the diff.  It's compared
to /mozilla/xpfe/components/xfer/resources/downloadProgress.js

The progress dialog in xpinstall is xpinstall/res/content/xpistatus.xul and .js

I personally feel that this would be an annoying feature.  Note that in Windows
Explorer if you're doing a large copy and hit cancel it simply cancels.  It
seems others agree with me (see above comment from Bruce Locke). 
Why would you want to disable it? How often do people install software? What's 
the cost in frustration if they accidentally cancel a long download?

This patch is not appropriate for this bug, nor is it a duplicate of 42872 
which is an entirely different download dialog.
Summary: Confirm dialog should appear when cancelling a download → Need confirm dialog when cancelling an install download
Since the patch is for the wrong bug this is no longer low-hanging fruit. Hard 
to see how this enhancement moves us toward our customer happiness goal more 
than other problems we've got so taking off the nsbeta1 list.
Keywords: nsbeta1+ → nsbeta1-
Target Milestone: mozilla0.8.1 → Future
Keywords: helpwanted
Whiteboard: [nsbeta3-] se-radar [xpiprd] → se-radar [xpiprd]
Don has moved to another group. Install bugs -> syd
Assignee: dbragg → syd
Status: ASSIGNED → NEW
(Assignee)

Updated

17 years ago
Keywords: nsbeta1
(Assignee)

Updated

17 years ago
Keywords: nsbeta1-
(Assignee)

Updated

17 years ago
Keywords: nsbeta1

Comment 19

16 years ago
*** Bug 164878 has been marked as a duplicate of this bug. ***
QA Contact: jimmykenlee → xpi-engine
Product: Core → Core Graveyard

Comment 20

6 months ago
Close this, maybe?
You need to log in before you can comment on or make changes to this bug.