Closed
Bug 321177
Opened 19 years ago
Closed 15 years ago
use depth first search in nsXULTemplateBuilder::DetermineMemberVariable
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: enndeakin, Assigned: enndeakin)
References
Details
Attachments
(1 file)
|
6.00 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
Currently, an inefficient breadth-first search is done. Not a big deal since most action bodies are small but might be work changing to use a depth-first search
|
Assignee | |
Updated•18 years ago
|
Target Milestone: Future → mozilla1.9beta2
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
|
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #412224 -
Flags: review?(jonas)
Comment on attachment 412224 [details] [diff] [review]
just a simplification
It would be slightly faster/cleaner to use this guy to iterate over all children:
http://mxr.mozilla.org/mozilla-central/source/content/base/public/nsINode.h#838
r=me either way
Attachment #412224 -
Flags: review?(jonas) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•