321457 - NSS_LIBS is -L-L../../../../dist/bin ...

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[N.Hayashi]

User-Agent:       Mozilla/5.0 (X11; U; OSF1 alpha; en-US; rv:1.9a1) Gecko/20051216 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (X11; U; OSF1 alpha; en-US; rv:1.9a1) Gecko/20051216 Firefox/1.6a1

If we try link libpipnss.so, the following messages appear and it fails.
cxx -pthread -I/usr/local/include  -noexceptions -ieee -ptr ../../../../dist/cxx_repository -pthread  -DNDEBUG -DTRIMMED -O  -shared -msym -expect_unresolved \* -update_registry ../../../../dist/so_locations -soname libpipnss.so -o libpipnss.so  md4.o nsCipherInfo.o nsNSSCallbacks.o nsNSSComponent.o nsNSSIOLayer.o nsNSSModule.o nsSSLSocketProvider.o nsTLSSocketProvider.o nsSDR.o nsPK11TokenDB.o nsNSSCertificate.o nsPKCS12Blob.o nsNSSASN1Object.o nsKeygenHandler.o nsCrypto.o nsPKCS11Slot.o nsKeygenThread.o nsCMSSecureMessage.o nsCMS.o nsCertPicker.o nsCRLInfo.o nsNSSCertCache.o nsNSSCertHelper.o nsNSSCertificateDB.o nsNSSCertTrust.o nsNSSCertValidity.o nsOCSPResponder.o nsUsageArrayHelper.o nsCRLManager.o nsNSSShutDown.o nsNTLMAuthModule.o nsNSSEvent.o nsSmartCardMonitor.o nsSmartCardEvent.o nsCertTree.o    -L/usr/local/lib ../../../../dist/lib/libunicharutil_s.a -L../../../../dist/bin -lxpcom -lxpcom_core  -liconv -L../../../../dist/bin -L../../../../dist/lib -lplds4 -lplc4 -lnspr4 -L/usr/local/lib -lpthreads -L../../../../dist/bin -lmozjs -L-L../../../../dist/bin -L../../../../dist/lib -lcrmf -lsmime3 -lssl3 -lnss3 -lsoftokn3   -B symbolic -lm -lc_r
cxx: Error: -L../../../../dist/bin not a valid argument to -L



Reproducible: Always




It is guessed that this is caused because of the following.
In mozilla/config/config.mk:617
LIBS_DIR        = -L$(DIST)/bin -L$(DIST)/lib
but
in mozilla/configure.in:3597
NSS_LIBS='-L$(LIBS_DIR)'" -lcrmf -lsmime$NSS_VERSION -lssl$NSS_VERSION -lnss$NSS_VERSION -lsoftokn$NSS_VERSION"

Should be
NSS_LIBS='$(LIBS_DIR)'" -lcrmf -lsmime$NSS_VERSION -lssl$NSS_VERSION -lnss$NSS_VERSION -lsoftokn$NSS_VERSION"

Comment 1

[cls]

*** Bug 322006 has been marked as a duplicate of this bug. ***

Comment 2

[cls]

Fixed.

Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1594; previous revision: 1.1593
done

Comment 3

[R Fleck]

Broken in seamonkey-1.1.12

diff autoconf.mk autoconf.mk~
401c401
< NSS_LIBS      = $(LIBS_DIR) -lcrmf -lsmime3 -lssl3 -lnss3 -lsoftokn3
---
> NSS_LIBS      = -L$(LIBS_DIR) -lcrmf -lsmime3 -lssl3 -lnss3 -lsoftokn3
mozilla/config>

Comment 4

[g. fischer]

problem still present in current MOZILLA_1_8_BRANCH checkout