Closed
Bug 322240
Opened 19 years ago
Closed 16 years ago
Various pref panel items missing accesskeys.
Categories
(SeaMonkey :: Preferences, defect)
SeaMonkey
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a3
People
(Reporter: vhaarr+bmo, Assigned: wladow)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
3.45 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Various pref panel items missing accesskeys that I didn't find a specific Component for: Appearance/ Themes/ "Theme to use"-box. "Get New Themes"-link. Language and Content Packs/ "Installed language packs:"-box. "Installed content packs:"-box. Nagivator/ "Display on"-combobox. Languages/ "Languages in order of preference:"-box. Helper Applications/ "File types:"-box. "When encountered:"-textbox. PFS checkbox. Smart Browsing/ Domain guessing checkbox. Advanced.../ Entire dialog. Roaming User/ Server Information dropdown.
Comment 1•16 years ago
|
||
(Filter "spam" on 'prefs-nobody-20080612'.)
Assignee: prefs → nobody
QA Contact: prefs
Assignee | ||
Comment 2•16 years ago
|
||
> Appearance/ > Themes/ > "Theme to use"-box. > "Get New Themes"-link. > Language and Content Packs/ > "Installed language packs:"-box. > "Installed content packs:"-box. panes removed in bug 372856 and bug 411215 > Nagivator/ > "Display on"-combobox. fixed in this patch > Languages/ > "Languages in order of preference:"-box. fixed in this patch > Helper Applications/ > "File types:"-box. > "When encountered:"-textbox. > PFS checkbox. replaced by new prefpane in Bug 417590 > Smart Browsing/ > Domain guessing checkbox. > Advanced.../ > Entire dialog. replaced by new prefpane in bug 411226 > Roaming User/ > Server Information dropdown. pane removed from 2.0 builds
Assignee: nobody → wladow
Status: NEW → ASSIGNED
Attachment #354059 -
Flags: superreview?(neil)
Attachment #354059 -
Flags: review?(neil)
Comment 3•16 years ago
|
||
Comment on attachment 354059 [details] [diff] [review] add accesskeys, v1 >- <label control="activeLanguages">&languages.customize.active.label;</label> >+ <label control="activeLanguages" >+ value="&languages.customize.active.label;" >+ accesskey="&languages.customize.active.accesskey;"/> Why change the content to the value attribute? (There's a slight difference as the attribute version won't wrap, which might be a problem in some languages?) >+<!ENTITY navRadio.label "Display on"> >+<!ENTITY navRadio.accesskey "a"> I think "n" would make a better access key.
Assignee | ||
Comment 4•16 years ago
|
||
- fixed label value back to content - changed navRadio.accesskey to "n", although I personally don't like acceskeys being placed under the last char in a string
Attachment #354059 -
Attachment is obsolete: true
Attachment #355012 -
Flags: superreview?(neil)
Attachment #355012 -
Flags: review?(neil)
Attachment #354059 -
Flags: superreview?(neil)
Attachment #354059 -
Flags: review?(neil)
Updated•16 years ago
|
Attachment #355012 -
Flags: superreview?(neil)
Attachment #355012 -
Flags: superreview+
Attachment #355012 -
Flags: review?(neil)
Attachment #355012 -
Flags: review+
Comment 5•16 years ago
|
||
Comment on attachment 355012 [details] [diff] [review] add accesskeys, v2 [Checkin: Comment 6] >I personally don't like access keys being placed under the last char in a string Yeah, but neither are you supposed to use vowels.
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Comment 6•16 years ago
|
||
Comment on attachment 355012 [details] [diff] [review] add accesskeys, v2 [Checkin: Comment 6] http://hg.mozilla.org/comm-central/rev/f6df39970eca
Attachment #355012 -
Attachment description: add accesskeys, v2 → add accesskeys, v2
[Checkin: Comment 6]
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0a3
You need to log in
before you can comment on or make changes to this bug.
Description
•