322773 - <iframe src="bogus:"> triggers "ASSERTION: nsPrompt used too early on window object!"

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P3)

Description

[Jesse Ruderman]

To reproduce, load data:text/html,<iframe src="bogus:">.

###!!! ASSERTION: nsPrompt used too early on window object!: 'window->GetExtantDocument() != nsnull', file /Users/admin/trunk/mozilla/embedding/components/windowwatcher/src/nsPrompt.cpp, line 176
Break: at file /Users/admin/trunk/mozilla/embedding/components/windowwatcher/src/nsPrompt.cpp, line 176

See also bug 286708, another way to trigger the same assertion message.

Comment 1

[Boris Zbarsky [:bzbarsky]]

jst, the problem is that the iframe is trying to pose a "invalid protocol" dialog... In general, it seems to me that the prompter stuff should ensure an inner window instead of asserting there is one, if it depends on there being one.

What do you think?

Comment 2

[[e-mail]]

(In reply to comment #1)
>In general, it seems to me that the prompter stuff should ensure an inner
>window instead of asserting there is one, if it depends on there being one.
In fact it effectively does so in the subsequent code, see http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/embedding/components/windowwatcher/src/nsPrompt.cpp&rev=1.22&mark=180-181#171

Comment 3

[Boris Zbarsky [:bzbarsky]]

Right.  That's not desirable in some cases (bug 284993).  But perhaps this is not the right place to assert...

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Ensure an inner window

I'm not sure if this is a hack or not. My idea is that if we're trying to report an error, then this is the first time that we really _need_ to make sure we have an inner window (which translates into an about:blank document in this case).

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 208794 [details] [diff] [review]
Ensure an inner window

Shouldn't that be handled by DisplayLoadError itself, when it actually prompts (as opposed to going directly into loading an error page)?

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Yeah, it should

I decided to expand the GetDocument call into the docshell code since I think it more clearly conveys what the prompt service is expecting.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 8

[Jesse Ruderman]

in-testsuite- due to bug 292510.