CTRL+(+= key) to increase text size does not work

RESOLVED FIXED

Status

()

Core
Widget: Win32
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: u88484, Assigned: Dainis Jonitis)

Tracking

({regression})

Trunk
x86
Windows XP
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

fix
4.45 KB, patch
Ere Maijala (slow)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

12 years ago
When I hit CTRL++ to increase the text size or View->text size->Increase nothing happens.  I think this has been around for at least a week or two.

Nothing in the javascript console.
(Reporter)

Comment 1

12 years ago
Meant to include that CTRL + - does work to decrease the text size, along with the menu entry works as well.
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060108 Firefox/1.6a1 ID:2006010901

WFM, both (I use it "all the time")

any page in particular (I don't have Yahoo mail) ?

Comment 3

12 years ago
Short cut do not work.Menu item works.
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060108 Firefox/1.6a1 ID:2006010806
(Reporter)

Comment 4

12 years ago
(In reply to comment #2)
> Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060108
> Firefox/1.6a1 ID:2006010901
> 
> WFM, both (I use it "all the time")
> 
> any page in particular (I don't have Yahoo mail) ?
> 

any website.

forgot to add
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060108 Firefox/1.6a1

Comment 5

12 years ago
short cut and menu item, both WFM.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060108 Firefox/1.6a1 ID:2006010806
right,

works: ctrl + + / ctrl + 0 / ctrl + - , all 3 from from numpad.
works: from menu view->textsize, increase/normal/decrease
works: ctrl + - / ctrl + 0 , both from keyboard
fails: ctrl + + from keyboard ,regression, this works in 1.5.
Keywords: regression
(Reporter)

Comment 7

12 years ago
Sorry, won't post bugs at 6 something in the morning anymore right after I get to work.

I'm using a laptop without a numpad so I am using the CTRL+(+= key) and that does not work but the CTRL+(-_ key) works.
(Reporter)

Updated

12 years ago
Summary: CTRL++ and View->Text size->Increase does not work → CTRL++ (+= key) to Increase text size does not work
(Reporter)

Updated

12 years ago
Summary: CTRL++ (+= key) to Increase text size does not work → CTRL+(+= key) to increase text size does not work

Comment 9

12 years ago
Yes, it is definitely bug 287179. 

works in 20060107 1040pst build
fail  in 20060108 0100pst build

which means it's neither bug 322185 nor bug 318894 .

 
(Reporter)

Comment 10

12 years ago
Per regis on mozillazine:

About [ctrl]+[=], if you go to this keyboard test https://bugzilla.mozilla.org/attachment.cgi?id=55849&action=view , and try [ctrl]+[-] then [-] and [ctrl]+[=] then [=], you get :
1) keydown charCode=0 keyCode=54 character=|\0| modifiers=Ctrl
2) keypress charCode=45 keyCode=0 character=|-| modifiers=Ctrl
3) keyup charCode=0 keyCode=54 character=|\0| modifiers=Ctrl

4) keydown charCode=0 keyCode=54 character=|\0|
5) keypress charCode=45 keyCode=0 character=|-|
6) keyup charCode=0 keyCode=54 character=|\0|

7) keydown charCode=0 keyCode=61 character=|\0| modifiers=Ctrl
8) keypress charCode=0 keyCode=61 character=|\0| modifiers=Ctrl <------ this is wrong
9) keyup charCode=0 keyCode=61 character=|\0| modifiers=Ctrl

10) keydown charCode=0 keyCode=61 character=|\0|
11) keypress charCode=61 keyCode=0 character=|=|
12) keyup charCode=0 keyCode=61 character=|\0|[/code]
line 8 should be "keypress charCode=61 keyCode=0 character=|=| modifiers=Ctrl".
(Reporter)

Updated

12 years ago
Blocks: 287179

Comment 11

12 years ago
Please ignore comment #9. Wrong bug. Wrong O/S.
(Assignee)

Comment 12

12 years ago
I know where the problem is. nsWindow::MapFromNativeToDOM maps virtual code for '+' (VK_OEM_PLUS = 0xBB) to NS_VK_EQUALS = 0x3D and KeyboardLayout::GetKeyIndex() does not expect such remapping. As result KeyboardLayout::IsPrintableCharKey returns false.
Assignee: general → Dainis_Jonitis
(Assignee)

Comment 13

12 years ago
Created attachment 208022 [details] [diff] [review]
fix

This fixes problem. When passing virtual key code to KeyboardLayout methods use native Win32 virtual keycodes, not ones mapped to platform independent DOM analogues.
Attachment #208022 - Flags: review?(emaijala)
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
Component: DOM: Views and Formatting → Widget: Win32

Updated

12 years ago
Attachment #208022 - Flags: review?(emaijala) → review+

Comment 14

12 years ago
Running
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060109 Firefox/1.6a1
I see the CTRL/= problem (that is, hitting the =+ key while holding down the
Ctrl key used to increase the font size and no longer does).  I also see two
other odd behaviors which may or may not be related:

    the left alt key works as a menu accelerator, but the right alt
    key no long works (when I type RIGHT-ALT/A to 
    https://bugzilla.mozilla.org/attachment.cgi?id=55849&action=view
    it shows the modifiers as Ctrl+Alt.  LEFT-ALT/A shows only an
    Alt modifier as expected)

    However, once I get into a dialog (for example, Tools\Options...)
    the right alt key starts working again.

    finally, in a given session, I can only use the options dialog
    once.  After the first usage, the options dialog comes up blank,
    except for a row of (inactive) icons and labels at the upper left
    and a checkmark and X at the lower right.

Anybody else seeing these additional weirdnesses?
(Assignee)

Comment 15

12 years ago
Right Alt is actually the shortcut for Ctrl + Alt.
If you use keyboard layoyt that uses the Ctrl + Alt + letter combination then now it is working as expected (producing the character that is encoded in keyboard layout) instead of producing the EN-US character. Verify in Notepad what character you get when you press Right Alt + letter.
(In reply to comment #14)
>     finally, in a given session, I can only use the options dialog
>     once.  After the first usage, the options dialog comes up blank,
>     except for a row of (inactive) icons and labels at the upper left
>     and a checkmark and X at the lower right.
that's bug 322701

Comment 17

12 years ago
(in reply to comment #15)
> Right Alt is actually the shortcut for Ctrl + Alt.
> If you use keyboard layoyt that uses the Ctrl + Alt + letter combination then
> now it is working as expected (producing the character that is encoded in
> keyboard layout) instead of producing the EN-US character. Verify in Notepad
> what character you get when you press Right Alt + letter.

But I am an EN-US user.  My intl.accept_languages is set to "en-us, en".
HKCU\Control Panel\International\sLanguage is "ENU".  And, as noted above,
my build id includes en-US;.  Left Alt and Right Alt only behave differently
(for me) in Firefox, not in other applications.  What am I missing?

(in reply to comment #16)
thanks for the pointer to bug 322701 (as you - and dozens of others - already
know, I added my name to the CC list for that one).  I saw all 3 of these
behaviors precipitate at once (but I was off the net from 12/21 to 1/6 so,
in retrospect, they may well have happened at different times).

Comment 18

12 years ago
(In reply to comment #7)
> Sorry, won't post bugs at 6 something in the morning anymore right after I get
> to work.
> 
> I'm using a laptop without a numpad so I am using the CTRL+(+= key) and that
> does not work but the CTRL+(-_ key) works.
> 

Ditto that... using build:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060110 Firefox/1.6a1 ID:2006011103
(Assignee)

Comment 19

12 years ago
The patch for bug 287179 that caused this problem was backed out. If there will be a new patch for 287179, it will contain the fix for this bug.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.