Closed
Bug 322813
Opened 19 years ago
Closed 19 years ago
CTRL+(+= key) to increase text size does not work
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: u88484, Assigned: jonitis)
References
Details
(Keywords: regression)
Attachments
(1 file)
4.45 KB,
patch
|
emaijala+moz
:
review+
|
Details | Diff | Splinter Review |
When I hit CTRL++ to increase the text size or View->text size->Increase nothing happens. I think this has been around for at least a week or two. Nothing in the javascript console.
Meant to include that CTRL + - does work to decrease the text size, along with the menu entry works as well.
Comment 2•19 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060108 Firefox/1.6a1 ID:2006010901 WFM, both (I use it "all the time") any page in particular (I don't have Yahoo mail) ?
Comment 3•19 years ago
|
||
Short cut do not work.Menu item works. Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060108 Firefox/1.6a1 ID:2006010806
(In reply to comment #2) > Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060108 > Firefox/1.6a1 ID:2006010901 > > WFM, both (I use it "all the time") > > any page in particular (I don't have Yahoo mail) ? > any website. forgot to add Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060108 Firefox/1.6a1
short cut and menu item, both WFM. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060108 Firefox/1.6a1 ID:2006010806
Comment 6•19 years ago
|
||
right, works: ctrl + + / ctrl + 0 / ctrl + - , all 3 from from numpad. works: from menu view->textsize, increase/normal/decrease works: ctrl + - / ctrl + 0 , both from keyboard fails: ctrl + + from keyboard ,regression, this works in 1.5.
Keywords: regression
Sorry, won't post bugs at 6 something in the morning anymore right after I get to work. I'm using a laptop without a numpad so I am using the CTRL+(+= key) and that does not work but the CTRL+(-_ key) works.
Summary: CTRL++ and View->Text size->Increase does not work → CTRL++ (+= key) to Increase text size does not work
Summary: CTRL++ (+= key) to Increase text size does not work → CTRL+(+= key) to increase text size does not work
Comment 8•19 years ago
|
||
works in 20060107 0550pst build fails in 20060107 1159pst build http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=20060107+0500&maxdate=20060107+1159&cvsroot=%2Fcvsroot my money on bug 287179
Comment 9•19 years ago
|
||
Yes, it is definitely bug 287179. works in 20060107 1040pst build fail in 20060108 0100pst build which means it's neither bug 322185 nor bug 318894 .
Reporter | ||
Comment 10•19 years ago
|
||
Per regis on mozillazine: About [ctrl]+[=], if you go to this keyboard test https://bugzilla.mozilla.org/attachment.cgi?id=55849&action=view , and try [ctrl]+[-] then [-] and [ctrl]+[=] then [=], you get : 1) keydown charCode=0 keyCode=54 character=|\0| modifiers=Ctrl 2) keypress charCode=45 keyCode=0 character=|-| modifiers=Ctrl 3) keyup charCode=0 keyCode=54 character=|\0| modifiers=Ctrl 4) keydown charCode=0 keyCode=54 character=|\0| 5) keypress charCode=45 keyCode=0 character=|-| 6) keyup charCode=0 keyCode=54 character=|\0| 7) keydown charCode=0 keyCode=61 character=|\0| modifiers=Ctrl 8) keypress charCode=0 keyCode=61 character=|\0| modifiers=Ctrl <------ this is wrong 9) keyup charCode=0 keyCode=61 character=|\0| modifiers=Ctrl 10) keydown charCode=0 keyCode=61 character=|\0| 11) keypress charCode=61 keyCode=0 character=|=| 12) keyup charCode=0 keyCode=61 character=|\0|[/code] line 8 should be "keypress charCode=61 keyCode=0 character=|=| modifiers=Ctrl".
Comment 11•19 years ago
|
||
Please ignore comment #9. Wrong bug. Wrong O/S.
Assignee | ||
Comment 12•19 years ago
|
||
I know where the problem is. nsWindow::MapFromNativeToDOM maps virtual code for '+' (VK_OEM_PLUS = 0xBB) to NS_VK_EQUALS = 0x3D and KeyboardLayout::GetKeyIndex() does not expect such remapping. As result KeyboardLayout::IsPrintableCharKey returns false.
Assignee: general → Dainis_Jonitis
Assignee | ||
Comment 13•19 years ago
|
||
This fixes problem. When passing virtual key code to KeyboardLayout methods use native Win32 virtual keycodes, not ones mapped to platform independent DOM analogues.
Attachment #208022 -
Flags: review?(emaijala)
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Component: DOM: Views and Formatting → Widget: Win32
Updated•19 years ago
|
Attachment #208022 -
Flags: review?(emaijala) → review+
Comment 14•19 years ago
|
||
Running Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060109 Firefox/1.6a1 I see the CTRL/= problem (that is, hitting the =+ key while holding down the Ctrl key used to increase the font size and no longer does). I also see two other odd behaviors which may or may not be related: the left alt key works as a menu accelerator, but the right alt key no long works (when I type RIGHT-ALT/A to https://bugzilla.mozilla.org/attachment.cgi?id=55849&action=view it shows the modifiers as Ctrl+Alt. LEFT-ALT/A shows only an Alt modifier as expected) However, once I get into a dialog (for example, Tools\Options...) the right alt key starts working again. finally, in a given session, I can only use the options dialog once. After the first usage, the options dialog comes up blank, except for a row of (inactive) icons and labels at the upper left and a checkmark and X at the lower right. Anybody else seeing these additional weirdnesses?
Assignee | ||
Comment 15•19 years ago
|
||
Right Alt is actually the shortcut for Ctrl + Alt. If you use keyboard layoyt that uses the Ctrl + Alt + letter combination then now it is working as expected (producing the character that is encoded in keyboard layout) instead of producing the EN-US character. Verify in Notepad what character you get when you press Right Alt + letter.
Comment 16•19 years ago
|
||
(In reply to comment #14) > finally, in a given session, I can only use the options dialog > once. After the first usage, the options dialog comes up blank, > except for a row of (inactive) icons and labels at the upper left > and a checkmark and X at the lower right. that's bug 322701
Comment 17•19 years ago
|
||
(in reply to comment #15) > Right Alt is actually the shortcut for Ctrl + Alt. > If you use keyboard layoyt that uses the Ctrl + Alt + letter combination then > now it is working as expected (producing the character that is encoded in > keyboard layout) instead of producing the EN-US character. Verify in Notepad > what character you get when you press Right Alt + letter. But I am an EN-US user. My intl.accept_languages is set to "en-us, en". HKCU\Control Panel\International\sLanguage is "ENU". And, as noted above, my build id includes en-US;. Left Alt and Right Alt only behave differently (for me) in Firefox, not in other applications. What am I missing? (in reply to comment #16) thanks for the pointer to bug 322701 (as you - and dozens of others - already know, I added my name to the CC list for that one). I saw all 3 of these behaviors precipitate at once (but I was off the net from 12/21 to 1/6 so, in retrospect, they may well have happened at different times).
Comment 18•19 years ago
|
||
(In reply to comment #7) > Sorry, won't post bugs at 6 something in the morning anymore right after I get > to work. > > I'm using a laptop without a numpad so I am using the CTRL+(+= key) and that > does not work but the CTRL+(-_ key) works. > Ditto that... using build: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060110 Firefox/1.6a1 ID:2006011103
Assignee | ||
Comment 19•19 years ago
|
||
The patch for bug 287179 that caused this problem was backed out. If there will be a new patch for 287179, it will contain the fix for this bug.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•