322833 - Can't install plugins with Plugin Finder - gets stuck at license

Status: VERIFIED FIXED

(Toolkit Graveyard :: Plugin Finder Service, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060108 Firefox/1.6a1 ID:2006010901

repro:
1. Rename NPSWF32.dll (shockwave flash 8.0.22 plugin)
2. Open Firefox
3. Open a page with flash
4. The Plugin Finder bar pops up, press [Install Missing Plugins...]
5. The Plugin Finder Service pops up and tells you you need Macromedia Flash Player
6. Press the [Next] button
7. "read" the licence and select the radiobutton [I agree]

result: The next button remains grayed out and you can only close the dialog

expected: to continue and install the plugin

Comment 1

[Peter van der Woude [:Peter6]]

works in 20051230 1743pst build
fails in 20060103 2337pst build

regressionwindow:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=20051230+1700&maxdate=20060103+2337&cvsroot=%2Fcvsroot

Comment 2

[Doron Rosenberg (IBM)]

probably my fault

Comment 3

[Doron Rosenberg (IBM)]

Attachment: patch

D'oh.  I was only setting pluginsToInstallNum if the user changed the selection of plugins to be installed in the plugin list.  So now, init it when we show the plugin list page.

Comment 4

[Martijn Wargers (dead)]

Dorn, you've set the review flag to no one. I don't think that was meant, is it?

Comment 5

[Doron Rosenberg (IBM)]

Comment on attachment 208016 [details] [diff] [review]
patch

oops

Comment 6

[:Gavin Sharp [email: [e-mail]]]

*** Bug 324280 has been marked as a duplicate of this bug. ***

Comment 7

[andrew morton]

I'm suck on this too. Hopefully a fix'll get committed before too long.

Comment 8

[Pete Holzmann]

Confirmed. And I agree -- this needs a fix soon. 

It's not surprising that many users have a hard time finding and using the other UI path to plugins (Tools->Extensions, click on Get More Extensions, let page open, click on Plugins tab). Not the most obvious ;)

Comment 9

[Peter van der Woude [:Peter6]]

Any chance anyone else can review this patch.
mconnor has 100+ reviews in his queue and obviously doesn't have the time look at them.

Comment 10

[Doron Rosenberg (IBM)]

cc: rob strong in case he want to review :)

This is trunk only though, you should be using 1.8.1 branch and testing for FF2 folks! :)

Comment 11

[Peter van der Woude [:Peter6]]

(In reply to comment #10)
> This is trunk only though, you should be using 1.8.1 branch and testing for FF2
> folks! :)
Nah, we catch the bugs before they land on banch ;-)

Comment 12

[Robert Strong (they/them - no direct email)]

Comment on attachment 208016 [details] [diff] [review]
patch

Looks good.

Comment 13

[Doron Rosenberg (IBM)]

thanks for the review!

Comment 14

[Noa Groveman]

I'm experiencing this bug with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20060223 Firefox/1.5  (latest branch nightly)

Comment 15

[Doron Rosenberg (IBM)]

(In reply to comment #14)
> I'm experiencing this bug with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
> rv:1.8) Gecko/20060223 Firefox/1.5  (latest branch nightly)
> 

File a bug if it happens in 1.8.1 branch bits.

Comment 16

[Frank Wein [:mcsmurf]]

Bug 328365 was filed (poor Comment 0 so! ;-).

Comment 17

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 208016 [details] [diff] [review]
patch

The patch from bug 283274 was landed on the 1.8 branch in bug 264282, so this patch needs to be landed on the branch too.

Comment 18

[:Gavin Sharp [email: [e-mail]]]

*** Bug 328365 has been marked as a duplicate of this bug. ***

Comment 19

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/mozapps/plugins/content/pluginInstallerWizard.js; 1.13.2.2;

Comment 20

[Carsten Book [:Tomcat]]

verfied fixed with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1b2) Gecko/20060829 BonEcho/2.0b2