Closed Bug 323171 Opened 19 years ago Closed 3 years ago

No logoff with FTP is done, a endless loop of messageboxes

Categories

(Calendar :: Internal Components, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: chris.nick, Unassigned)

Details

Attachments

(1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8) Gecko/20051111 Firefox/1.5

There is no logoff by using the ftp-transfer. After using the ftp more times the message:"530 Sorry the maximum Number of clients (20) from your host are allreayd connected."
It is not possible to end the loop of the showen messageboxes while pressing "ok" oder "apport" or "X" (closing). *Only killing the aplikation is possible*.

Reproducible: Always

Steps to Reproduce:
1.Start Mozilla Sunbird
2.select a calendear-file on ftp-server. coose a file-transfer "puplic the file" 
3.do this 20 times or what the provider of ftp allowes
4.then it is done, the maximum of conetions is reached
5.try to login to the ftp with a ftp-program. you can read the same message there:
530 Sorry, the maximum number of clients (20) from your host are already connected.
Reconnect failed.
The connection is dead.  Sorry.
Actual Results:  
Messagebox for input the password is sowen. input a password. click to OK. The same Box is showen. Click to Esc. The same. Close the box. The same. After atime the box warning. 412 closing contorl conection. timeout. Click OK. Start with request for password. and so on
Another part of this problem is that publish isn't reusing an existing FTP connection.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Christian: what version of Sunbird are you using?
The bugspam monkeys have struck again. They are currently chewing on default assignees for Calendar. Be afraid for your sanity!
Assignee: base → nobody
Blocks 0.3, if we still have this bug.
Severity: critical → normal
Flags: blocking0.3+
Whiteboard: [swag: 1d]
Attached patch Allowing publishing to occur - part I of fix (obsolete) — — Splinter Review
This code allows the publishing to complete. Without the extra empty argument, a javascript exception was thrown at the call to exportToStream. 

This way we can now publish calendars up to an FTP server.  However, this does not address the original bug filed in this defect.
Attachment #233804 - Flags: first-review?(jminta)
Reporter, do you have additional steps or information for this bug? I cannot recreate the scenario you are seeing with an FTP Publish.

Comment on attachment 233804 [details] [diff] [review]
Allowing publishing to occur - part I of fix

https://bugzilla.mozilla.org/attachment.cgi?id=233667&action=diff does the same thing :)
Comment on attachment 233804 [details] [diff] [review]
Allowing publishing to occur - part I of fix

Cancelling review. It seems this issue is already addressed elsewhere.
Attachment #233804 - Flags: first-review?(jminta) → first-review?
It seems like there is no way in necko to issue a LOGOUT. But is that really needed? Maybe the problem is that we create a new connection for every publish, but the old one isn't closed. Maybe the channel is leaked somehow.
Whiteboard: [swag: 1d] → [swag: 1d][no l10n impact]
Whiteboard: [swag: 1d][no l10n impact] → [swag: 1d][no l10n impact][needs patch]
Comment on attachment 233804 [details] [diff] [review]
Allowing publishing to occur - part I of fix

Fixed in other bug
Attachment #233804 - Attachment is obsolete: true
Attachment #233804 - Flags: first-review?
Given the comments here, it's not clear that this bug still exists.  Unless someone can reproduce it, we should mark this bug WORKSFORME.
Keywords: qawanted
Whiteboard: [swag: 1d][no l10n impact][needs patch] → [needs testing]
I set up an ftp server to try this: Maximum allowed connections 5

I could create 6 different calendars on this server and change events in every calendar without problems. Sunbird was using two channels for this.

However, upon restart Sunbird wanted to open two channels for each calendar and could therefore only open 3 calendars. The remaining three calendars could not be retrieved. An error message comes up: 5 users (the maximum) are already logged in, sory"

--> CONFIRMED with latetest nightly

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060918 Calendar/0.3a2+
Sorry, I was not reading carefully:
I can confirm comment 1 of this bug (not reusing the same channel). But there is no endless loop of message boxes as stated in the summary!
ok, with some comments from dmose on irc I did some further testing that might be of interest in this bug:

Setup: - I have a ftp server with a maximum of 5 connections
       - in Sunbird I subscribed to 6 different calendars on the same server (as the same user)

after restart:
       - I get 5 login prompts and one error message (too many connections)
       - only the events of 5 calendars are visible
       - the sixth calendar is not put in read-only mode

after reloading:
       - I get no login prompt but again the error message (too many connections)
       - one calendar is not updated (note that the order of calendars to download seems to change randomly)

after closing Sunbird:
       - there are 5 logouts issued

manipulating/adding multiple events to all subscribed calendars works. It also for the one not loaded before, resulting in dataloss, because the file is simply overwritten.

publishing one calendar to 7 different files on the same server did also work (I was asked once for login).
While this is an unfortunate bug, it does sound like the most painful part of it has been fixed, as per Sebo's QA.  Furthermore, the remaining issues are only likely to be seen by people who use FTP servers for multiple calendars, which seems likely to be a small number.  Not blocking 0.3.
Flags: blocking0.3+ → blocking0.3-
Removing [needs testing] and qawanted flags. I believe that Sebo's analysis fulfills these requirements.
Keywords: qawanted
Whiteboard: [needs testing]
The problem iss still annoying. When I see a page with many pictures stored on passworded FTP server, I have a cicled loop of message boxes "Incorrect password". If there will be 1000 pictures, it will be DoS for my browser, so I think, the priority of the task may be changed in the upper side...
(In reply to comment #17)
Dmitriy, you got a wrong Bug. Neither Sunbird nor Lightning allow web browsing. I think you were looking for a Firebox or SeaMonkey bug instead.
I can confirm comment #14 https://bugzilla.mozilla.org/show_bug.cgi?id=323171#c14 

A trivial solution (IMHO) would be to allow always only one ftp-connection at a time, and carefully close it when done. Serial=slow, but easy to implement and safe, no?

Ultimately, there should be configuration options like
  network.http.max-connections
  network.http.max-connections-per-server
  etc.
only for ftp (and the other protocols?!)
Flags: wanted-calendar0.9+
Please do not set the '+' bit on flags. Those are reserved for release drivers.
Flags: wanted-calendar0.9+ → wanted-calendar0.9?
Flags: wanted-calendar0.9? → wanted-calendar0.9-

Resolving WONTFIX as FTP capability has been discontinued (bug 1574475).

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: